Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Apr 2023 21:43:57 +0200
From:   Andreas Klinger <ak@it-klinger.de>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Angel Iglesias <ang.iglesiasg@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: pressure: Honeywell mpr pressure sensor
Message-ID: <ZC8g/dfMYWZcW4zg@arbad>
References: <20230401185717.1b971617@jic23-huawei>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230401185717.1b971617@jic23-huawei>
UI-OutboundReport: notjunk:1;M01:P0:QYJIZEuSZU4=;rtzbL/dL5fcU4v/ErbYUA7oc8Zo
 9Fem+P98U7oEvwhh+Xj8CL6HfDP7ocUjH8LgISr2Jcf2UbAwmsZcOD7tfyaLWPqkL8RsgiUDX
 qYaASNl5B8vvDAGf/BOZCQtlmKvScCiEiRwLZzz+1BW8/nPiEKdk1r9dxBEXtjQHysoUs+l2Y
 Hymv7oDNWcfIODBz4pc9chg4wpFXK8LNUy0fBFMFpxJWAfU9/5BhumqcSl7Q778kBc4ivlb19
 XdRgldANPjZL+V7iD2s+tetc0Z79y4BYSiTJl5itzy8B7pY8RJaUp0kON2xL8fV1fFACyjwec
 EjiKvOryRLhwPgBsTEtoqzpClwLOzJI8bsuG0y8+S0u4x2tr4ufk7z/zwKjWK4ZQ3rpy/JLOK
 0RiaNODS1VzqzBoWW+FTCpPShX6VNbhylxi4P8hQtSeb8P9MniBG0Y0PwDgiBPDHICoNGoRnS
 U5pCU4GyfSIeFYrOfLLbbno7jhm5CAS7etYWYJxinsBbxrMDDkrdNGbrTuL/ZuOEd5/np+WwK
 RsPnyRMbfXGR//FniJKMg2KQ0EBRikveYMFSPmaGZsq13yf0mbMrUnygPSK9MS1OcTauQinLe
 +ostEJRhc+jVKi1jfUa6a0xoun4093tRL6nQrDzCGbApJ8mnuOrKY/0DREShe7eobl0Zcxcmv
 +JULuUgmgLasBVXjAI4KrazSAS9+l+iaWYZkr+lOaQ==
Precedence: bulk

Hi Jonathan,

thanks for the extensive review. Most of it is clear but one questions remain.
See below.

Jonathan Cameron <jic23@kernel.org> schrieb am Sa, 01. Apr 18:57:
> > +static void mpr_reset(struct mpr_data *data)
> > +{
> > +	if (data->gpiod_reset) {
> > +		gpiod_set_value(data->gpiod_reset, 0);
> > +		udelay(10);
> > +		gpiod_set_value(data->gpiod_reset, 1);
> > +	}
> 
> If there isn't a reset signal, I'd like to see an attempt at least to write
> all configuration registers to a known value (same as the one you'd
> get after reset).  

There is no configuration register in the sensor I could write to. But maybe I
didn't comprehend your point.

Andreas