Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 6 Apr 2023 15:58:30 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
        "linux-sparse@vger.kernel.org" <linux-sparse@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Miguel Ojeda <ojeda@kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>
Subject: Re: [PATCH] tools: Rename __fallthrough to fallthrough
Message-ID: <20230406195830.ieiozetmk7qjllol@revolver>
References: <20221125154947.2163498-1-Liam.Howlett@oracle.com>
 <CANiq72ntFXb+ZhBqgBAMu2n8wcgJLZRZC1rmBVvL5m+K1Nhw2w@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANiq72ntFXb+ZhBqgBAMu2n8wcgJLZRZC1rmBVvL5m+K1Nhw2w@mail.gmail.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NVQMgbQJyeICoCY3aWaz3SI0KUeikoN8z15mdIXTF5B2BI4BZsaftx4G1XO0?=
 =?us-ascii?Q?5F8pvjcFfINflp3YQJptMMxS5fNGK6tcdKGpKnMKO5uHaII2GkBHchFRvvEg?=
 =?us-ascii?Q?MqYntnYVcN0v0h7eqRdBE7GVXnbuM8ZObL7VV3GIX7a3a+yPX9b3oInlAB/e?=
 =?us-ascii?Q?UIUzP0WCnTWsxqU9sIQ5aY8/u7sqDS/Yw581Mn/FKntf4nyFMxN+SiAF9ezO?=
 =?us-ascii?Q?VL10HFxdBe8E2BGPYWJKGCqXxUQAnZUKvsccWfutpBMknSttI9s/kTgtHVhG?=
 =?us-ascii?Q?d+IbQ3WZl28fPQqs1eE/4n4p/hDHOusJvJatsKTe0XT0BHwq0XRIM74JFSxX?=
 =?us-ascii?Q?j792ZgvNhWy8ZVYmI9PdhKFQscjMhXPVfHbUb0ES07WwsDUZyrTU+xAYwWKp?=
 =?us-ascii?Q?0vAs19hFHxJ/ajBUkOo1mBuODj4WeImkUPb9I0+ZyC79c31VMxfHun2ligyr?=
 =?us-ascii?Q?qCdsp3m+Q1PVZ7ptbQqd1kWOhaTX7YSgGqrEZs05MENCKocdhjJa94/2V9Q9?=
 =?us-ascii?Q?Ah5+R+UQ24tn/biOkFpqgwhwUvOPM7z1j/JTo8YckCLmKSll3XKT6Cw76NLO?=
 =?us-ascii?Q?6uEXZk6JWL3cOrSpDfzU6JvaSRCizmAu62wcWXIZPCUoT5vdf0oLFjf6PTwe?=
 =?us-ascii?Q?ij+18fQrsE6IDfOlcgZ3+FI2OY0MqFTVhKojlUfdcBvH08G6RDkrqISnFMYf?=
 =?us-ascii?Q?yHGFz+Jn7IuCN98d97yrwNNSjVDAhmU8J4VnFf2AHY8ecj6Wj0Sqr+3sG26f?=
 =?us-ascii?Q?8y06lCIsZCE63sB6dsgfFbg0S/llOCVodWN+jTo24J0iqh2jg3s68nrMFCgO?=
 =?us-ascii?Q?n7JuH5M4svpyPXxBxTeHIizziqXmnRXn9BhftNH5qhxudS6oi2D/0MTjEWDz?=
 =?us-ascii?Q?CeMJlvt2Cvmq0M5ogBcV/BW/bZbwMOsTTfQS9eZAc3zoPNY4+ZIvUHrQBgdG?=
 =?us-ascii?Q?9X6n3lyllWKHU8jpw/e4miAzxpMs2HW1oCKIWUGvyGWP+0jNC4JXIVoO3g/j?=
 =?us-ascii?Q?j5l3USSwgYVzNVMiw+lwdNXDuwYi4t4ZYrU+zxKuDYJ29Mg+1sFSB65w+EO5?=
 =?us-ascii?Q?xNWaK5Rb4aZz7TPhEqQmRM/jPIrqmgrfzhuTLbqdX7AMaJqSOKjOt1yt7LLA?=
 =?us-ascii?Q?gBZRqcCeh6o2xcZZ4+59xVwwyaWtdIed8I49UzE3KxeLNPAmKLb0M6BJxBGD?=
 =?us-ascii?Q?FZvObBe7/tzxul4SjFm5zXTssjxeoTOpto652rFFEL66XzarNpPqQbfxJmRt?=
 =?us-ascii?Q?kTGek45TB99WnfneSIcRh/deKqNMMmdTUJqgDxVeRRSthM7NV/0Ripgm5nAj?=
 =?us-ascii?Q?uu0KHsdEQXztlyQXs4GnRH7BzXKPP9mYJX2Ax9ZDEnr8OLrSoyfzhQFyak/2?=
 =?us-ascii?Q?xA1XCPOTafW3QfhuIEij2p45YxVYwVmBfP3PDbNla/zVm3FPXPteAoOYfSXT?=
 =?us-ascii?Q?Uq/PILlQI22M3vQDUe23jCA0Oy8HCa56vR/W94hvjdnaf5J2Le2TOUKtoSlw?=
 =?us-ascii?Q?n3PpQxnXjfDLJRagZ7/XQDQYKmX44SmxMFr/waD3d0CkKPVQM46z/g1WwJ6w?=
 =?us-ascii?Q?lST2mm4hUCE5x1CmPyBEsvr2MJUZfLXceWApcmRJR/3i4/EqE3hpy4fp/aGf?=
 =?us-ascii?Q?Mw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?wqviCM2WDfNkEhPuVGu1oMzAAmXs/ED5weHikn9pNj8hrGFZGEcSev0EiHdf?=
 =?us-ascii?Q?avpmrQld+l/vRm4S80h96f6MDOzgJTeQmoWngDVkOWCRsmy/boPfwONlfiKb?=
 =?us-ascii?Q?wx6Bz9+c0srva7lqeQe7oZ3BEE0YXzwvkqg0uc8XLwjOhjn4Yc6kQdWMo8ug?=
 =?us-ascii?Q?4gd3OFa3htsGr2aEW48QwS9OOql/AzDi1EzveX8uzYu7rnX9wc1UQDQPmQUw?=
 =?us-ascii?Q?S3kujQrQ5+vyDDy9l7Vi9D4TlU7yw46JPF9l4BRNjiAg8ySNW8LmeM0UBA/y?=
 =?us-ascii?Q?LRpoNWOkDBE1BEYZ6ZYiUEBXy4bbea7oEWLw+qNP85JdhgCexTORDvyN5ii+?=
 =?us-ascii?Q?Xt+Q3IU5apvKrUDLV252EKx3tWF4rsTjNpq+KOEfV4qjXRVUNAUkKPJbGQwD?=
 =?us-ascii?Q?AFjccBR6oB2qUfJ9Ej85zfx+MqacLYtGs53nV17/mBfhh5iIRnjbPyubTcAl?=
 =?us-ascii?Q?+s20HIu8g0YidalrBjOVkiISzxuDxmjolc046si1AOVe1wpZMs4gG8wbL5x7?=
 =?us-ascii?Q?4JJjBPzpuwY6l88xR5PuIrC6pnpafAsWP25iPxWFFi39rrZTmmcqB1LqWNOT?=
 =?us-ascii?Q?9vfSUlwHibbKUfJhB2FPYaJpnBvi6/sVB1tm7MTcR5d6p/Wmh4Zefw6OKANZ?=
 =?us-ascii?Q?jYqc/Mj7IimoWTKR9BMGqyAJrKEkku1LxbJMND3rm5XKUQ9beyxNTL3R25qc?=
 =?us-ascii?Q?bXkiMJCuDLMOX+eK2JrlcJvSPinESoomaFaydvvnqgYJYaDAHyvtvZLHiQIt?=
 =?us-ascii?Q?P7AsE42VgLrNfur4umVz8roMS+aLdDlGrpPDg2Sz3WM7TNpIoM8FaSNBRrX1?=
 =?us-ascii?Q?19yPSVPED6+G5/dxCLKfwbSz7GPySW3KNpmpqoqWKI6bDELB5YTdpXqyYKPk?=
 =?us-ascii?Q?NSSZblm+YPNyoaBOk2WlFX0y7WYbF3aXtLxyk2d7Ha0EdYQz58NgSm0w2ZPK?=
 =?us-ascii?Q?GLAoHDy1josCNGoFsSCvwSCeWf/QKo5utJ3dF7E9NZQKz2IdqHqbd5RA4yAz?=
 =?us-ascii?Q?c77Lq21LDuXxb+W2f1QYzPFpzg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 93f6dd32-e099-4c46-f7b9-08db36d94df2
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 19:58:34.9067
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NnjNDFYwRi/zXqip+7rKCDgGseGfgqIhf4VxXSvZG2dUrn+PMILnDVoL1CjB74oRyo6u4br9VKq584hhdDYfcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6601
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-06_12,2023-04-06_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 malwarescore=0
 mlxlogscore=873 adultscore=0 phishscore=0 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2304060177
X-Proofpoint-ORIG-GUID: m_k4kLt6vxUmbJKIEqV5wCI0gLGw4IrI
X-Proofpoint-GUID: m_k4kLt6vxUmbJKIEqV5wCI0gLGw4IrI
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> [221125 13:51]:
> On Fri, Nov 25, 2022 at 4:50 PM Liam Howlett <liam.howlett@oracle.com> wrote:
> >
> > Rename the fallthrough attribute to better align with the kernel
> > version.  Copy the definition from include/linux/compiler_attributes.h
> > including the #else clause.  Adding the #else clause allows the tools
> > compiler.h header to drop the check for a definition entirely and keeps
> > both definitions together.
> 
> Thanks for doing this! Consistency with `tools/` is nice to have indeed.
> 
> I see that `compiler-gcc.h` is included for Clang too in `tools/`, so
> it looks fine to me:
> 
>     Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
> 

Any chance of this being accepted?  I'm looking to use this in the radix
test suite and would rather not duplicate code.

> In the future, it could be nice to enable the warning for Clang too,
> though I see it requires a few cleanups.
> 
> Another idea is to use something similar to `compiler_attributes.h` in
> `tools/` (perhaps just copying it and removing what is not needed?).
> 
> Cheers,
> Miguel