Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <77a62c7c-055d-9624-54ca-28cdeaa3b353@nvidia.com>
Date:   Thu, 6 Apr 2023 13:18:06 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] arm64/mm: don't WARN when alloc/free-ing device private
 pages
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Ard Biesheuvel <ardb@kernel.org>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Feiyang Chen <chenfeiyang@loongson.cn>,
        Alistair Popple <apopple@nvidia.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        linux-arm-kernel@lists.infradead.org,
        LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org,
        stable@vger.kernel.org
References: <20230406040515.383238-1-jhubbard@nvidia.com>
 <20230406130720.ba11ed2de992cc4c2485ad5d@linux-foundation.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20230406130720.ba11ed2de992cc4c2485ad5d@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXVEZytuNTBLWnFlV252VDJrYU9lb25TTVlYWGk1KzBOSGROZnluRFBycm1P?=
 =?utf-8?B?OUJQV0NFT243RzlVdUhhaTRSbmhmbHhERWUxeVNEQkZqc2s5UmJnK0YxdXhP?=
 =?utf-8?B?cEJhczUwYTlYT2wrRU5HUnpveXBMVndRQjJIRnA2K0ZvNVRzbmxwNjR3bUNQ?=
 =?utf-8?B?Wmp1NzJ6UmdGSHVXeE9CMlJYTXJlbXhnd0tNZU9qenlCaHpGK3p2d0xSZDdJ?=
 =?utf-8?B?Yk9NRHdwUkVyK25PSVZGVk8zcHNJOW4wc2F3S1ZrSGVkbGFsaUpwUkIwZ2Ri?=
 =?utf-8?B?THFHTjJqWUp1VGhlUlQ1YVhOeElxSmI0dGN3b2J4djBuY1ZPS0Y1aTQ5SE1q?=
 =?utf-8?B?RUlvd1MvRHpXaTlzdHMwbElnMFhTUGpkSlZXUjZ5TW9wS2RUd0J0VkxJN2Nj?=
 =?utf-8?B?bGtGTzNwTDJESE9aelFMSFUzOEZGR0swQW5NVFVmU3JuMFEydjlZQm52V3JO?=
 =?utf-8?B?R2pYaUdqa2crQVdXa3g2MktmS1QyNlJMZFMrWmpXajNreGJqTHRwMm13TXFD?=
 =?utf-8?B?TWpXK09FTG5vZG1PK3Z0UDAxTmJQQzBiRDhQc1drREZEQ044WmJ5dUxBblB1?=
 =?utf-8?B?NWtTTlJUVmc5R2VzR2lhNTZlNktvak5SR2RiNkFTZzc3UUJpOUt3cjF5N0ZK?=
 =?utf-8?B?QjJqYmtwYWJRRGhpWDZocmhhajFkWkQvb1U4T0ZoV2doTWVhM25sVExHQW0v?=
 =?utf-8?B?dS83clAvbnVIRGRyZitnbTkzc1hQSVJsVEw4WjQ1Wkt1Z0lYeUpoYWlQOWZT?=
 =?utf-8?B?c0R2NXRjSVVhQUlZZGh3UnFUSmR0MmY4YTRaaEZaZHRwdGZheUpDbFFlZUs0?=
 =?utf-8?B?RWpiRjZsWU02d3VaUEJzTDVsTmw0aEt1ZU5udU8yKytJYnV3QllKenJQRmly?=
 =?utf-8?B?dnVMVlNoaTFQOU50OGtmeHBwTzhGanIvamFkV0NRZXhrRDhKalhiWHlwNmRa?=
 =?utf-8?B?NVU5bW9HUi9YME40YkgySCt2Qnh3a2JDck9EYUUzeW1pdUJMakpSYzk2SzFK?=
 =?utf-8?B?eVZET1gyWk41Y1JlK3VlVmVmdnFSK3E2ZU00amQvVE9JNFRaUzBxL3V6NEZz?=
 =?utf-8?B?RTJEaUh0SVc0amlWd2lLNmZTNGIvWmVUdWVKdHdVNkcybkY0bk9ScVlCTmI1?=
 =?utf-8?B?VXdCYkZZUGliQ3Jrai9UaWFkZzd1YjZrdTdidnA5Y0loTmV4SnhBeWU1UVE0?=
 =?utf-8?B?MnRkNjlPeS8vYUV4MERWdjRtRjFtcW9sd25XQWwxWkVuM3VSdU9FaTJjVG5X?=
 =?utf-8?B?aG8ybjFlQ2pLTmNncUtlVFRYSFQzTG9lM0FsTXR4WFBjRlgxcXpzN3NWVURE?=
 =?utf-8?B?YVZhd0pMaERkNFAvMGxJL3plcGRhQkRyZkwwQzkydC9sTTQvWFBod0tYU0d0?=
 =?utf-8?B?Qm13aDZ0clkxUmEzcGNQYXVnVWxMaVNQaGJ3c3d5Ymg4K1RyOWlyWFg4VDI5?=
 =?utf-8?B?OU9Rd3pTbGlGKy9ncDdPRmpKd3F2RFdjdjFEc0pzYUNRR1JyOGRqTnVTMEFy?=
 =?utf-8?B?NUlXdm9zbyt4SXpRTHFoK1dmdi9OWGxDMmRZOFpyelV0QXZOc3VjbWdOWnRV?=
 =?utf-8?B?c2I1emsxTUU1MFM3OEJGOW5YZzVHMlM4ODFxY0RBTm82SEU4QWl6NlZGbnAr?=
 =?utf-8?B?QllUK2xOU29JOVIyVi9ncHhZWTh0d2NRK3BJakoxZDJPTmJhRmEzbFNLdFY4?=
 =?utf-8?B?SVpIekRrZmhzWGM3M0R5ZmNRSE16QVBBNzdmaEVaTEhPam9pbGxkMUdpWnBz?=
 =?utf-8?B?Qjg5dlRsdWxVenlvOG85VGU0NHhBQzlTUExiUDlrazV6ZTQrUVVCdHUrUUNG?=
 =?utf-8?B?NlpEZFBLbWJWeUZKTXpMVnYzbWVLd015ajJYd3FFWmZlaG84blNQckFaTzBz?=
 =?utf-8?B?aFZNVFZWTFJOZHB4bVBEc2d1SERuU1dNeHZDZklGbFQvNWI2KzlteXFyV2Zr?=
 =?utf-8?B?OENzckRBOHU0NlpUdU94L29obHg2Q09EWUttamU4eUJON2JQREdDdHEvYlZu?=
 =?utf-8?B?N1hGL0R0ZjhHZTkrU0lsUmlnZnpYSEhuejFNenFOejVrbXdFejE1VExyNWt6?=
 =?utf-8?B?QmpEVTlNOWxlNGNac3FQbFhKbGhpL1grTlA5emlxNTNBbFBtSjRYN3ZyYWZW?=
 =?utf-8?Q?WFg2jQp12avvQ51pSBfHLV0/K?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 877cb641-0e4a-41be-3eb3-08db36dc09ad
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 20:18:08.7648
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k7SDfzSPrP8KG4fFMKFMPJu3HaOX5hnjf4qfrAbUdtrXZ2FKHOE1f3isLnC7rnHuRjAfknLsSa0LiEAlG3UTzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8090
X-Spam-Status: No, score=-1.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/6/23 13:07, Andrew Morton wrote:
> On Wed, 5 Apr 2023 21:05:15 -0700 John Hubbard <jhubbard@nvidia.com> wrote:
> 
>> Although CONFIG_DEVICE_PRIVATE and hmm_range_fault() and related
>> functionality was first developed on x86, it also works on arm64.
>> However, when trying this out on an arm64 system, it turns out that
>> there is a massive slowdown during the setup and teardown phases.
>>
>> This slowdown is due to lots of calls to WARN_ON()'s that are checking
>> for pages that are out of the physical range for the CPU. However,
>> that's a design feature of device private pages: they are specfically
>> chosen in order to be outside of the range of the CPU's true physical
>> pages.
>>
>> ...
>>
>> --- a/arch/arm64/mm/mmu.c
>> +++ b/arch/arm64/mm/mmu.c
>> @@ -1157,8 +1157,10 @@ int __meminit vmemmap_check_pmd(pmd_t *pmdp, int node,
>>  int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node,
>>  		struct vmem_altmap *altmap)
>>  {
>> +/* Device private pages are outside of the CPU's physical page range. */
>> +#ifndef CONFIG_DEVICE_PRIVATE
>>  	WARN_ON((start < VMEMMAP_START) || (end > VMEMMAP_END));
> 
> For a simple expression like this to cause a "massive slowdown", I
> assume the WARN is triggering.  But changelog doesn't mention massive
> dmesg spewage?

Well, it should. Whoever wrote that needs to improve the changelog. :)

> 
> Given Ard's comments, perhaps a switch to WARN_ON_ONCE() would suit?

That would fix up the user-visible problems, which would be very nice.

Meanwhile, I'm trying to sort out whether this really is a false 
positive for arm64.

thanks,
-- 
John Hubbard
NVIDIA