Date: Mon, 24 Sep 2007 16:41:18 -0700
From: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
To: roel <12o3l@tiscali.nl>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
       axboe@kernel.dk, akpm@linux-foundation.org
Subject: Re: [patch 1/2] Enable link power management for ata drivers
Message-Id: <20070924164118.803cfb22.kristen.c.accardi@intel.com>
In-Reply-To: <46F84460.5090703@tiscali.nl>
References: <20070924215140.966161778@intel.com>
	<20070924151320.67f0c332.kristen.c.accardi@intel.com>
	<46F84460.5090703@tiscali.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 891
Lines: 31

On Tue, 25 Sep 2007 01:12:32 +0200
roel <12o3l@tiscali.nl> wrote:

> >  #define ata_id_cdb_intr(id)	(((id)[0] & 0x60) == 0x20)
> > +#define ata_id_has_hipm(id)	\
> > +	( (((id)[76] != 0x0000) && ((id)[76] != 0xffff)) && \
> > +	  ((id)[76] & (1 << 9)) )
> 		^
> 		|
> are you sure this
> should be 76?

Yes.

> 
> we can also change the first statement a bit:
> 	(!(((id)[76] == 0x0000) || ((id)[76] == 0xffff)) && \
> 
> 
> > +#define ata_id_has_dipm(id)	\
> > +	( (((id)[76] != 0x0000) && ((id)[76] != 0xffff)) && \
> 
> and:
> 	(!(((id)[76] == 0x0000) || ((id)[76] == 0xffff)) && \

I feel this is equivalent functionality and not as readable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/