Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp26844rwl; Thu, 6 Apr 2023 14:09:31 -0700 (PDT) X-Google-Smtp-Source: AKy350YGtoXltWV8r4LJ4R+rt1Zxz7RxC6Sb4RGqrevAdumev0vyMeq425Tbp25NxKCGPaqrMa3S X-Received: by 2002:a17:906:131a:b0:933:32a9:bfb2 with SMTP id w26-20020a170906131a00b0093332a9bfb2mr178114ejb.57.1680815371262; Thu, 06 Apr 2023 14:09:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680815371; cv=none; d=google.com; s=arc-20160816; b=yNq80D4ie4Gvrl/e+Cz3XlYHZL5e/LhTOu0kXsc7py3CYvlj8E/aEcF7p19l/8/CZP xOY/PiK90bCMv84pR1gW3Apw7F4hh//o6064PkjyadStJZmFEYfGpQKY1fHZ2zqJ7laZ jK2yeQ70CXqodpptrGAScfSyWQjyqcWJqnqrKAOn7yhFOGd4mZ4RIDFLuiRsZKLyrFXl u/Pwq8gWTOXdOy4ZFu0LfsFgp1mawP7Fj18/H6ZDOaI6bRxFBWNjATf7tOJanjoWUaoF lBGQvKTobGcSjEncXYBsoEBA1uUq3llLyEoIeXKeMz2CnT50ks6GIRki5MGKEUZLiv19 9XpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=A5oEoKPDSMHPzINvHaTBvI5vjTyZ7eqNp/8rb7uZOWw=; b=OIWrzwJwXofXqtABQWrUdYA/8jubkb72WW7bitGKMl1qPUO0qX+KFaa/Y2cqANmbUQ cS7W9i78mN1p8kWAXU0uzb20hzpnr273BQNifE+hHx37uiSFoFZBdehDXTLs5BLZdSUY HpMjdJKAqVlW6oNhw4VcpiKz91LWmHZbacKOawNpzaCn10e9TNoNPLdH/kDllvNyxlc3 v/OsXGXiwWSa2w1L5HGDU8tmH0Yk+yFhOXTPaAPZ7Kr22qlgN7zYEANWnlXchGrw7TqZ Rwfy4W/NdV58HF44XUpynAts7WUklreaUkGZjkLFg/DCUuMFWiOnUbMOb7sqA6UpE5ja arYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TXPl0+2W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id du19-20020a17090772d300b00933407e3295si2253125ejc.114.2023.04.06.14.09.04; Thu, 06 Apr 2023 14:09:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TXPl0+2W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238783AbjDFVAZ (ORCPT + 99 others); Thu, 6 Apr 2023 17:00:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231665AbjDFVAX (ORCPT ); Thu, 6 Apr 2023 17:00:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5B447AA0; Thu, 6 Apr 2023 14:00:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 552CA64CA1; Thu, 6 Apr 2023 21:00:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id B6B78C4339E; Thu, 6 Apr 2023 21:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680814820; bh=lxPVkhPmUYtm3jDwsxt8qNEdEZ0oXkG23WIBFwHOauI=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=TXPl0+2Wnh3BPGasq4HB513RBatX1VFF60+2t9xCSQdsYoGtj1A37ODU3Nk3lTtl7 fVl2fDjTV357KTvSkODiijIfobNDxXf6l7GgUPtZF+dcH69Q98J2hdM7KR0PKGi5Zy 4xNPlpqX+Pzlk9aRcwUK2MYRezhPKHaKyONQkFW0h9gSbv8Kq9HaM6983coZU5p8qO BQrYbw67t1u9fxoRLOIBA0mdDGJR0+iVodldq5j3TbO3BRb0kPHk24BCvjzvCLh+Tb eqruqakdhFfpwEDQwzilm3zffqOOIbZFg/7O/l1Q0zSeC/63ejZmmqnjkkxhZl6SMs yq/g8HwWYTLlw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 97743E4F153; Thu, 6 Apr 2023 21:00:20 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v1] Bluetooth: btnxpuart: No need to check the received bootloader signature From: patchwork-bot+bluetooth@kernel.org Message-Id: <168081482061.2619.11741204657524521970.git-patchwork-notify@kernel.org> Date: Thu, 06 Apr 2023 21:00:20 +0000 References: <20230403122430.1024235-4-neeraj.sanjaykale@nxp.com> In-Reply-To: <20230403122430.1024235-4-neeraj.sanjaykale@nxp.com> To: Neeraj Sanjay Kale Cc: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, amitkumar.karwar@nxp.com, rohit.fule@nxp.com, sherry.sun@nxp.com X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz : On Mon, 3 Apr 2023 17:54:30 +0530 you wrote: > We can never assume the uart will deliver a complete packet to the BT > layer at once, the expected packet may be divided into several parts by > uart as uart doesn't know the received packet size, the received data > count may mismatch with the expected packet size, so here > is_valid_bootloader_signature() check may always return false. > > Even we remove the count check in is_valid_bootloader_signature(), then > the first part of the data which includes the packet type can pass the > is_valid_bootloader_signature() check, but the remaining parts don't > have the packet type data still cannot pass the check, here return > directly will cause the data loss. > > [...] Here is the summary with links: - [v1] Bluetooth: btnxpuart: No need to check the received bootloader signature https://git.kernel.org/bluetooth/bluetooth-next/c/b1ff41fd0ee6 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html