Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230307120736.75492-1-nmi@metaspace.dk> <CANiq72mvL3f-MZiZiZp-uZDQGCnYJ9yFh_QTWrTMUkUdiXdm=Q@mail.gmail.com>
 <20230307163204.44278987.gary@garyguo.net> <CANiq72k=HU8r-Qr3YH9Bn_9RvoPykBGs0iF57Sdc4Y4uqiyy6Q@mail.gmail.com>
In-Reply-To: <CANiq72k=HU8r-Qr3YH9Bn_9RvoPykBGs0iF57Sdc4Y4uqiyy6Q@mail.gmail.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Fri, 7 Apr 2023 00:33:26 +0200
Message-ID: <CANiq72m=wBvQOYo6-Uwbc7icou7bBCZNJgpK0DiaCwMKmY4OaQ@mail.gmail.com>
Subject: Re: [PATCH] scripts: rust-analyzer: Skip crate module directories
To:     Gary Guo <gary@garyguo.net>,
        Wedson Almeida Filho <wedsonaf@gmail.com>
Cc:     Asahi Lina <lina@asahilina.net>,
        Andreas Hindborg <nmi@metaspace.dk>,
        rust-for-linux@vger.kernel.org,
        Andreas Hindborg <a.hindborg@samsung.com>,
        Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Mar 7, 2023 at 6:14=E2=80=AFPM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> I don't have a strong opinion either way -- this was originally done
> to improve fuzzy searching, see commit 829c2df153d7 ("rust: move `net`
> and `sync` modules to uniquely-named files") upstream:
>
>     This is so that each file in the module has a unique name instead of =
the
>     generic `mod.rs` name. It makes it easier to open files when using fu=
zzy
>     finders like `fzf` once names are unique.

Apparently the "encouraged" way is using `name.rs`:

    https://doc.rust-lang.org/stable/reference/items/modules.html#module-so=
urce-filenames
    https://doc.rust-lang.org/edition-guide/rust-2018/path-changes.html#no-=
more-modrs

Another argument I saw for `name.rs` is that one can easily the name
of the file in editor's tabs/titles, and some of the editors can add
part of the path to disambiguate, which may take more space in the UI.

Cheers,
Miguel