Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a421b96a-ed4b-ae7d-2fe9-ed5f5f8deacf@nvidia.com>
Date:   Thu, 6 Apr 2023 17:13:40 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] arm64/mm: don't WARN when alloc/free-ing device private
 pages
Content-Language: en-US
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Feiyang Chen <chenfeiyang@loongson.cn>,
        Alistair Popple <apopple@nvidia.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        linux-arm-kernel@lists.infradead.org,
        LKML <linux-kernel@vger.kernel.org>, linux-mm@kvack.org,
        stable@vger.kernel.org
References: <20230406040515.383238-1-jhubbard@nvidia.com>
 <CAMj1kXHxyntweiq76CdW=ov2_CkEQUbdPekGNDtFp7rBCJJE2w@mail.gmail.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <CAMj1kXHxyntweiq76CdW=ov2_CkEQUbdPekGNDtFp7rBCJJE2w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3JiSGdaTG1kcDNSckp6dytZdUFRK2ZsT3YwT2kydjFDRDZmamVsR29lV1lj?=
 =?utf-8?B?WWtTWEYwN2JkMmdaZ2FvcXl1TDgwQmJMRmwxYTAwekRYZ3RRTnNwYjFXMVA0?=
 =?utf-8?B?YVhmd28zdTJKenc2bkY4bmI1bTZuUUdJL1N5NVhTMXdEdnM5d2phbk5PODF4?=
 =?utf-8?B?bUdjQ3BqYmVTZ0RIcWI4WmNMWi9jRTlIY1lpUUUwckRmd2dld210UDUwbXJV?=
 =?utf-8?B?clhjZFYyM3p3Y3VpdG52WTJSWUFhNGdibGxoQmxRUk01cG1pYjJEYVZyK1Yv?=
 =?utf-8?B?QVlNRk4ySTZ0akhCT1IxMEdQZUd3bGJZVWxTL2xOcXJlQlVIbDFwVGpIRGp6?=
 =?utf-8?B?RThOK3V2UVJOSUxNQW5NRmJNekM2M3RDamV0ZjRZbjJGeC9pa1lVODIrd29Z?=
 =?utf-8?B?L2dmU21tM1FqYzd0SU5mWi9abnJMRTllOFVYeGFQR01CRzhEQ1UwblRvTTJn?=
 =?utf-8?B?K3k0ZE1CcU44eTFsbkVodkREYnJVeGttall6ZWRHZVlOM2k5eFhsWmlnNWtP?=
 =?utf-8?B?eGIyeG1Ga1JSejBTaTEramxNcE9kUmZEb1U1VlpyRWp6WVVVSzBaNnNmUTNI?=
 =?utf-8?B?dFUwV2tHbG84R1dFc3lXQmlTbWtxNDZYZXd4SzR4WWo2NlRjRzJ0K3ByeEY4?=
 =?utf-8?B?RnNNdW41YkhNTWZBcEk4SytCSTI2VnBtSmU2RCtzaXB2eWtYdytPRERrSXhG?=
 =?utf-8?B?MndndERSN3VMMnFtWmYzT2pHSFRCM3htQUNqNjlvQVFXMDhIVFZCVUlFbUdM?=
 =?utf-8?B?My9mdUZYQldhTjZsd090cU9YRmVwaXl6dmlGNmZMa28zY0xPNmpFWHBVMTZk?=
 =?utf-8?B?MzNMQkhPTFhsN21DbnRiUHlxWWZueUVVKzF2Z0UxNk9ZbXpSaCsyb2JIYTFn?=
 =?utf-8?B?VkRxa0FhNG1CVmJ0WWdMaEdPbldlTlNSWStMZDJLczFwNkN0dnhxQkZyUTA1?=
 =?utf-8?B?RVk4ZWcrNW5xemNUenlCdWhMaWovamVOQ1dvYUhTV1FLSTFua2lJYW52M3pL?=
 =?utf-8?B?dDJhQUlpTXZRVHNuVHprOVpTMEc1WmU5NmJzQUZaeUpudElXZ3dqM0gvemtR?=
 =?utf-8?B?cXdKMFhZMlNaYlJYekx5cXQ4ZGxMdnl2S242eThnOGt2NVdMSUdUSU4xOHR4?=
 =?utf-8?B?eUZ2U1ZsMkJhQ3p6NkJCVVl5S05nazBycEJkM2ZMbDU3UnJLc1NLQStiRlU3?=
 =?utf-8?B?VmthY2dQWklHNjBvYS9acTNXOFV4WkhLeVJXMmpqYWlnUkgyd0s3V1Z6a05p?=
 =?utf-8?B?YUx1Q2ZsNFZHM1dSRmU3RUZhQ0VKRTZlckdEakd3VmdXV2Iwb0tYUTZnWWx5?=
 =?utf-8?B?VFlDM3NrL0Q3SWNoYzNtQmV0RUFlbVdQTEhaZVluMDFBbjRkRmtvYkkxR21X?=
 =?utf-8?B?UTk0ejQ4K2RpNFJVT3dNOVdMUnU0a1NaNkxtdFhieGY3QkkzZ1c4N0NXKzYv?=
 =?utf-8?B?L09STXMxOHRDWXVGUyt6ZEpNN1RmRjMyb282bUsxWERpcmh2T2ZSblg2UHhq?=
 =?utf-8?B?Uk5kRFU2YUJKd3FoZ2UwV3VibmZ6dktaQzM5cTFUQUpxSnEwK1hNYnp0cFNi?=
 =?utf-8?B?b2FZOVo4UzB0WHc1TDBGcGtBaTlXcys4c0ZZaWlTVVlUWFBya1d6TWg5cmtI?=
 =?utf-8?B?RmgvTDQzeWVIUXVyczNEYnI3ZmtGZ2l5YzVRZmJESTNHQ0Y0MlhQdGxkSkJC?=
 =?utf-8?B?TnF6WFZZYnBUTmxQZ01iVVBRWjRxV0dNWU81RGx1NlVyMXBwVnpVSjMrNUZw?=
 =?utf-8?B?YXg5alVPRlRWZWVMRlFnSEdJRnhmYjdnVUR4aFBFaHNnVHVOM2tZalB4S3hJ?=
 =?utf-8?B?M1ZoRitqN2RtS1dWdDF5Mnh2TnJtSWxZMDlpVnNRN2tWVW1SZm91bjZYWUQy?=
 =?utf-8?B?YldPVWhOWDBoQ1EzeUZRNFk5bWlmZjc3bjAvbG9JWVhFQmpySUd1Z3pSeURL?=
 =?utf-8?B?My9xT1l5SU10OXBwcEFKdmJXeXBseFpRUGoxa1cvcGxKcnB0cDdjVk40R2Ix?=
 =?utf-8?B?Y2FyOHVPSi84ejVIYmsvTWJaYlpKa2lrb1NIenh5M2hsNzhCRkVjaEFHSUxC?=
 =?utf-8?B?UmpwYStPWFNzYU42K2k3TU9hL1Q4SDZTOHVlVmgxQk1UanZxbm0yenJldUt1?=
 =?utf-8?B?QWl2c3AzaVJtbVFiWXhrUWJ3L3B0Z09QbHh4Z3BDM0pBTkM2R3U3NTVWYk9n?=
 =?utf-8?B?M1E9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84e98ff9-eb21-4adf-88fb-08db36fcf1f6
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2023 00:13:42.3508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N9nA8PMH5l6dtmNVD0pN9hMNKVwYgWxNg33jUnT5726jeeudJXKo9SmwCI1i05QaCG6qkQ6rn3+9iGfLnCE3hQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6768
X-Spam-Status: No, score=-1.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/6/23 00:31, Ard Biesheuvel wrote:
> Hello John,
> 
> On Thu, 6 Apr 2023 at 06:05, John Hubbard <jhubbard@nvidia.com> wrote:
>>
>> Although CONFIG_DEVICE_PRIVATE and hmm_range_fault() and related
>> functionality was first developed on x86, it also works on arm64.
>> However, when trying this out on an arm64 system, it turns out that
>> there is a massive slowdown during the setup and teardown phases.
>>
>> This slowdown is due to lots of calls to WARN_ON()'s that are checking
>> for pages that are out of the physical range for the CPU. However,
>> that's a design feature of device private pages: they are specfically
>> chosen in order to be outside of the range of the CPU's true physical
>> pages.
>>

Hi Ard,

Thank you for looking at this so soon, I've been working on filling
in some details and studying what you said.

By the way, to address an implicit question from Andrew on the other
thread, the reason that this slows things down is due to a loop in 
__add_pages() that repeatedly calls through to vmemmap_populate(),
like this:

device driver setup: allocate struct pages for the device (GPU)
    memremap_pages(pagemap.type = MEMORY_DEVICE_PRIVATE)
        pagemap_range()
        __add_pages() /* device private case does this */
            for (; pfn < end_pfn; pfn += cur_nr_pages) {
		/* this loops 125 times on an x86 test machine: */
                sparse_add_section()
                    section_activate()
                        populate_section_memmap()
                            __populate_section_memmap()
                                vmemmap_populate()

> 
> Currently, the vmemmap region is dimensioned to only cover the PFN
> range that backs the linear map. So the WARN() seems appropriate here:
> you are mapping struct page[] ranges outside of the allocated window,
> and afaict, you might actually wrap around and corrupt the linear map
> at the start of the kernel VA space like this.
> 

Well...it's only doing a partial hotplug of these pages, just enough to get
ZONE_DEVICE to work. As I understand it so far, only the struct pages
themselves are ever accessed, not any mappings.

More below:

...
>>                 /* arch/x86/mm/init_64.c */
>>                 vmemmap_free()
>>                 {
>>                   VM_BUG_ON(!PAGE_ALIGNED(start));
>>                   VM_BUG_ON(!PAGE_ALIGNED(end));
>>                   ...
>>                 }
>>
>> So, the warning is a false positive for this case. Therefore, skip the
>> warning if CONFIG_DEVICE_PRIVATE is set.
>>
> 
> I don't think this is a false positive. We'll need to adjust
> VMEMMAP_SIZE to account for this.
> 

Looking at the (new to me) arm64 code for this, VMEMMAP_SIZE is only
ever used to calculate VMEMMAP_END, which in turn is used for the
WARN_ON()'s in question, plus as the "ceiling" arg to free_empty_tables().

It seems Mostly Harmless. How would you feel about changing it to a
WARN_ON_ONCE() as Andrew suggested? That would completely fix the
user-visible symptoms:

diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
index 6f9d8898a025..82d4205af9f2 100644
--- a/arch/arm64/mm/mmu.c
+++ b/arch/arm64/mm/mmu.c
@@ -1157,7 +1157,7 @@ int __meminit vmemmap_check_pmd(pmd_t *pmdp, int node,
 int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node,
 		struct vmem_altmap *altmap)
 {
-	WARN_ON((start < VMEMMAP_START) || (end > VMEMMAP_END));
+	WARN_ON_ONCE((start < VMEMMAP_START) || (end > VMEMMAP_END));
 
 	if (!IS_ENABLED(CONFIG_ARM64_4K_PAGES))
 		return vmemmap_populate_basepages(start, end, node, altmap);
@@ -1169,7 +1169,7 @@ int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node,
 void vmemmap_free(unsigned long start, unsigned long end,
 		struct vmem_altmap *altmap)
 {
-	WARN_ON((start < VMEMMAP_START) || (end > VMEMMAP_END));
+	WARN_ON_ONCE((start < VMEMMAP_START) || (end > VMEMMAP_END));
 
 	unmap_hotplug_range(start, end, true, altmap);
 	free_empty_tables(start, end, VMEMMAP_START, VMEMMAP_END);


thanks,
-- 
John Hubbard
NVIDIA