Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp221285rwl; Thu, 6 Apr 2023 17:57:34 -0700 (PDT) X-Google-Smtp-Source: AKy350aLMrMoMCkdFD106tPaWWJzpe3gbZmT7WC3HOriGAR7XUTtzef19TG0u4Y8fLbULEdv0Tc7 X-Received: by 2002:a62:1d85:0:b0:625:e8ec:4f5b with SMTP id d127-20020a621d85000000b00625e8ec4f5bmr736063pfd.6.1680829053968; Thu, 06 Apr 2023 17:57:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680829053; cv=none; d=google.com; s=arc-20160816; b=Hg+Qnw7ddXfmFkKM7z9Lzqqu6AJOfnsRtaSMq8NYdrI78GcDJn8kQwueSw6cfWRNe2 f+B0lo8wTZQmE0YMAXdvGNSwC23uG8zwz1JWCaoQKU+LsqOklNeK/xiKFGiN6DohjwYN xKlusZoX2vt1JXf7EcPDkO12fiSGhTfvrIuiK/2WzJhseI/89ruBSkZ+oiz1JZT8+7Ql Qq2c3w5AOi7eBJjf+oQJ9CYyU5zFuv/hIYsXWeR5vKpbtvRpIhSZuHU/3sV1OFcdPxvy DpeRa24LJgMatOd6xp5NLI9ceGJpYzZLQvcO0qDwcU3PPHxtC3Rxe7398ZKUPZrEOgaq 8+Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=h1VZzDi4GY18ewCATzaBVBi3jFt9uNVAIW9Am330oLQ=; b=NXa0FfrMvo/5gVhPh25e2bRGcOGPQHeo6K4eI3vxmHo67M1MFwR+48UkKJedfgIlY1 bi5Rg91+uyhWHLxSRRNGVg+R8Q7KNvCO1VOmld395P8MTcTg1+3x8Vjh2sueVCURKfpO c6ModjappIxA6oVRk26UjuEVaFhx/KtxvBKNY7FrhRZsd5DZj8eBnklzcn5F8D66REMq c6SEOhSjGihYhgXIZZ8lhlwD1nPnDKIdvGMUMkKtlmNjLmNO95y1x5rhPZ+SfN6VQqnD TxNXbc1gT5Svc/iXE2pSEMRTi9O/Acbe2yyGKPFLJtIYSp2R8otH6gwJK1xE0SfKWOYS rXzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gb3r4KSO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y22-20020aa79436000000b0062dbc05a323si2495149pfo.298.2023.04.06.17.57.07; Thu, 06 Apr 2023 17:57:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gb3r4KSO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238433AbjDGAyj (ORCPT + 99 others); Thu, 6 Apr 2023 20:54:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231466AbjDGAyi (ORCPT ); Thu, 6 Apr 2023 20:54:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C39AC93EA; Thu, 6 Apr 2023 17:54:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 625CF64DD2; Fri, 7 Apr 2023 00:54:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48C35C433D2; Fri, 7 Apr 2023 00:54:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680828876; bh=uvT44qx5YO7bon6aMmqTeZtryVy3J03QEXu1FpcUChw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gb3r4KSO9gRu1kunqKSKRVILUWmx2/w1729zO1bnmOFwGTjK8Ft7VgeVIqQTRYktv IWoDAI4k/MGasNqIg8yOC4EaHRFW3OexmHky+FTATmWwQPv0fuyPhD9KqpUrJdUZvy 04jSqe8Mz+djYDYAxW63CiCRaFAhGWCyS7LpVaX5D/mfbaRIUmoNGKxiZhnx++WVAf 0Hlc/LhrSf7+y2+OvyhZRwCWgXuEjgUquY5PkBpHS6jI2oxJ0oTdmh9/bpv7XFAxsC dkHpoI3IwMJoz2Lwc/5kivXju8kVrsuuL0xWPpJK8r4SLNxcjeTU1NMtBFmuDOtKIE XV9HKRzNQ6t1Q== Date: Thu, 6 Apr 2023 17:54:34 -0700 From: Jakub Kicinski To: David Howells Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jeroen de Borst , Catherine Sullivan , Shailend Chand , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH net-next v5 03/19] mm: Make the page_frag_cache allocator use multipage folios Message-ID: <20230406175434.0d74bbcc@kernel.org> In-Reply-To: <20230406094245.3633290-4-dhowells@redhat.com> References: <20230406094245.3633290-1-dhowells@redhat.com> <20230406094245.3633290-4-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Apr 2023 10:42:29 +0100 David Howells wrote: > Change the page_frag_cache allocator to use multipage folios rather than > groups of pages. This reduces page_frag_free to just a folio_put() or > put_page(). drivers/nvme/host/tcp.c:1315:15: warning: unused variable 'page' [-Wunused-variable] struct page *page; ^ drivers/net/ethernet/mediatek/mtk_wed_wo.c:306:15: warning: unused variable 'page' [-Wunused-variable] struct page *page; ^