Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Apr 2023 09:28:50 +0800
From:   Pengfei Xu <pengfei.xu@intel.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
CC:     <christophe.leroy@csgroup.eu>, <linux-kernel@vger.kernel.org>,
        <heng.su@intel.com>, <linux-kselftest@vger.kernel.org>,
        <lkp@intel.com>, <linux-gpio@vger.kernel.org>,
        <john.fastabend@gmail.com>, <edumazet@google.com>,
        <yi1.lai@intel.com>
Subject: Re: [gpio kself-test & bisect] gpio-mockup.sh kslef-test failed in
 v6.3-rc5
Message-ID: <ZC9x0lQuE9Ds9Ory@xpf.sh.intel.com>
References: <ZC6OHBjdwBdT4sSb@xpf.sh.intel.com>
 <CAHp75VebjkJZkC=0ubGSVYm75M6sFAHt3kq=WqqfDmtBJrvVDQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHp75VebjkJZkC=0ubGSVYm75M6sFAHt3kq=WqqfDmtBJrvVDQ@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXNnU0l3cHk5ZjBQeG9uUElMK1o3V3BNRVBtUDBHbytrRmJmTWxFOVlYV3FN?=
 =?utf-8?B?RUpWOGRWVWc1b2hXVjZhNlhrSE1COWVHcGtSY1pkMVBGVndwYU1EYnc0cjc5?=
 =?utf-8?B?WUI1TldPZGhBREtaSGNiM3ZTREFSNXpYM2x2Vi9HRVlJYnUxR0IwY2hlTXl1?=
 =?utf-8?B?VGdVcmo5QkpqUC9IQkRzdTR0T1N2Uy9aVG1WeUNCQzM3ZXJHZThGODFqaWV0?=
 =?utf-8?B?Yk1Id01yMnROZnIwbTRONWF2ODVqNnU2RjhyL2lBdml2dWg2MGhDakppRnZQ?=
 =?utf-8?B?ZG1oM1YxbXRCTDZpSUZrNzR4c3lMcm9MOTFsajZNdFd5eXZQaVJKUDFWK2tW?=
 =?utf-8?B?ZGEvdjJHR3pNWjZyaG1JSXUyQ1llMkNybkpWL0pkUDlGdkFFd0liWlgwd1NH?=
 =?utf-8?B?RHNJV0hBTk41VUNraHUrdkdzMVBVSUhIY3Z4SkllMjhPRFBqZTVUTmxqeG53?=
 =?utf-8?B?enJSS3FycXc3MzJRbHphRTN3QllqVVgvTWlJbXJNREtWRXJ0cG82aXdTTXlj?=
 =?utf-8?B?NHRIZlI4Zi9MVDNWYm1KNG8wRkpNSU1sNUplKzkrbzN3bWQrRU0rYWNPbkt6?=
 =?utf-8?B?Y2VqRUF4cEpaeWNBYm12UWR2QVVIZXZsZ2xZMzlBTXFPTDdKcEJMQStCNzVq?=
 =?utf-8?B?MzhSNGVKY1YwdUJUTTB4RUJBcVhyUUcrY1hzc2lwWHpVb09QOC9tWjJ2N0Zl?=
 =?utf-8?B?V0Y2NUpjbWI3czA0ZmdmNk9vUEladlQwL0ErQWt6NWk0T0lUeHRyNXVwUUVa?=
 =?utf-8?B?bmVvZExyeGhSWEJ3SDlNZm1Wdi9qbG5OMURrSmhHaTk3YU8vbnFmeHMzdzhN?=
 =?utf-8?B?dHVETXpvVkYxVW1iamd1VTloVzFhaUdKdVNyanBxNm9yTzBUWDNva0t6MlNt?=
 =?utf-8?B?TEdUYlpEOWVGTEFnTTRPRjM0ektTamduTzBVZ2VqZVZ2ZGtzTFkxWUNaSWkw?=
 =?utf-8?B?SUlsc3FmT2lMblBSY1ZqaXhqaDN6NjRtT3VxTVVFdkpCVUR3cGlaQWJQMGdX?=
 =?utf-8?B?bmp0UmpUVlAxM0hnUGRFUGo0K2t4dnNONm0rTG5ZdXBHYnR2Z1ZLbjk1YllO?=
 =?utf-8?B?cnVOWDhCRTlnZXdUNWdyR1BlaFlTR0cvVXZvUUJjcWUrL2dyYW13QnI1VXNJ?=
 =?utf-8?B?MEFRTm5kYTBTb21DM1VCTHZVRkxvcUd6czIvSGFHSTBSSUNQSHBmcEhDRTEv?=
 =?utf-8?B?Z1RnNjNYMVJOWUR2eXJlSm5pOE5GSmNnK25QTjFWdmpwMTVwSzZNOEFsM3FY?=
 =?utf-8?B?elZQbFZKK3RJaU9JVXcwSFB0dGJteUdKcWFpa25QOHR5bVRKZ3daSVludmdO?=
 =?utf-8?B?RjYzeEdCMDhCc0tBTk1TaFRFTi9hKzNpeUhRWEM4N29xaDVWbDZjYmcxZjBO?=
 =?utf-8?B?ZWtObWtseW84ZllhY0VuRXNJVFFhUlZ2MjlVQzY1dzZxN3ljdncxb0NrOEli?=
 =?utf-8?B?RCtEcHlkNGVSZzhZbjdvRTljS253Z3hENXIvMENndDBzVjNnUU9xanUyOGg1?=
 =?utf-8?B?TUk3V2wzU1IxYU1DVEJPMGRhYWx0K0tXZ1MvV0JUbXlZMzI2azZ5VWQvVFZ5?=
 =?utf-8?B?SEJzVG1VWEliNzFjS3hOYkZGN3h6QVN6S01rdkJJSTI4eUttZk1lUWU2U2hG?=
 =?utf-8?B?eUY0MFcyWmJPcHBrUnF1dHdTb0o4RmhPQjVBeGRsdWZmQThRd2hIcjhKSkE1?=
 =?utf-8?B?NVNFdHJxQm96OUF5eUpCK2hYSXp6bzRSSlI5SzZINURCUURkVFFtNFJaYkxh?=
 =?utf-8?B?bHRaOVhqeU5iZWdHRmZ4dVdqdWkwdGJTMEcxWEZPdktnUFpmMk5hWGtocyty?=
 =?utf-8?B?WmRtV0o0L3llZ3JVSjBmOXQ5UGhoUDVYYkhJRnBZVjNmVHE1U3l4QzNiUlZG?=
 =?utf-8?B?b0tHTnRTMy9kSEdPN2w1OUtPa1Bwc3Z1c2Zqa2tHMU1qSzQ1WlpKeGJmeHpi?=
 =?utf-8?B?aFJjY091R0tTVGhQakZqbWRhRyszamVlN1o2VlI3YVZwWTM5SXBPV2lKRjd2?=
 =?utf-8?B?VS9QOFNoelJsSzR0cTJnRVR3RnAxaVc1TVBvNWZIMllGYXFKT3gzaW1GWmJv?=
 =?utf-8?B?Z1ViODhhRkxlem51YlBPaE9ickpFRGFKNkZmNEVKa1JUM2ZSSG9jUmgyTFJY?=
 =?utf-8?Q?W2C8g1IiCkX0j7YDHq8DNZFd/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 45bd04cb-87d8-480a-f36a-08db37073801
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4839.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2023 01:27:15.0534
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9WbowanmpRhvOoi8dWP111P7cOtwh2GboS5KtQwa8CAdH3UiRn9ImdjKpI7N3T9KpHIcoUpzTLbLG6YBsEHnaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7048
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy,

On 2023-04-06 at 13:26:36 +0300, Andy Shevchenko wrote:
> On Thu, Apr 6, 2023 at 12:15 PM Pengfei Xu <pengfei.xu@intel.com> wrote:
> >
> > Hi Christophe Leroy and gpio experts,
> >
> > Greeting!
> >
> > Platform: Tigerlake-H and so on x86 platforms
> >
> > All detailed info is in link: https://github.com/xupengfe/syzkaller_logs/tree/main/issue_bisect/230406_gpio-mockup_kselftest_failed_bisect_v63rc5
> > Bisect info: https://github.com/xupengfe/syzkaller_logs/blob/main/issue_bisect/230406_gpio-mockup_kselftest_failed_bisect_v63rc5/bisect_info.txt
> >
> > gpio-mockup.sh kslef-test failed in v6.3-rc5 kernel.
> > gpio-mockup.sh(gpio overflow test) in kself-test could reproduce this issue:
> > cd linux/tools/testing/selftests
> >  1.  ./kselftest_install.sh
> >  2.  cd  linux/tools/testing/selftests/kselftest_install/gpio
> >  # ./gpio-mockup.sh
> >  1.  Module load tests
> >  1.1.  dynamic allocation of gpio
> >  2.  Module load error tests
> >  2.1 gpio overflow
> >  test failed: unexpected chip - gpiochip1
> >  GPIO gpio-mockup test FAIL
> >
> > And the simplified steps to reproduce this issue are as follow:
> > "
> > # Load gpio_mockup with overflow ranges -1,1024:
> > modprobe -q gpio_mockup gpio_mockup_ranges="-1,1024"
> >
> > # Check is there some Call Trace generated in dmesg
> > dmesg | grep -C 5 Call
> >
> > # Should not generate any gpiochip folder like /sys/kernel/debug/gpio-mockup/gpiochip1
> > # Because load gpio_mockup with overflow ranges -1,1024
> > find "/sys/kernel/debug/gpio-mockup/" -name gpiochip* -type d | sort
> >
> > # Unload the gpio_mockup module
> > modprobe -r gpio_mockup
> > # Check is there "Call Trace" generated in dmesg
> > dmesg | grep -C 5 Call
> > "
> >
> > Actually the judgement "gpio-mockup.sh" test/bisect judgement point is that:
> > Should not generate any gpiochip folder like
> > /sys/kernel/debug/gpio-mockup/gpiochip1 after load gpio_mockup with overflow
> > ranges -1,1024.
> >
> > I met gpio-mockup.sh test failed but there is no any "Call Trace" dmesg info
> > sometimes.
> >
> > So the shortest check steps are as follow:
> > "
> > 1. modprobe -q gpio_mockup gpio_mockup_ranges="-1,1024"
> > After above gpio_mockup module loaded with overflow range "-1,1024":
> > Correct behavior as previous v6.1 or older kernel:"gpio should not load "gpiochip1" due to overflow range -1,1024";
> > Wrong behavior in v6.3-rc5 kernel: "gpio *load* "gpiochip1" with overflow range -1,1024 and "gpiochip1" should not be loaded".
> > The underlying problem was already buried here.
> >
> > 2. Could use below command to check if "gpiochip1" generated:
> > As before v6.1,  there was no "/sys/kernel/debug/gpio-mockup/gpiochip1" sysfs folder due to overflow range -1,1024";
> > Wrong behavior in v6.3-rc5 kernel: "/sys/kernel/debug/gpio-mockup/gpiochip1" sysfs folder generated as follow command check:
> > # find "/sys/kernel/debug/gpio-mockup/" -name gpiochip* -type d | sort
> > /sys/kernel/debug/gpio-mockup/gpiochip1
> > If there is gpiochip* generated, gpio-mockup.sh kself-test would be failed also.
> > "
> >
> > Bisected and found the bad commit was:
> > "
> > 7b61212f2a07a5afd213c8876e52b5c9946441e2
> > gpiolib: Get rid of ARCH_NR_GPIOS
> > "
> > And after reverted the above commit on top of v6.3-rc5 kernel, above
> > gpio-mockup.sh kself-test could pass and this issue was gone.
> >
> > Now gpio-mockup.sh kself-test is failed on almost all x86 platform from
> > v6.2 cycle mainline kernel.
> >
> > I hope above info is helpful to solve the "gpio-mockup.sh kself-test failed"
> > problem.
> 
> Thank you for the report and full analysis of the root cause. I think
> we may fix the test script however the gpio-mockup is obsoleted and
> should be actually replaced with tests again gpio-sim.
> 
  Thanks for your info! So we should ignore the gpio-mockup module related
  test next time and the gpio-mockup kself-test is not necessary.
  My colleague "Lai Yi" also found this issue.
https://lore.kernel.org/lkml/ZCvusEIauvO8BLM5@xpf.sh.intel.com/

  If there is a patch update please add:
  "Reported-by: Pengfei Xu <pengfei.xu@intel.com>
   Reported-by: Yi Lai <yi1.lai@intel.com>
  "

  Thanks!
  BR.
  -Pengfei
> -- 
> With Best Regards,
> Andy Shevchenko