Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp272029rwl; Thu, 6 Apr 2023 19:01:29 -0700 (PDT) X-Google-Smtp-Source: AKy350bEGqCj0zYPaqjVQ8WIO/gyMC5Wfmj1rMJpaIxhrP5UdKYfStt5Z8DUAz2ufUU837mx7s4Z X-Received: by 2002:a17:907:783:b0:930:3916:df17 with SMTP id xd3-20020a170907078300b009303916df17mr970052ejb.0.1680832889204; Thu, 06 Apr 2023 19:01:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680832889; cv=none; d=google.com; s=arc-20160816; b=yx1THGKyxHGpg7Ehj1FKpbb/xGzOMsNb/Fig/QVdWMMmbfjRW8It9pvfyhp/nIfeFk 6ehgFTHRx8V5E6d9K4tDxbU02DvFFyBkLiW/S1dwVvu4XpumlH8jNYYZInQurTKcBQOY a1tH8QuV0SNsR8CjPe4y/zXahgorMZuVIty8pDHmq1xmndZJnK8PM5IUVy88QogkraSF E7TjVo3TBa2BZHmeYzo7dpVef9EDmdwe9hZj2yNVg0LG/C/fJav0XXc3paypovTdVlnK i10IBBy36WQl5GZV7HtGJHoHFoGWFkDLhsrghfBh3Jqda2WTDMkhrza/Nl+l930JhKxL ytTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Q3vw64oqm1iC7XZe6fvt/2DjgzS0JPaTk8Kdt9Vz5DI=; b=MaQ2ikZi0lRRlrjhzEa8GUtrj75RLbJpT2FHnqZbmrBd/+B4RMWRs6OFGrsQxhN1xh +df6DoYqFDmaanlzN+EZ1ROixz/kWICEXoAjQqB4tSY25hEAowGKbEF9zOFKlFIU+Tx9 WOa76UzYpsfNbksk2aoELKsLTjsB9gddQpfDhZ1l7Hv3Xe46XxlUx3UsOOQobYoTF1SH VZC+nIl2HCBfvJpj9DOoe/AX7axEUDsSOEzmgBTho9MiTlV85wEUGq6yW3MuAOm8iLDf 4EezWPv/NkDqAF42tD7dRbSmyiXebvWUuEfMm5qKdztLI9luoFYzNVLb4l6U6yo6MVyU vxJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=glcRKpI4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rh24-20020a17090720f800b00932a14e4d4fsi1943442ejb.146.2023.04.06.19.01.01; Thu, 06 Apr 2023 19:01:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=glcRKpI4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239571AbjDGB7b (ORCPT + 99 others); Thu, 6 Apr 2023 21:59:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239547AbjDGB73 (ORCPT ); Thu, 6 Apr 2023 21:59:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37CA47EC6; Thu, 6 Apr 2023 18:59:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AFE9160ED7; Fri, 7 Apr 2023 01:59:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0AFDC433D2; Fri, 7 Apr 2023 01:59:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680832768; bh=OjAgpL4hr+PIA/oOHr5fg/6H51UIxKwatbJ6by0dwZg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=glcRKpI4T2vbTyII6CoMZXibBDjoYsB6lnEeqhK/DtYANk1bbFkqi0hd0PS25iddu B1moeTddxKaZ8TzHNwujfSa5CBLdjhNCj2ldv6AtC2gmVVfv2Ykz3y1mJwzchBZK9F FeNaxgplAAJwI5Cy4rJjtIU/RJbic+sDdImXCJSpC2M5CvILO09leNTf+YQXIct496 Y8DfUziy5zXwqhdr8/0fqYZGnTkDsZ7QjHZ6wVrq4r7YjTmcH+Lk87IzZ0aO7/I/Ky IRzW0RLtTu+ie1PbuNUHv2PqDWA76Tn6rbBcmmRAtzmns9lUSdvJIB94iLtRorlEH8 BdKqMcthPVmDQ== Date: Thu, 6 Apr 2023 18:59:26 -0700 From: Jakub Kicinski To: YueHaibing Cc: , , , , , , , , Subject: Re: [PATCH net] tcp: restrict net.ipv4.tcp_app_win Message-ID: <20230406185926.7da74db2@kernel.org> In-Reply-To: <20230406063450.19572-1-yuehaibing@huawei.com> References: <20230406063450.19572-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Apr 2023 14:34:50 +0800 YueHaibing wrote: > UBSAN: shift-out-of-bounds in net/ipv4/tcp_input.c:555:23 > shift exponent 255 is too large for 32-bit type 'int' > CPU: 1 PID: 7907 Comm: ssh Not tainted 6.3.0-rc4-00161-g62bad54b26db-dirty #206 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014 > Call Trace: > > dump_stack_lvl+0x136/0x150 > __ubsan_handle_shift_out_of_bounds+0x21f/0x5a0 > tcp_init_transfer.cold+0x3a/0xb9 > tcp_finish_connect+0x1d0/0x620 > tcp_rcv_state_process+0xd78/0x4d60 > tcp_v4_do_rcv+0x33d/0x9d0 > __release_sock+0x133/0x3b0 > release_sock+0x58/0x1b0 > > 'maxwin' is int, shifting int for 32 or more bits is undefined behaviour. > > Signed-off-by: YueHaibing Fixes tag?