Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp283995rwl; Thu, 6 Apr 2023 19:15:50 -0700 (PDT) X-Google-Smtp-Source: AKy350apsxk1bJF5H3Ix/vANqW05LmnWEjoRRgn1d/krPOSehZKQqoH6Nar3OmOweBiwkGWQ9JS6 X-Received: by 2002:a17:907:6e0b:b0:947:d3f0:8328 with SMTP id sd11-20020a1709076e0b00b00947d3f08328mr9393695ejc.1.1680833749916; Thu, 06 Apr 2023 19:15:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680833749; cv=none; d=google.com; s=arc-20160816; b=hj23jDHWzT6lRIOx4h3K14OPTltCekMO4r4LpJlmne+L4/tB4bNonM4ER7JD3Qz5W4 SstXDKEEJ5bzitQvx7++ukdLQqljRzXM/kAyT5UKAU9U/vq2thSKA7TlKWPAon5uZ1vf fexxr5MhHYEAc7+niO24tDOcLkViCCRe8b+hhI3hkfLuqCFBZBC8jUlQZ7s0qmFkUWGf iu+4LpmV6llpcS6d1zInpIpW1SQWDZOCRF/6vQIGmIpz9jZXTKJrrCIU0+iD2sq8+z9u dA7rjqa12rW3VJqUiXm8n/JgY9QB+oRAbmS5v1Wlk9BLDTjz5k2XhZWesdk5IKi9BkE0 OXUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=uUmoyh7ZF0GQu690WOsmdolMJm1vweULS9iiJ2wX9UY=; b=Yok5T6MJyjK7XPSHclACWWVtfCSSdW2OJaGJ0SXuJbjQ8hskbw8n8DNPVKFreLeoC7 gMbb5YADgIQziH5ggoxiK75zMwTduMMSqvCOJQMad6QOm177Q5sEDx79GxB9C1jjzB9r x2BsqAFYZ9x+wBoedtxRm9r0QPodtqKY5BmXPzmrSEZBBy72dyP/Yz7npbU5yPfq6VXX STB2zsv+HOlFe5I0gWg55DV2BuZt2Hrm88pFBzgL7GFLBAgBuike0byyI0ngxT6kMW+3 iRWpLOfzdm/EVeNpCp75UH97h0vVYcJf1aZ7eeGv6xfEx8D3HGI4CQ6BQPpqeUmgS1jG 39qA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id se25-20020a170906ce5900b0093549a153f9si2184098ejb.912.2023.04.06.19.15.14; Thu, 06 Apr 2023 19:15:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240236AbjDGCOJ (ORCPT + 99 others); Thu, 6 Apr 2023 22:14:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240009AbjDGCOF (ORCPT ); Thu, 6 Apr 2023 22:14:05 -0400 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ABFB171C; Thu, 6 Apr 2023 19:14:03 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VfUsEV0_1680833625; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VfUsEV0_1680833625) by smtp.aliyun-inc.com; Fri, 07 Apr 2023 10:14:00 +0800 From: Jiapeng Chong To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH v2] Input: cma3000_d0x - Remove duplicate code Date: Fri, 7 Apr 2023 10:13:43 +0800 Message-Id: <20230407021343.63512-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.0 required=5.0 tests=ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Function input_set_abs_params() has already set EV_ABS bit for us. drivers/input/misc/cma3000_d0x.c:328 cma3000_init() warn: inconsistent indenting. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4588 Signed-off-by: Jiapeng Chong --- Changes in v2: -Remove __set_bit(EV_ABS, input_dev->evbit); drivers/input/misc/cma3000_d0x.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c index e6feb73bb52b..1772846708d2 100644 --- a/drivers/input/misc/cma3000_d0x.c +++ b/drivers/input/misc/cma3000_d0x.c @@ -325,8 +325,6 @@ struct cma3000_accl_data *cma3000_init(struct device *dev, int irq, input_dev->open = cma3000_open; input_dev->close = cma3000_close; - __set_bit(EV_ABS, input_dev->evbit); - input_set_abs_params(input_dev, ABS_X, -data->g_range, data->g_range, pdata->fuzz_x, 0); input_set_abs_params(input_dev, ABS_Y, -- 2.20.1.7.g153144c