Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e73ed389-b595-67b2-6711-039dba77c26a@starfivetech.com>
Date:   Fri, 7 Apr 2023 14:33:22 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH v3 8/9] media: cadence: Add support for JH7110 SoC
Content-Language: en-US
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        "Todor Tomov" <todor.too@gmail.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        "Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Eugen Hristev <eugen.hristev@collabora.com>,
        <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <changhuang.liang@starfivetech.com>
References: <20230331121826.96973-1-jack.zhu@starfivetech.com>
 <20230331121826.96973-9-jack.zhu@starfivetech.com>
 <20230404050703.GO16648@pendragon.ideasonboard.com>
From:   Jack Zhu <jack.zhu@starfivetech.com>
In-Reply-To: <20230404050703.GO16648@pendragon.ideasonboard.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/4/4 13:07, Laurent Pinchart wrote:
> Hi Jack,
> 
> Thank you for the patch.
> 
> On Fri, Mar 31, 2023 at 08:18:25PM +0800, Jack Zhu wrote:
>> Add support for Starfive JH7110 SoC which
>> has the cadence csi2 receiver.
> 
> This fits on one line:
> 
> Add support for Starfive JH7110 SoC which has the cadence csi2 receiver.
> 

OK, I will modify it in my next commit msg.

>> Signed-off-by: Jack Zhu <jack.zhu@starfivetech.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
>> ---
>>  drivers/media/platform/cadence/cdns-csi2rx.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c
>> index add982edce64..5e36b994b8d5 100644
>> --- a/drivers/media/platform/cadence/cdns-csi2rx.c
>> +++ b/drivers/media/platform/cadence/cdns-csi2rx.c
>> @@ -560,6 +560,7 @@ static int csi2rx_remove(struct platform_device *pdev)
>>  }
>>  
>>  static const struct of_device_id csi2rx_of_table[] = {
>> +	{ .compatible = "starfive,jh7110-csi2rx" },
>>  	{ .compatible = "cdns,csi2rx" },
>>  	{ },
>>  };
>