Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp506606rwl; Fri, 7 Apr 2023 00:26:27 -0700 (PDT) X-Google-Smtp-Source: AKy350Zut1VmJaASIt9CRy+oofCVXadGpb1kQXxta51COITGVOmWv/CA3pVv5pOvWrRHbRiTcYK8 X-Received: by 2002:aa7:da0b:0:b0:502:2148:298c with SMTP id r11-20020aa7da0b000000b005022148298cmr1084720eds.19.1680852387719; Fri, 07 Apr 2023 00:26:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680852387; cv=none; d=google.com; s=arc-20160816; b=wSac+3vI7kgy1lo+Yku3FV7CVm3IN55TZCBjd2HOHD8KVy1DEkHoWZnUZGCSOl/ZRq auvHVxlNtvQk1FTNAQPnoIA415bK73jZrJoUTbEMarQ/dIOewZAqk1JRKpEQJPDfF/SH BS1zD/+ikL2luWBSAt/NM5VxnGtEpMGIzOs/4HnzZHrl4xwHo6xDDKfk+me3Ml9QM3pI vS/OrblWxM0NRwz/lGeN75jlLP6GP8ktp2cvDt0SkNvJl+Bg4p4fM7hx/sAdDfheH5dw Pt6qDyEqzABvLEaZhng6nPYyvMOhv+s8+TfJgdvrVz9e+U16N5MgG4itkZatbT9YxYS6 YvXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=Ranq7iEURv0DPsZ6lPvymbN33gRmqHf9YeUTm8k+2Fc=; b=CPiP/t4UyBS+ymHNJlsFh2pkxdf+5eeUznxDrqT733stEIoVM8L/s87zqGWFoKk/0B eFetD+K+EPImTV2WgJepsBL2LtYPKA8VmmOSYvk9daZRc8KqaLKk0X665xZtvd5lAUuk o+kYDr4uoeKfwMFtpNRUCWq9Rbwon6DLqpJg82BmevuPVpGZLQ67pUKo24pn+3mg7QYW F1ZtmrJ5z7/Xd8emF7cD+E7nNgj35z5gwJ/fdMDuyEthIjitYyJneNWl5GQWvPljjo1O AeCIXe/uqWQn2Pb4Jc0Q6koK+YPeiQqNAjcopB1F8myUbDmmzk6pmCe8Ha69IQu89TBe Q2Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=tK6qO2Mi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y14-20020aa7ccce000000b004fd241e4783si1688730edt.610.2023.04.07.00.25.58; Fri, 07 Apr 2023 00:26:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=tK6qO2Mi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239600AbjDGHU0 (ORCPT + 99 others); Fri, 7 Apr 2023 03:20:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239486AbjDGHUZ (ORCPT ); Fri, 7 Apr 2023 03:20:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93134A5F6; Fri, 7 Apr 2023 00:20:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 074FD60F7E; Fri, 7 Apr 2023 07:20:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 55ADEC4339B; Fri, 7 Apr 2023 07:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680852018; bh=QnexnQFeAk6yLJjTDwsZq8ocAO5HizU4Vb2V68oXIEM=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=tK6qO2MiUHjjKaPBRgbZtdMEG3laO2l+TpF9hiP9L224zCtfX2Q9Hr3v3MbgO60v9 O7jSygudJGCW+MsEM38UB29dKzFVDLOk6dFB3/pd3oGzyUBqV9RPcueIOIJq9Z3rWW a7xvkvC00yPvCV8x11VGGYXwtk4sHqNcpE6HJy11YH3bRyx4rUyFW0CJoocEMLYf7V giFwFy3oHFNzhIfhS64dalBTNDdMOJstTbVRojrLVde1f05X2CmTX/DtOekFEa3vRX LbOUWP4tQjBpXR+iGYcXupx1XCo4JttbVltdJ/Siu7lmV8N+q9NIj0mahvmsAh7EMy hgWzhW1/V442Q== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 39754E4F14C; Fri, 7 Apr 2023 07:20:18 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] niu: Fix missing unwind goto in niu_alloc_channels() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <168085201823.13885.16010992572875922038.git-patchwork-notify@kernel.org> Date: Fri, 07 Apr 2023 07:20:18 +0000 References: <20230406063120.3626731-1-harshit.m.mogalapalli@oracle.com> In-Reply-To: <20230406063120.3626731-1-harshit.m.mogalapalli@oracle.com> To: Harshit Mogalapalli Cc: error27@gmail.com, kernel-janitors@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mkl@pengutronix.de, leon@kernel.org, keescook@chromium.org, robh@kernel.org, wsa+renesas@sang-engineering.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Wed, 5 Apr 2023 23:31:18 -0700 you wrote: > Smatch reports: drivers/net/ethernet/sun/niu.c:4525 > niu_alloc_channels() warn: missing unwind goto? > > If niu_rbr_fill() fails, then we are directly returning 'err' without > freeing the channels. > > Fix this by changing direct return to a goto 'out_err'. > > [...] Here is the summary with links: - niu: Fix missing unwind goto in niu_alloc_channels() https://git.kernel.org/netdev/net/c/8ce07be70345 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html