Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Apr 2023 13:56:27 +0530
From:   Nitesh Shetty <nj.shetty@samsung.com>
To:     Yangtao Li <frank.li@vivo.com>
Cc:     Miklos Szeredi <miklos@szeredi.hu>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fuse: remove unnecessary goto
Message-ID: <20230407082627.oh2l4lfltmxy52nx@green5>
MIME-Version: 1.0
In-Reply-To: <20230406195615.80078-1-frank.li@vivo.com>
User-Agent: NeoMutt/20171215
Content-Type: multipart/mixed;
        boundary="----Zd.sqB5Rrz_NXAV9fsVjIXI9mlljbjA9yzE-aJOBfPlcmgnB=_21e39_"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20230406195615.80078-1-frank.li@vivo.com>
        <CGME20230407082718epcas5p4f500a6e00dbbd189fbfed87bf47d6ad1@epcas5p4.samsung.com>
Precedence: bulk

------Zd.sqB5Rrz_NXAV9fsVjIXI9mlljbjA9yzE-aJOBfPlcmgnB=_21e39_
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Disposition: inline

On 23/04/07 03:56AM, Yangtao Li wrote:
>In this case, the error code can be returned directly.
>
>Signed-off-by: Yangtao Li <frank.li@vivo.com>
>---
> fs/fuse/inode.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
>index d66070af145d..56efcf160513 100644
>--- a/fs/fuse/inode.c
>+++ b/fs/fuse/inode.c
>@@ -1921,10 +1921,8 @@ static int fuse_sysfs_init(void)
> 	int err;
>
> 	fuse_kobj = kobject_create_and_add("fuse", fs_kobj);
>-	if (!fuse_kobj) {
>-		err = -ENOMEM;
>-		goto out_err;
>-	}
>+	if (!fuse_kobj)
>+		return -ENOMEM;
>
> 	err = sysfs_create_mount_point(fuse_kobj, "connections");
> 	if (err)
>@@ -1934,7 +1932,6 @@ static int fuse_sysfs_init(void)
>
>  out_fuse_unregister:
> 	kobject_put(fuse_kobj);
>- out_err:
> 	return err;
> }
>
>-- 
>2.35.1
>
Reviewed by: Nitesh Shetty <nj.shetty@samsung.com>

------Zd.sqB5Rrz_NXAV9fsVjIXI9mlljbjA9yzE-aJOBfPlcmgnB=_21e39_
Content-Type: text/plain; charset="utf-8"


------Zd.sqB5Rrz_NXAV9fsVjIXI9mlljbjA9yzE-aJOBfPlcmgnB=_21e39_--