Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp559172rwl; Fri, 7 Apr 2023 01:31:07 -0700 (PDT) X-Google-Smtp-Source: AKy350bGq40pex+4SNOiuvznUfXAYbCe0VWBAOciAmiS46cmigy457cC5znNi34OdocNXgzZCt6y X-Received: by 2002:a17:906:bc4b:b0:947:55ad:dd00 with SMTP id s11-20020a170906bc4b00b0094755addd00mr1400943ejv.26.1680856267053; Fri, 07 Apr 2023 01:31:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680856267; cv=none; d=google.com; s=arc-20160816; b=DU/B+3Ten/VsFUkQ+n1WjT7/g6fT+QPDieMPV3p707raCGMXAmmF1tGLxU6Vyl5Ry2 RyzBf5SlOfqS8s+DKTGIw/7xS8M8hRe2kOsO9tb5JxjdB3OfCP/GRjCPZRPKKa7o+8OO 2MWUgPakxd+i4SGwJz4MYkfJgpRIXkoy1BkmYwMeFdXFUvX9k3+g3WdEW4GvJVS6rR8z jusPf/3faNlDHO6uxMlsdxsKaQw4I+GX+aQbZistV0jgYNk8udL6w2LMT9drRKmxE/78 vN063HEg9fFbrRJ78avIyWQXJ2rH2RKPaVaEsydAtcFuy3mqoJy6Nmuq9yH07WVbR01w 17Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4toWd7JLE2yXSpP8azlFt3BaDgxPuRIxejWSeNfNp9w=; b=k++wnMSbGrsMx4x509RnZ1Z8TmVkli8NajWqUfDW4ukBliiq9uq3pnL7e7bwcUCDIj Er8/eTZZZRvyjWMOWeXj162bbzMyQOcIpMUOF/q/kgHPjDY8v/LeuKyv9ra+PMflgA0K WI2wGiTdXaOa/6VXgUn5nyfS+KCgLwNLcsSAUxZ51ZhMSh8YHT03OpMx2dAsAuoRao4e K7kJ5BeSmAEaQ9nOwakS2J3okHaUmnx2YIR40j5CT2SdNXnKgPY7dTz5dBgBTUkXXirV Z+uNPYlDY3dQBqFjj9XijEmtma5tmmiKHH7xWlnORtd8ppOD7pbNAWIfPRQzkiPH4O5S m8yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=jYnfmSNy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho16-20020a1709070e9000b00948130c7e35si3951857ejc.167.2023.04.07.01.30.41; Fri, 07 Apr 2023 01:31:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=jYnfmSNy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237645AbjDGI3t (ORCPT + 99 others); Fri, 7 Apr 2023 04:29:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234189AbjDGI3s (ORCPT ); Fri, 7 Apr 2023 04:29:48 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A12417ECB; Fri, 7 Apr 2023 01:29:45 -0700 (PDT) X-UUID: 5764fb38d51e11edb6b9f13eb10bd0fe-20230407 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=4toWd7JLE2yXSpP8azlFt3BaDgxPuRIxejWSeNfNp9w=; b=jYnfmSNy3CvIBXS6T8NAIl6z9u4xves8glCo2K0bXbnbILZJF8xn7JMWt4MLarzGnd8VDiau8SA9bJ+2vEUbsg/0pjwQJGbpS+HoTM04LNIdqAvhxpVrMrgPByMzLoN42mwbwHiPrSoA48S/1HpYznZsCBoLmrhItM9D6dHXz74=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.22,REQID:d3c7175b-48f9-41c5-b0ff-eef1fcf6b4a5,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:120426c,CLOUDID:43170ff8-ddba-41c3-91d9-10eeade8eac7,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-UUID: 5764fb38d51e11edb6b9f13eb10bd0fe-20230407 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 66018084; Fri, 07 Apr 2023 16:29:41 +0800 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Fri, 7 Apr 2023 16:29:39 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Fri, 7 Apr 2023 16:29:39 +0800 From: Chunfeng Yun To: Greg Kroah-Hartman , Rob Herring CC: Chunfeng Yun , Krzysztof Kozlowski , Matthias Brugger , AngeloGioacchino Del Regno , , , , , , Tianping Fang Subject: [PATCH v2 2/7] usb: mtu3: use boolean return value Date: Fri, 7 Apr 2023 16:29:32 +0800 Message-ID: <20230407082937.14558-2-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230407082937.14558-1-chunfeng.yun@mediatek.com> References: <20230407082937.14558-1-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Prefer to use boolean value due to gpd_ring_empty() return true or false. See "16) Function return values and names" in coding-style.rst Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Chunfeng Yun --- v2: add Reviewed-by AngeloGioacchino --- drivers/usb/mtu3/mtu3_qmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/mtu3/mtu3_qmu.c b/drivers/usb/mtu3/mtu3_qmu.c index a4da1af0b2c0..6be4977a5db5 100644 --- a/drivers/usb/mtu3/mtu3_qmu.c +++ b/drivers/usb/mtu3/mtu3_qmu.c @@ -221,7 +221,7 @@ static struct qmu_gpd *advance_deq_gpd(struct mtu3_gpd_ring *ring) } /* check if a ring is emtpy */ -static int gpd_ring_empty(struct mtu3_gpd_ring *ring) +static bool gpd_ring_empty(struct mtu3_gpd_ring *ring) { struct qmu_gpd *enq = ring->enqueue; struct qmu_gpd *next; -- 2.18.0