Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230406025036.3022894-1-chenhuacai@loongson.cn>
In-Reply-To: <20230406025036.3022894-1-chenhuacai@loongson.cn>
From:   Guo Ren <guoren@kernel.org>
Date:   Fri, 7 Apr 2023 17:10:22 +0800
Message-ID: <CAJF2gTRjYra4yhWq0UYMmLYfSZ84fHJjC9JcCVpS4NQho7rvGw@mail.gmail.com>
Subject: Re: [PATCH] LoongArch: module: set section addresses to 0x0
To:     Huacai Chen <chenhuacai@loongson.cn>
Cc:     Huacai Chen <chenhuacai@kernel.org>, loongarch@lists.linux.dev,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Xuerui Wang <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn,
        stable@vger.kernel.org, Chong Qiao <qiaochong@loongson.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Apr 6, 2023 at 10:51=E2=80=AFAM Huacai Chen <chenhuacai@loongson.cn=
> wrote:
>
> These got*, plt* and .text.ftrace_trampoline sections specified for
> LoongArch have non-zero addressses. Non-zero section addresses in a
> relocatable ELF would confuse GDB when it tries to compute the section
> offsets and it ends up printing wrong symbol addresses. Therefore, set
> them to zero, which mirrors the change in commit 5d8591bc0fbaeb6ded
> ("arm64 module: set plt* section addresses to 0x0").
Good point, maybe I would check RISC-V!

Thx.

Reviewed-by: Guo Ren <guoren@kernel.org>

>
> Cc: stable@vger.kernel.org
> Signed-off-by: Chong Qiao <qiaochong@loongson.cn>
> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> ---
>  arch/loongarch/include/asm/module.lds.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/loongarch/include/asm/module.lds.h b/arch/loongarch/inc=
lude/asm/module.lds.h
> index 438f09d4ccf4..88554f92e010 100644
> --- a/arch/loongarch/include/asm/module.lds.h
> +++ b/arch/loongarch/include/asm/module.lds.h
> @@ -2,8 +2,8 @@
>  /* Copyright (C) 2020-2022 Loongson Technology Corporation Limited */
>  SECTIONS {
>         . =3D ALIGN(4);
> -       .got : { BYTE(0) }
> -       .plt : { BYTE(0) }
> -       .plt.idx : { BYTE(0) }
> -       .ftrace_trampoline : { BYTE(0) }
> +       .got 0 : { BYTE(0) }
> +       .plt 0 : { BYTE(0) }
> +       .plt.idx 0 : { BYTE(0) }
> +       .ftrace_trampoline 0 : { BYTE(0) }
>  }
> --
> 2.39.1
>


--=20
Best Regards
 Guo Ren