Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Apr 2023 12:15:32 +0300
From:   Mike Rapoport <rppt@linux.ibm.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        David Hildenbrand <david@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Nadav Amit <nadav.amit@gmail.com>
Subject: Re: [PATCH 03/29] selftests/mm: Dump a summary in run_vmtests.sh
Message-ID: <ZC/fNPD+5F7qQHLC@linux.ibm.com>
References: <20230330155707.3106228-1-peterx@redhat.com>
 <20230330160646.3106903-1-peterx@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230330160646.3106903-1-peterx@redhat.com>
Precedence: bulk

On Thu, Mar 30, 2023 at 12:06:46PM -0400, Peter Xu wrote:
> Dump a summary after running whatever test specified.  Useful for human
> runners to identify any kind of failures (besides exit code).
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>

> ---
>  tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> index c0f93b668c0c..9cc33984aa9f 100644
> --- a/tools/testing/selftests/mm/run_vmtests.sh
> +++ b/tools/testing/selftests/mm/run_vmtests.sh
> @@ -5,6 +5,9 @@
>  # Kselftest framework requirement - SKIP code is 4.
>  ksft_skip=4
> 
> +count_pass=0
> +count_fail=0
> +count_skip=0
>  exitcode=0
> 
>  usage() {
> @@ -149,11 +152,14 @@ run_test() {
>  		"$@"
>  		local ret=$?
>  		if [ $ret -eq 0 ]; then
> +			count_pass=$(( $count_pass + 1 ))
>  			echo "[PASS]"
>  		elif [ $ret -eq $ksft_skip ]; then
> +			count_skip=$(( $count_skip + 1 ))
>  			echo "[SKIP]"
>  			exitcode=$ksft_skip
>  		else
> +			count_fail=$(( $count_fail + 1 ))
>  			echo "[FAIL]"
>  			exitcode=1
>  		fi
> @@ -279,4 +285,6 @@ CATEGORY="soft_dirty" run_test ./soft-dirty
>  # COW tests
>  CATEGORY="cow" run_test ./cow
> 
> +echo "SUMMARY: PASS=${count_pass} SKIP=${count_skip} FAIL=${count_fail}"
> +
>  exit $exitcode
> -- 
> 2.39.1
> 

-- 
Sincerely yours,
Mike.