Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230316153841.3666-1-rui.zhang@intel.com> <20230316153841.3666-8-rui.zhang@intel.com>
In-Reply-To: <20230316153841.3666-8-rui.zhang@intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 7 Apr 2023 13:40:18 +0200
Message-ID: <CAJZ5v0igEHBKkYU3eDfET1giR6xoNsYVxBycuxD_+QZiGW68nA@mail.gmail.com>
Subject: Re: [PATCH 07/15] powercap/intel_rapl: Change primitive order
To:     Zhang Rui <rui.zhang@intel.com>
Cc:     linux-pm@vger.kernel.org, rafael.j.wysocki@intel.com,
        daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org,
        srinivas.pandruvada@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Mar 16, 2023 at 4:42 PM Zhang Rui <rui.zhang@intel.com> wrote:
>
> Move POWER_LIMIT1/POWER_LIMIT2/POWER_LIMIT4 to the beginning of enum
> rapl_primitives so that they can be reused to represent different Power
> Limits.

The meaning of the above is a bit unclear without reverse engineering
the rest of the series.

> No functional change.
>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> ---
>  drivers/powercap/intel_rapl_common.c | 4 ++--
>  include/linux/intel_rapl.h           | 5 +++--
>  2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
> index 9e29e56f4900..3a8940d3bec8 100644
> --- a/drivers/powercap/intel_rapl_common.c
> +++ b/drivers/powercap/intel_rapl_common.c
> @@ -631,14 +631,14 @@ static u64 rapl_unit_xlate(struct rapl_domain *rd, enum unit_type type,
>
>  static struct rapl_primitive_info rpis_default[NR_RAPL_PRIMITIVES] = {
>         /* name, mask, shift, msr index, unit divisor */
> -       [ENERGY_COUNTER] = PRIMITIVE_INFO_INIT(ENERGY_COUNTER, ENERGY_STATUS_MASK, 0,
> -                           RAPL_DOMAIN_REG_STATUS, ENERGY_UNIT, 0),
>         [POWER_LIMIT1] = PRIMITIVE_INFO_INIT(POWER_LIMIT1, POWER_LIMIT1_MASK, 0,
>                             RAPL_DOMAIN_REG_LIMIT, POWER_UNIT, 0),
>         [POWER_LIMIT2] = PRIMITIVE_INFO_INIT(POWER_LIMIT2, POWER_LIMIT2_MASK, 32,
>                             RAPL_DOMAIN_REG_LIMIT, POWER_UNIT, 0),
>         [POWER_LIMIT4] = PRIMITIVE_INFO_INIT(POWER_LIMIT4, POWER_LIMIT4_MASK, 0,
>                                 RAPL_DOMAIN_REG_PL4, POWER_UNIT, 0),
> +       [ENERGY_COUNTER] = PRIMITIVE_INFO_INIT(ENERGY_COUNTER, ENERGY_STATUS_MASK, 0,
> +                           RAPL_DOMAIN_REG_STATUS, ENERGY_UNIT, 0),
>         [FW_LOCK] = PRIMITIVE_INFO_INIT(FW_LOCK, POWER_LOW_LOCK, 31,
>                             RAPL_DOMAIN_REG_LIMIT, ARBITRARY_UNIT, 0),
>         [PL1_ENABLE] = PRIMITIVE_INFO_INIT(PL1_ENABLE, POWER_LIMIT1_ENABLE, 15,
> diff --git a/include/linux/intel_rapl.h b/include/linux/intel_rapl.h
> index 1648923f694d..856b739fd194 100644
> --- a/include/linux/intel_rapl.h
> +++ b/include/linux/intel_rapl.h
> @@ -37,10 +37,10 @@ enum rapl_domain_reg_id {
>  struct rapl_domain;
>
>  enum rapl_primitives {
> -       ENERGY_COUNTER,
>         POWER_LIMIT1,
>         POWER_LIMIT2,
>         POWER_LIMIT4,
> +       ENERGY_COUNTER,
>         FW_LOCK,
>
>         PL1_ENABLE,             /* power limit 1, aka long term */
> @@ -75,7 +75,8 @@ struct rapl_domain_data {
>         unsigned long timestamp;
>  };
>
> -#define NR_POWER_LIMITS (3)
> +#define NR_POWER_LIMITS        (POWER_LIMIT4 + 1)
> +
>  struct rapl_power_limit {
>         struct powercap_zone_constraint *constraint;
>         int prim_id;            /* primitive ID used to enable */
> --
> 2.25.1
>