Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230312200731.599706-7-masahiroy@kernel.org> <20230406152540.8207-1-youling257@gmail.com>
In-Reply-To: <20230406152540.8207-1-youling257@gmail.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Fri, 7 Apr 2023 21:04:21 +0900
Message-ID: <CAK7LNASWhW-dvxcexmkYwA_j-iPr6CbWP3emqEJkKT2qbCFtgg@mail.gmail.com>
Subject: Re: [PATCH 6/6] kbuild: use git-archive for source package creation
To:     youling257 <youling257@gmail.com>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        nathan@kernel.org, ndesaulniers@google.com, nicolas@fjasle.eu,
        terrelln@fb.com, torvalds@linux-foundation.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Apr 7, 2023 at 12:25=E2=80=AFAM youling257 <youling257@gmail.com> w=
rote:
>
> This patch cause build time a bit longer.
> I use "time make targz-pkg -i -j8" build kernel, this patch will first cr=
eate *.tar file, then create *.tar.gz file, build time a bit longer.
> './System.map' -> 'tar-install/boot/System.map-6.3.0-rc5-android-x86_64+'
> '.config' -> 'tar-install/boot/config-6.3.0-rc5-android-x86_64+'
> './vmlinux' -> 'tar-install/boot/vmlinux-6.3.0-rc5-android-x86_64+'
> './arch/x86/boot/bzImage' -> 'tar-install/boot/vmlinuz-6.3.0-rc5-android-=
x86_64+'
>   TAR     linux-6.3.0-rc5-android-x86_64+-x86.tar
>   GZIP    linux-6.3.0-rc5-android-x86_64+-x86.tar.gz
>
> real    0m37.991s
> user    0m47.529s
> sys     0m8.235s
>
> Revert "kbuild: use git-archive for source package creation"
> './System.map' -> 'tar-install/boot/System.map-6.3.0-rc5-android-x86_64+'
> '.config' -> 'tar-install/boot/config-6.3.0-rc5-android-x86_64+'
> './vmlinux' -> 'tar-install/boot/vmlinux-6.3.0-rc5-android-x86_64+'
> './arch/x86/boot/bzImage' -> 'tar-install/boot/vmlinuz-6.3.0-rc5-android-=
x86_64+'
>   TAR     linux-6.3.0-rc5-android-x86_64+-x86.tar.gz
>
> real    0m11.006s
> user    0m21.079s
> sys     0m7.830s
>
> I don't like *.tar file, i will delete *.tar file when every time build k=
ernel, i need *.tar.gz file, if one file is i needn't, i will delete it.
> linux-6.3.0-rc5-android-x86_64+-x86.tar.gz file is i need, linux-6.3.0-rc=
5-android-x86_64+-x86.tar is i needn't.


OK.

On second thought, splitting tar and compression was unneeded.

I submitted a patch set to avoid unneeded *.tar creation.


https://lore.kernel.org/lkml/20230407101629.1298051-1-masahiroy@kernel.org/=
T/#t


--=20
Best Regards
Masahiro Yamada