Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230203-evk-board-support-v5-0-1883c1b405ad@baylibre.com> <20230203-evk-board-support-v5-12-1883c1b405ad@baylibre.com>
In-Reply-To: <20230203-evk-board-support-v5-12-1883c1b405ad@baylibre.com>
From:   Alexandre Mergnat <amergnat@baylibre.com>
Date:   Fri, 7 Apr 2023 15:14:40 +0200
Message-ID: <CAFGrd9qew3P2w7G5FxVPGyNNdx=4ZLeGjSXAktQgeQGyD2FcqA@mail.gmail.com>
Subject: Re: [PATCH v5 12/12] arm64: dts: mediatek: Add CPU Idle support
To:     Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Chaotian Jing <chaotian.jing@mediatek.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Wenbin Mei <wenbin.mei@mediatek.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Zhiyong Tao <zhiyong.tao@mediatek.com>,
        =?UTF-8?Q?Bernhard_Rosenkr=C3=A4nzer?= <bero@baylibre.com>,
        catalin.marinas@arm.com, Will Deacon <will@kernel.org>
Cc:     linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-mmc@vger.kernel.org,
        linux-gpio@vger.kernel.org,
        Alexandre Bailon <abailon@baylibre.com>,
        Fabien Parent <fparent@baylibre.com>,
        Amjad Ouled-Ameur <aouledameur@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

+ To: Catalin Marinas <catalin.marinas@arm.com>
+ To: Will Deacon <will@kernel.org>

Sorry for the noise.

Regards,
Alexandre

Le ven. 7 avr. 2023 =C3=A0 14:59, <amergnat@baylibre.com> a =C3=A9crit :
>
> From: Amjad Ouled-Ameur <aouledameur@baylibre.com>
>
> MT8365 has 3 CPU Idle states:
> - MCDI_CPU. (Multi-Core-Deep-Idle)
> - MCDI_CLUSTER.
> - DPIDLE. (Deep-Idle)
>
> Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collab=
ora.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8365.dtsi | 35 ++++++++++++++++++++++++++=
++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8365.dtsi b/arch/arm64/boot/d=
ts/mediatek/mt8365.dtsi
> index cfe0c67ad61f..413496c92069 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8365.dtsi
> @@ -128,6 +128,7 @@ cpu0: cpu@0 {
>                         reg =3D <0x0>;
>                         #cooling-cells =3D <2>;
>                         enable-method =3D "psci";
> +                       cpu-idle-states =3D <&CPU_MCDI &CLUSTER_MCDI &CLU=
STER_DPIDLE>;
>                         i-cache-size =3D <0x8000>;
>                         i-cache-line-size =3D <64>;
>                         i-cache-sets =3D <256>;
> @@ -147,6 +148,7 @@ cpu1: cpu@1 {
>                         reg =3D <0x1>;
>                         #cooling-cells =3D <2>;
>                         enable-method =3D "psci";
> +                       cpu-idle-states =3D <&CPU_MCDI &CLUSTER_MCDI &CLU=
STER_DPIDLE>;
>                         i-cache-size =3D <0x8000>;
>                         i-cache-line-size =3D <64>;
>                         i-cache-sets =3D <256>;
> @@ -166,6 +168,7 @@ cpu2: cpu@2 {
>                         reg =3D <0x2>;
>                         #cooling-cells =3D <2>;
>                         enable-method =3D "psci";
> +                       cpu-idle-states =3D <&CPU_MCDI &CLUSTER_MCDI &CLU=
STER_DPIDLE>;
>                         i-cache-size =3D <0x8000>;
>                         i-cache-line-size =3D <64>;
>                         i-cache-sets =3D <256>;
> @@ -185,6 +188,7 @@ cpu3: cpu@3 {
>                         reg =3D <0x3>;
>                         #cooling-cells =3D <2>;
>                         enable-method =3D "psci";
> +                       cpu-idle-states =3D <&CPU_MCDI &CLUSTER_MCDI &CLU=
STER_DPIDLE>;
>                         i-cache-size =3D <0x8000>;
>                         i-cache-line-size =3D <64>;
>                         i-cache-sets =3D <256>;
> @@ -198,6 +202,37 @@ cpu3: cpu@3 {
>                         operating-points-v2 =3D <&cluster0_opp>;
>                 };
>
> +               idle-states {
> +                       entry-method =3D "psci";
> +
> +                       CPU_MCDI: cpu-mcdi {
> +                               compatible =3D "arm,idle-state";
> +                               local-timer-stop;
> +                               arm,psci-suspend-param =3D <0x00010001>;
> +                               entry-latency-us =3D <300>;
> +                               exit-latency-us =3D <200>;
> +                               min-residency-us =3D <1000>;
> +                       };
> +
> +                       CLUSTER_MCDI: cluster-mcdi {
> +                               compatible =3D "arm,idle-state";
> +                               local-timer-stop;
> +                               arm,psci-suspend-param =3D <0x01010001>;
> +                               entry-latency-us =3D <350>;
> +                               exit-latency-us =3D <250>;
> +                               min-residency-us =3D <1200>;
> +                       };
> +
> +                       CLUSTER_DPIDLE: cluster-dpidle {
> +                               compatible =3D "arm,idle-state";
> +                               local-timer-stop;
> +                               arm,psci-suspend-param =3D <0x01010004>;
> +                               entry-latency-us =3D <300>;
> +                               exit-latency-us =3D <800>;
> +                               min-residency-us =3D <3300>;
> +                       };
> +               };
> +
>                 l2: l2-cache {
>                         compatible =3D "cache";
>                         cache-level =3D <2>;
>
> --
> 2.25.1
>