Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230403103440.2895683-1-vladimir.oltean@nxp.com> <20230403103440.2895683-3-vladimir.oltean@nxp.com>
In-Reply-To: <20230403103440.2895683-3-vladimir.oltean@nxp.com>
From:   Jamal Hadi Salim <jhs@mojatatu.com>
Date:   Fri, 7 Apr 2023 12:05:35 -0400
Message-ID: <CAM0EoMkvfUOubhgC+PpLi9vKcjsyc+Tp-uOuK60AJhaMaS2ogA@mail.gmail.com>
Subject: Re: [PATCH v4 net-next 2/9] net/sched: mqprio: simplify handling of
 nlattr portion of TCA_OPTIONS
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Amritha Nambiar <amritha.nambiar@intel.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Roger Quadros <rogerq@kernel.org>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
        Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>,
        Oleksij Rempel <linux@rempel-privat.de>,
        Jacob Keller <jacob.e.keller@intel.com>,
        linux-kernel@vger.kernel.org, Ferenc Fejes <fejes@inf.elte.hu>,
        Simon Horman <simon.horman@corigine.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Apr 3, 2023 at 6:35=E2=80=AFAM Vladimir Oltean <vladimir.oltean@nxp=
.com> wrote:
>
> In commit 4e8b86c06269 ("mqprio: Introduce new hardware offload mode and
> shaper in mqprio"), the TCA_OPTIONS format of mqprio was extended to
> contain a fixed portion (of size NLA_ALIGN(sizeof struct tc_mqprio_qopt))
> and a variable portion of other nlattrs (in the TCA_MQPRIO_* type space)
> following immediately afterwards.
>
> In commit feb2cf3dcfb9 ("net/sched: mqprio: refactor nlattr parsing to a
> separate function"), we've moved the nlattr handling to a smaller
> function, but yet, a small parse_attr() still remains, and the larger
> mqprio_parse_nlattr() still does not have access to the beginning, and
> the length, of the TCA_OPTIONS region containing these other nlattrs.
>
> In a future change, the mqprio qdisc will need to iterate through this
> nlattr region to discover other attributes, so eliminate parse_attr()
> and add 2 variables in mqprio_parse_nlattr() which hold the beginning
> and the length of the nlattr range.
>
> We avoid the need to memset when nlattr_opt_len has insufficient length
> by pre-initializing the table "tb".
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Reviewed-by: Ferenc Fejes <fejes@inf.elte.hu>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal

> ---
> v1->v4: none
>
>  net/sched/sch_mqprio.c | 32 +++++++++++++-------------------
>  1 file changed, 13 insertions(+), 19 deletions(-)
>
> diff --git a/net/sched/sch_mqprio.c b/net/sched/sch_mqprio.c
> index 48ed87b91086..94093971da5e 100644
> --- a/net/sched/sch_mqprio.c
> +++ b/net/sched/sch_mqprio.c
> @@ -146,32 +146,26 @@ static const struct nla_policy mqprio_policy[TCA_MQ=
PRIO_MAX + 1] =3D {
>         [TCA_MQPRIO_MAX_RATE64] =3D { .type =3D NLA_NESTED },
>  };
>
> -static int parse_attr(struct nlattr *tb[], int maxtype, struct nlattr *n=
la,
> -                     const struct nla_policy *policy, int len)
> -{
> -       int nested_len =3D nla_len(nla) - NLA_ALIGN(len);
> -
> -       if (nested_len >=3D nla_attr_size(0))
> -               return nla_parse_deprecated(tb, maxtype,
> -                                           nla_data(nla) + NLA_ALIGN(len=
),
> -                                           nested_len, policy, NULL);
> -
> -       memset(tb, 0, sizeof(struct nlattr *) * (maxtype + 1));
> -       return 0;
> -}
> -
> +/* Parse the other netlink attributes that represent the payload of
> + * TCA_OPTIONS, which are appended right after struct tc_mqprio_qopt.
> + */
>  static int mqprio_parse_nlattr(struct Qdisc *sch, struct tc_mqprio_qopt =
*qopt,
>                                struct nlattr *opt)
>  {
> +       struct nlattr *nlattr_opt =3D nla_data(opt) + NLA_ALIGN(sizeof(*q=
opt));
> +       int nlattr_opt_len =3D nla_len(opt) - NLA_ALIGN(sizeof(*qopt));
>         struct mqprio_sched *priv =3D qdisc_priv(sch);
> -       struct nlattr *tb[TCA_MQPRIO_MAX + 1];
> +       struct nlattr *tb[TCA_MQPRIO_MAX + 1] =3D {};
>         struct nlattr *attr;
>         int i, rem, err;
>
> -       err =3D parse_attr(tb, TCA_MQPRIO_MAX, opt, mqprio_policy,
> -                        sizeof(*qopt));
> -       if (err < 0)
> -               return err;
> +       if (nlattr_opt_len >=3D nla_attr_size(0)) {
> +               err =3D nla_parse_deprecated(tb, TCA_MQPRIO_MAX, nlattr_o=
pt,
> +                                          nlattr_opt_len, mqprio_policy,
> +                                          NULL);
> +               if (err < 0)
> +                       return err;
> +       }
>
>         if (!qopt->hw)
>                 return -EINVAL;
> --
> 2.34.1
>