Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8ccfac25-678e-3e75-553f-a263bdbfaacd@intel.com>
Date:   Fri, 7 Apr 2023 09:24:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.0
Subject: Re: [PATCH] fpga: dfl-fme: constify pointers to hwmon_channel_info
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
        Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
        <linux-fpga@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        <linux-hwmon@vger.kernel.org>
References: <20230407150112.79854-1-krzysztof.kozlowski@linaro.org>
From:   Russ Weight <russell.h.weight@intel.com>
In-Reply-To: <20230407150112.79854-1-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUE3N3E4ZWJ4d2pvazFIWkxqYkwzL202K1NIdVMyUk5oWlMrL3U1cituT2Rr?=
 =?utf-8?B?Wm1mZE1odExxenBJZ3dEblJFbEh6MHBUTE0wU0dZVjk4MjFac0RJNWhjQmVY?=
 =?utf-8?B?Sk9DbXRPZ3RaUDJTMUNjSzdlV0ZySXIyOWVoOXZxSkFXeVJROTRqK1BlaTRW?=
 =?utf-8?B?UktoaFFwT1Jxa2hwc3hxczVMb2p6dko2cEFVSkhqUHYycVN5K3lmNnZpQzJM?=
 =?utf-8?B?TER1cVQyN0ljZ2ZzMUVJSXZ0U1UwT1Q5bkEwUUlFY0VVVUtaVUhITlhGWVV2?=
 =?utf-8?B?NTJCb3BPMkl1ZTRhNWtDdVlxMkhYNzJSSXludWZVa3JISGVMTk9OcVgyMGtD?=
 =?utf-8?B?am9VVEIzclJMZ3VtaUhFWlZrYTBXSk5uYzI3M2ZGRFhqeTZIS1ZOSGFOalZE?=
 =?utf-8?B?YTVwVGdGUFM1dzNWUU1reXZrc1JBYWYyM3M0NlNHODFJMTN3N0dNV1RnS2w5?=
 =?utf-8?B?TmpPbjcwakdEYVljVUxDUk9VQ0UyMG1BaHlmUGJLOElwcXdNdWNrOXVvNFBR?=
 =?utf-8?B?MmZ6NHJScjRXNnV2UE5udWFSbDA5Y043U2F3NVpTYlBzMW9sT2EvbXd2MFM2?=
 =?utf-8?B?Y0UwK1RwaTN0VU0rM0llcEphOEZ1TDN6dEVxU2pmcHFKd1RVV0VNVktsOVJW?=
 =?utf-8?B?QUZNVjVGamJJbXlHdGQ2NnBTazg5ZkxjQUZTd25YWkxwcytyVFQ0VmxIK1dm?=
 =?utf-8?B?SFhkUnpaZVZETS96dTV1eDhnVkxvT2NZUEk3QmQ2azU3dVk1MFAzZXhqZ2VU?=
 =?utf-8?B?VDQ0SUd6MGY1WXhMendIaXNUWitJVGs4bkhzWmd1SHlqendWbjZhQS9adk51?=
 =?utf-8?B?WHNMZkRVTTRQYnllY1ZHdHhJSW9ZR3BkOEdiNEhkOHZjZ0NVMFdJTnJWUkVy?=
 =?utf-8?B?WXQ3WU5LZDdKOE1zTEQrOUhlZDYvRGJIcCt3QVNJaTRJRU1WV2pYU1NVcWdZ?=
 =?utf-8?B?UzlwMlZ4SHMvQUtuQVhDMDk3Nkh2TFpzUXRWZVMvT2VERDZML2M0TEpGTW5k?=
 =?utf-8?B?a0tJREJFRkpiNk5yNkEzZEZZYlVoUDJDOTI5R0RuOWhNM3AzcE1LK2RUNlQ2?=
 =?utf-8?B?K0lLZG8zRDl1b2tnN2MxSkRiM1RVNnhMR0M4b1hjOHpyZE5FSU5LTG16allX?=
 =?utf-8?B?N3dlNjBXWkUyWW9KVk9uelY4WUpZNmVvY2RtK1h3KzFKeEYxNVI5Q3Q3VEhi?=
 =?utf-8?B?ZlZwRnY4ZytVSHQzM2d0cGdzODhWazNodGVTdjdkeGxUdWFxd2VEWHZ4V3lp?=
 =?utf-8?B?QXBMa0RDN0FDRW15NUNxMlFRWkhFOXA1eDd6SHg3OHNVM0ZKb2FGRUNqekRD?=
 =?utf-8?B?cS81YllVSGVqcnRnU1RVdXVvWUFXRmhTSS94aWxWdHF5b1l3MHNCckRFeDVo?=
 =?utf-8?B?RjBCdEpla1Q3WTY5UnpKT2tmZlFVbkY4N2FwVC9QcWNiWjFFWlIwdW1idERl?=
 =?utf-8?B?K0JlZS9LZXZOODdZUFV5N1JUUUxLVGVKQWJNaFlHNVVvTDcyeXpOUFpjYTMv?=
 =?utf-8?B?YUMxekVOTEZDcENYNjM3UHI1ajd2RStZM1ZCSXFSYjhITGR4Unh1aTlJSktj?=
 =?utf-8?B?bmlhYjU5cXhqVXpXeGVSR3NNYk56a0pXaFlZblI5aFdDRENvT2NZNlo5TVlr?=
 =?utf-8?B?RzgzNmJqY0xneG50dlVHZUg5blNKaEJERlRjSXdhUjhIc0tlK01LUHZiNjdr?=
 =?utf-8?B?eFM5QnAxWGM2UE1lOE4wY3A4WFY3VklHcUQ4ZFlWOEEvZy9obnVHVndVMWFB?=
 =?utf-8?B?VGlHdmNpd1drT0pGL3JvbzVUQ3RJZVFaZ0FvYmV0WkxTL1dNcE1aZUNOQnNS?=
 =?utf-8?B?L1FJUTFyT2FuSFBYNGxZVmhwOWFIWXBSNmtjQlFJcUxpUm14ei9jQi9OZEhu?=
 =?utf-8?B?b2M0WXVOeUFka2lKQTcxQ2J1eTlENFJFMFRjcllsYWMxVW1yTnJxOFNMbmVl?=
 =?utf-8?B?bWZWclBSak54Z05rSnhxdnhZWGxwU3p2azBqY0VpemM0Vm02M3cyREg2SU5E?=
 =?utf-8?B?VHBTakNORGx5QlIyT3JJVnNhNU1hWEN1MEJ0THhNR2I1djFSRGFZTzF1cE9U?=
 =?utf-8?B?M3dCR29hRzBLbWUvMzZ3bmtKYmhDR1dmMHpMek9nOXBBb2R3b045NXRTbkhI?=
 =?utf-8?B?RkZPMEgwQlFWbDFwaExMQXhhUXZsYTA5TEc5SlRlVXVoWHIxQXpmVklTbkRN?=
 =?utf-8?B?alE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ed7ecae-efa1-474d-dea8-08db37849f34
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB6763.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2023 16:24:55.1376
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gv+SEZ3eDsaFy9xbov+j9/2wbl6C8P6XXVoHmzexPiz3Iz66r6GzHLnYwxcrJGC2B67rEKD/z9pgRIdVHyW8fDwJ7ZhFREmeFOB2AIoQ1IE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6649
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

 
On 4/7/23 08:01, Krzysztof Kozlowski wrote:
> Statically allocated array of pointed to hwmon_channel_info can be made
> const for safety.

Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> This depends on hwmon core patch:
> https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@linaro.org/
>
> Therefore I propose this should also go via hwmon tree.
>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-hwmon@vger.kernel.org
> ---
>  drivers/fpga/dfl-fme-main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/dfl-fme-main.c b/drivers/fpga/dfl-fme-main.c
> index 77ea04d4edbe..bcb5d34b3b82 100644
> --- a/drivers/fpga/dfl-fme-main.c
> +++ b/drivers/fpga/dfl-fme-main.c
> @@ -265,7 +265,7 @@ static const struct hwmon_ops thermal_hwmon_ops = {
>  	.read = thermal_hwmon_read,
>  };
>  
> -static const struct hwmon_channel_info *thermal_hwmon_info[] = {
> +static const struct hwmon_channel_info * const thermal_hwmon_info[] = {
>  	HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_EMERGENCY |
>  				 HWMON_T_MAX   | HWMON_T_MAX_ALARM |
>  				 HWMON_T_CRIT  | HWMON_T_CRIT_ALARM),
> @@ -465,7 +465,7 @@ static const struct hwmon_ops power_hwmon_ops = {
>  	.write = power_hwmon_write,
>  };
>  
> -static const struct hwmon_channel_info *power_hwmon_info[] = {
> +static const struct hwmon_channel_info * const power_hwmon_info[] = {
>  	HWMON_CHANNEL_INFO(power, HWMON_P_INPUT |
>  				  HWMON_P_MAX   | HWMON_P_MAX_ALARM |
>  				  HWMON_P_CRIT  | HWMON_P_CRIT_ALARM),