Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Apr 2023 18:36:03 +0200
From:   Maxime Chevallier <maxime.chevallier@bootlin.com>
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Lee Jones <lee@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        thomas.petazzoni@bootlin.com
Subject: Re: [PATCH] regmap: allow upshifting register addresses before
 performing operations
Message-ID: <20230407183603.1243bceb@pc-7.home>
In-Reply-To: <ZDA9vafqY0j0NhT3@euler>
References: <20230407152604.105467-1-maxime.chevallier@bootlin.com>
        <ZDA9vafqY0j0NhT3@euler>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Colin,

On Fri, 7 Apr 2023 08:58:53 -0700
Colin Foster <colin.foster@in-advantage.com> wrote:

> Hi Maxime,
> 
> On Fri, Apr 07, 2023 at 05:26:04PM +0200, Maxime Chevallier wrote:
> >  	.reg_stride = 4,
> > -	.reg_downshift = 2,
> > +	.reg_shift = REGMAP_DOWNSHIFT(2),
> >  	.val_bits = 32,  
> 
> Looks great! Thanks. I tested this with a merge of net-next and
> regmap-next + this patch.
> 
> Tested-by: Colin Foster <colin.foster@in-advantage.com>

Thanks for the test !

Maxime