Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alvaro Karsz <alvaro.karsz@solid-run.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>,
        "viktor@daynix.com" <viktor@daynix.com>
CC:     "jasowang@redhat.com" <jasowang@redhat.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "pasic@linux.ibm.com" <pasic@linux.ibm.com>,
        "farman@linux.ibm.com" <farman@linux.ibm.com>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "yan@daynix.com" <yan@daynix.com>
Subject: Re: [PATCH v6] virtio: add VIRTIO_F_NOTIFICATION_DATA feature support
Thread-Topic: [PATCH v6] virtio: add VIRTIO_F_NOTIFICATION_DATA feature
 support
Thread-Index: AQHZXon0whv8NnC6hUW1jNhoqDcu6a8W1qQogASvawCABJtfrA==
Date:   Fri, 7 Apr 2023 16:48:14 +0000
Message-ID: <AM6PR04MB4725AAE468363214FC548A53D4969@AM6PR04MB4725.eurprd04.prod.outlook.com>
References: <20230324195029.2410503-1-viktor@daynix.com>
 <AM0PR04MB4723A8D079076FA56AB45845D48C9@AM0PR04MB4723.eurprd04.prod.outlook.com>
 <20230404141501-mutt-send-email-mst@kernel.org>
In-Reply-To: <20230404141501-mutt-send-email-mst@kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-GB
msip_labels: 
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=solid-run.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: AM6PR04MB4725:EE_|PAXPR04MB8589:EE_
x-ms-office365-filtering-correlation-id: 26cae1dc-4a28-428a-1f7b-08db3787e1af
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: FxeINmh/bt17ntb9fcjrhd65PBF0aaSsWJr4Z4eXEy44LGbBCL+ZjT3201zW+anu1HivVR0zvmQ16A/QJxmbxStOx5WzYRDwNaZEBfjMmDm6M1l07p5GaFkWi0OMWz9t/pEOXXBvWK5scg649TTB+GLOBzSL/qQascgVIr96Gg6Sfu6mJPIIfdHHI+PenCzrNcXVySkWs3elZzj95xcxq9BwIrz1/DBKvSme7izKdP+niRITaJ+AulKeO4moV2aM1Wswt4JtNN6wOf9hli10wQs6i0pvfDxxg1aJ/h66YIz7zEtmkS1TJCinVET/GTZGI//2WWCZTdSiO4MdMWg8jiFOGaX13r1WEXlE5kkb9YBuySkAt5qMWhW/aQwF33gbSpYiScAcUBOvzquEC2iDjuDbdTi85XwWjsTadYS4nTPFiwJZ0L8f95UsNYoD1AFwVsH7AOcv3qUNHIceS6YH9KFQ/TWqTdRQhobiMn7zP7Jq8hBjizznqJvKIEfTRwoH/137uLAR9yOOlwMVj6hDH9xqFcRDYXqT7fvUY+OtLh7mynOqX9+PJ+poiSAO7l6ZpcYGAOwYEhX3+BkVGmUxRlgxsFQfMiK4LmdljmfcplM=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4725.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39830400003)(376002)(136003)(396003)(346002)(366004)(451199021)(86362001)(33656002)(91956017)(76116006)(966005)(66946007)(41300700001)(110136005)(316002)(66476007)(66446008)(64756008)(66556008)(478600001)(54906003)(4326008)(8676002)(7696005)(38070700005)(71200400001)(83380400001)(55016003)(44832011)(2906002)(8936002)(7416002)(5660300002)(38100700002)(186003)(52536014)(122000001)(9686003)(6506007)(66899021);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?GIzjPrlLdysMdfsS4Pxa1Ae9BjGalUWMZaKchqCyrS+nAW0Z3WGKM+DBUw?=
 =?iso-8859-1?Q?Y4aHejGPWoZWyxUuADAZakm+ha8rvRHk+IYIHIfYAZwfUXtLJJclaYI0WN?=
 =?iso-8859-1?Q?wS6+79N75zqBm8aoSRyjLU9EU/rFc7P7eHCTw0s/YZp51XNWqu/RT0D9Hl?=
 =?iso-8859-1?Q?oMuvhBF/kpspTrGnwt6Gq5w4LseBEIGZ7uMBYVcMfzjSNrahZeV9MEdHUK?=
 =?iso-8859-1?Q?v7nEF7ogHxF3M1+ctS2Db945SwccOfYLtzGgiIKkTAD4whXTkE8BJBLm1v?=
 =?iso-8859-1?Q?1Tdrzk354jJRfMUz+JIegSBXZKhzSNJEE2izRUFX/jM2SiO/oB7aLrviSx?=
 =?iso-8859-1?Q?JYKhn2D+xL0xHrr+fatdzGo+FPcz4jR5rwlRLMmBU5vzI95NRyKc0XkYeG?=
 =?iso-8859-1?Q?49Rvz8NOtcVQ8B51/rpri1jF0jjlXu6kVb0kxOrmS1BkydH6knlwFX+gSx?=
 =?iso-8859-1?Q?s0tUGOw5BCBjYgKXiZBHWhB/UkOLjksPzts7kooQ52otFgJnRajXQpmYqZ?=
 =?iso-8859-1?Q?wSXOppHIzjJMTX9rnojMbuBu0hMdAzEkTIdDXtVn4hbNxoaftvWBrpkZXV?=
 =?iso-8859-1?Q?FyE7zbGyfbaOXFceU+CdwdQ8ZfJqDtXyJ6ojeHXaSNKxsh0yv1ArmxY6mN?=
 =?iso-8859-1?Q?/8/GUn+QUhJc1HTCeFhgr2Hul4Qe18XaTvyMfEWBHcIkA99+VwSVRnVn6V?=
 =?iso-8859-1?Q?qMzRdoQkim7lRtQD+y+k06I2qeFZD21dHK1XuEVs/Rdd+MNmRLHoO4PgR5?=
 =?iso-8859-1?Q?PeBFSZDlMmlzgByRiNL1CVbLMIQN8O/jhrmhWrT04hXoVcqf2BmfZD2K6V?=
 =?iso-8859-1?Q?etIA7XRTFZIC54y6ylN46da+ANRDHF3XG0PfqfleH+W8jrMDElULBCyHhp?=
 =?iso-8859-1?Q?0/OZ5/1AzW0epr6uBnBR4LbTEyafjQ/Hr1IcZKYUI6Grhte9iS9TkzFwg1?=
 =?iso-8859-1?Q?ylQEegv65JmDwpRZK6QC7gEYgr4xL+ynP2umg0QXOjUufqn4NPOecnwUI0?=
 =?iso-8859-1?Q?qNlFaE6p2+JRBSTGkTUltwUGrnCLKwF050o6bzTiy/Zu0vpRsZl5q0awHq?=
 =?iso-8859-1?Q?yCKUz1SmPdM+9brArW86rNzEjp1ULsSZXac9qh5wMHGZk4oJgRGDPmopKT?=
 =?iso-8859-1?Q?1YilukO6g59apVLDRCkStk8X2aBalprLkTgTouV+wg1TL0spWMHLfAqyra?=
 =?iso-8859-1?Q?zK5Q/TiaHuID7yl0nLLHKQPY/sYPoEZriHgBD2i+4EKdr22fB2NExN315Q?=
 =?iso-8859-1?Q?t9ow55JGjqBw5A3+nciwXS76rUkGeYLO0K2fRBq1MTI7kHf1MVR9oywNp7?=
 =?iso-8859-1?Q?IH8SsX0o5beELFj2eEPq7wsUuEjKQWrd5GuUhvtjEFkuVa+P4CBVqtJhP7?=
 =?iso-8859-1?Q?bY49CSwKcuwOhKvMBcHKxHdO5XGfjIz4sP3H7mXCE23ZwcZXT+fkQv48cN?=
 =?iso-8859-1?Q?vVOuaxyDE0V/xYWsMpxLyG9crWSCBgbhmXElkjX2BuzmHmIdBCh0moNpvE?=
 =?iso-8859-1?Q?/eHskjVYnvVCYn0T7MPj65fcyhPyleVj8t/Uyebvnsv6dLhjH3xHc9DWgA?=
 =?iso-8859-1?Q?BuXi/UbWtxIfemnAwEDHh+LPHAKVSkbRyKTUwb8n8TYkxZe//ftCm3RhZO?=
 =?iso-8859-1?Q?KWhVhsyPzaxKUqHdmdNvTG/crPkXaow4cOnyMINh3HeR07UC72RtBaxSkJ?=
 =?iso-8859-1?Q?EQXY16JxGpgh5aN9DCKZ9UZ+ilScMPx/9WiKxY5Q?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: solid-run.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4725.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26cae1dc-4a28-428a-1f7b-08db3787e1af
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2023 16:48:14.9097
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a4a8aaf3-fd27-4e27-add2-604707ce5b82
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XEk2dyQLBN45TuF/2zxbqSAnUVCuStbuPR9cD2UoPCvHpd514PSf9euwUJnw71lUSWFH2fwDG+VaIgN2IPSgW+76Fb+k0kON5eA9Q/Lt5/o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8589
X-Spam-Status: No, score=1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > This function is used by virtio_vdpa as well (drivers/virtio/virtio_vdp=
a.c:virtio_vdpa_finalize_features).=0A=
> > A vDPA device can offer this feature and it will be accepted, even thou=
gh VIRTIO_F_NOTIFICATION_DATA is not a thing for the vDPA transport at the =
moment.=0A=
> >=0A=
> > I don't know if this is bad, since offering VIRTIO_F_NOTIFICATION_DATA =
is meaningless for a vDPA device at the moment.=0A=
> >=0A=
> > I submitted a patch adding support for vDPA transport.=0A=
> > https://lore.kernel.org/virtualization/20230402081034.1021886-1-alvaro.=
karsz@solid-run.com/T/#u=0A=
> =0A=
> Hmm.  So it seems we need to first apply yours then this patch,=0A=
> is that right? Or the other way around? What is the right way to make it =
not break bisect?=0A=
=0A=
My patch should be applied on top of Viktor's, it uses one of the functions=
 created by Viktor: vring_notification_data.=0A=
Viktor's patch without mine won't break bisect, it will just accept the fea=
ture for a virtio_vdpa without any meaning.=0A=
=0A=
> Do you mind including this patch with yours in a patchset=0A=
> in the correct order?=0A=
=0A=
Viktor, since you did most of the work here, maybe you want to create the p=
atchset?=0A=
I can do it myself if you prefer so.=0A=
=0A=
Thanks,=0A=
Alvaro=