Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Apr 2023 18:46:16 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Lars-Peter Clausen <lars@metafoo.de>
Cc:     Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] iio: dac: mcp4922: get and enable vdd regulator
Message-ID: <20230407184616.2fd2d52a@jic23-huawei>
In-Reply-To: <ee6a428b-905c-82ac-48fd-0b440d90e014@metafoo.de>
References: <20230405140114.99011-1-frattaroli.nicolas@gmail.com>
        <20230405140114.99011-3-frattaroli.nicolas@gmail.com>
        <ee6a428b-905c-82ac-48fd-0b440d90e014@metafoo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 5 Apr 2023 07:21:00 -0700
Lars-Peter Clausen <lars@metafoo.de> wrote:

> On 4/5/23 07:01, Nicolas Frattaroli wrote:
> > [...]
> > +	state->vdd_reg = devm_regulator_get(&spi->dev, "vdd");
> > +	if (IS_ERR(state->vdd_reg)) {
> > +		ret = dev_err_probe(&spi->dev, PTR_ERR(state->vdd_reg),
> > +				    "vdd regulator not specified\n");
> > +		goto error_disable_vref_reg;
> > +	}
> > +	ret = regulator_enable(state->vdd_reg);
> > +	if (ret) {
> > +		dev_err(&spi->dev, "Failed to enable vdd regulator: %d\n",
> > +			ret);
> > +		goto error_disable_vref_reg;
> > +	}  
> The two above can be combined into `devm_regulator_get_enable()`. This 
> will also take care of automatically disabling the regulator on the 
> error path and on remove.

I'm not keen on the ordering of probe wrt to remove that results from mixing
devm and not.   Note that already happens because of the gets vs enables
so another reason to take this driver fully devm_ based.

Jonathan


> > +
> >   	spi_set_drvdata(spi, indio_dev);
> >   	id = spi_get_device_id(spi);
> >   	indio_dev->info = &mcp4922_info;
> > [...]  
> 
>