Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Apr 2023 19:01:21 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Nuno =?UTF-8?B?U8Oh?= <noname.nuno@gmail.com>
Cc:     Tom Rix <trix@redhat.com>, lars@metafoo.de,
        angelo.dureghello@timesys.com, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: set varaiable max5522_channels
 storage-class-specifier to static
Message-ID: <20230407190121.7dfb598c@jic23-huawei>
In-Reply-To: <ee03cecef9139720a9818aa434dd34ae433d8e9d.camel@gmail.com>
References: <20230404013828.1914523-1-trix@redhat.com>
        <ee03cecef9139720a9818aa434dd34ae433d8e9d.camel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 04 Apr 2023 08:43:32 +0200
Nuno S=C3=A1 <noname.nuno@gmail.com> wrote:

> On Mon, 2023-04-03 at 21:38 -0400, Tom Rix wrote:
> > smatch reports
> > drivers/iio/dac/max5522.c:55:28: warning: symbol
> > =C2=A0 'max5522_channels' was not declared. Should it be static?
> >=20
> > This variable is only used in one file so it should be static.
> >=20
> > Signed-off-by: Tom Rix <trix@redhat.com>
> > --- =20
>=20
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>=20
>=20

Applied to the togreg branch of iio.git (pushed out initially as testing)
with tweak in patch title to fix "variable"

Thanks,

Jonathan