Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230325134503.1335510-1-trix@redhat.com>
In-Reply-To: <20230325134503.1335510-1-trix@redhat.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Fri, 7 Apr 2023 10:52:49 -0700
Message-ID: <CAKwvOdng_wH8qKnnGN=VpUhLK9q6wyc7sZKO7ORt-3QOKVP_nw@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: remove unused matching_stream_ptrs variable
To:     Jimmy.Kizito@amd.com
Cc:     harry.wentland@amd.com, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, nathan@kernel.org, Jun.Lei@amd.com,
        wenjing.liu@amd.com, Cruise.Hung@amd.com,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        Tom Rix <trix@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jimmy, can you review?

The change LGTM; but I'm not sure if there was something else intended here=
.

On Sat, Mar 25, 2023 at 6:45=E2=80=AFAM Tom Rix <trix@redhat.com> wrote:
>
> clang with W=3D1 reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.c:625:6: er=
ror:
>   variable 'matching_stream_ptrs' set but not used [-Werror,-Wunused-but-=
set-variable]
>         int matching_stream_ptrs =3D 0;
>             ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c b/driv=
ers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c
> index 41198c729d90..30c0644d4418 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c
> @@ -622,7 +622,6 @@ bool link_enc_cfg_validate(struct dc *dc, struct dc_s=
tate *state)
>         int i, j;
>         uint8_t valid_count =3D 0;
>         uint8_t dig_stream_count =3D 0;
> -       int matching_stream_ptrs =3D 0;
>         int eng_ids_per_ep_id[MAX_PIPES] =3D {0};
>         int ep_ids_per_eng_id[MAX_PIPES] =3D {0};
>         int valid_bitmap =3D 0;
> @@ -645,9 +644,7 @@ bool link_enc_cfg_validate(struct dc *dc, struct dc_s=
tate *state)
>                 struct link_enc_assignment assignment =3D state->res_ctx.=
link_enc_cfg_ctx.link_enc_assignments[i];
>
>                 if (assignment.valid) {
> -                       if (assignment.stream =3D=3D state->streams[i])
> -                               matching_stream_ptrs++;
> -                       else
> +                       if (assignment.stream !=3D state->streams[i])
>                                 valid_stream_ptrs =3D false;
>                 }
>         }
> --
> 2.27.0
>


--=20
Thanks,
~Nick Desaulniers