Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230330132114.1826399-1-trix@redhat.com>
In-Reply-To: <20230330132114.1826399-1-trix@redhat.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Fri, 7 Apr 2023 11:08:24 -0700
Message-ID: <CAKwvOdkim2tY3VvR_ejCuzVivEH3iadZYFE_dnMS1shXfJ5eUA@mail.gmail.com>
Subject: Re: [PATCH] fs: dlm: remove unused count_match variable
To:     Tom Rix <trix@redhat.com>
Cc:     ccaulfie@redhat.com, teigland@redhat.com, nathan@kernel.org,
        cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 30, 2023 at 6:21=E2=80=AFAM Tom Rix <trix@redhat.com> wrote:
>
> clang with W=3D1 reports
> fs/dlm/dir.c:67:26: error: variable
>   'count_match' set but not used [-Werror,-Wunused-but-set-variable]
>         unsigned int count =3D 0, count_match =3D 0, count_bad =3D 0, cou=
nt_add =3D 0;
>                                 ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>

Fixes: commit c04fecb4d9f7 ("dlm: use rsbtbl as resource directory")
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

I can't help but wonder what this logic originally intended, but this
was introduced back in 2012, so guessing no one cares/remembers/hits
related issues.

The condition above is
149         if (result =3D=3D DLM_LU_MATCH &&
150             nodeid !=3D memb->nodeid) {

which looks like the condition you removed could have been folded into
that originally:

if (result =3D=3D DLM_LU_MATCH) {
  if (nodeid =3D=3D memb->nodeid)
    ++count_match;
  else {
    ...


> ---
>  fs/dlm/dir.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/fs/dlm/dir.c b/fs/dlm/dir.c
> index fb1981654bb2..982f7a5570fe 100644
> --- a/fs/dlm/dir.c
> +++ b/fs/dlm/dir.c
> @@ -64,7 +64,7 @@ int dlm_recover_directory(struct dlm_ls *ls)
>         char *b, *last_name =3D NULL;
>         int error =3D -ENOMEM, last_len, nodeid, result;
>         uint16_t namelen;
> -       unsigned int count =3D 0, count_match =3D 0, count_bad =3D 0, cou=
nt_add =3D 0;
> +       unsigned int count =3D 0, count_bad =3D 0, count_add =3D 0;
>
>         log_rinfo(ls, "dlm_recover_directory");
>
> @@ -158,14 +158,6 @@ int dlm_recover_directory(struct dlm_ls *ls)
>                                                              b, namelen);
>                                 }
>
> -                               /* The name was found in rsbtbl, and the
> -                                * master nodeid matches memb->nodeid. */
> -
> -                               if (result =3D=3D DLM_LU_MATCH &&
> -                                   nodeid =3D=3D memb->nodeid) {
> -                                       count_match++;
> -                               }
> -
>                                 /* The name was not found in rsbtbl and w=
as
>                                  * added with memb->nodeid as the master.=
 */
>
> --
> 2.27.0
>


--=20
Thanks,
~Nick Desaulniers