Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Apr 2023 20:15:00 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     "Radu Pirea (OSS)" <radu-nicolae.pirea@oss.nxp.com>
Cc:     hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH net] net: phy: nxp-c45-tja11xx: add remove callback
Message-ID: <b9bd7373-f544-45fc-be3b-736d20f0841a@lunn.ch>
References: <20230406095904.75456-1-radu-nicolae.pirea@oss.nxp.com>
 <cf1dd1a9-2e2d-473e-89f0-8e2c51226dfe@lunn.ch>
 <104c1190-cd18-d7c9-7b27-af367ac539bb@oss.nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <104c1190-cd18-d7c9-7b27-af367ac539bb@oss.nxp.com>
Precedence: bulk

> > Do you need to disable interrupts? I suppose the real question is, is
> > it guaranteed phy_disconnect() is called before the driver is removed?
> The MAC driver should call phy_disconnect() when it is removed. Also, the
> user should not be able to remove the PHY driver if is in uses.

That was what i was thinking. But i've never unloaded a PHY driver, so
i've no idea what actually happens.

     Andrew