Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
        Nick Terrell <terrelln@fb.com>
Cc:     Yangtao Li <frank.li@vivo.com>,
        linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: [PATCH v3] f2fs: add sanity compress level check for compressed file
Date:   Sat,  8 Apr 2023 02:31:47 +0800
Message-Id: <20230407183148.23231-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RlVuF9Da+txS8lj9dukDV4WwmX4oihhIgI9VkmRogmuYTFv1zSZfekOCG4ir?=
 =?us-ascii?Q?lNU4Wzzun9moGsNl/h9KVV2QbLAVMh0UpXR6Be//Lc4JJb3ewx3MDXOkmyIb?=
 =?us-ascii?Q?IfUzaKJzqCFJIUi02B7P8ZVt3hJTMZiqMQu0QXwJ6kDy9XzUzi6mYZdPsJCX?=
 =?us-ascii?Q?t0qwZ5QSmzp2fYjbOHlzExE/UP7aLbcx1hsPJveDF9H2KoWf9w1ZJiMrKRPB?=
 =?us-ascii?Q?KGegcyJAmdjDx1kc99m8QptPbpUhtCQoP4bE37YuX7DWObfOCstim6djZRXB?=
 =?us-ascii?Q?ye+thZ39+HgFjfNTe9NQaNzS89pCdZ+dX5nG8M+CSeQt8WieIpYgDkFAz19y?=
 =?us-ascii?Q?4vRULkrDQC9x13Wd9oRAaVqVxPC+hX6eUKJNCGgwJkgYoAAcxDNVoJs577xl?=
 =?us-ascii?Q?SYgLnJn/LyRLagT+k+b9NRmrpEHeI/rjGLnJKc8y7TflUCHToRkG4CB0r5Cu?=
 =?us-ascii?Q?tieBlsTPkzwEKRZV5F8Bm2+u54WD4FqexTjYeltYI0B7FjQEBitHCSBCf8ir?=
 =?us-ascii?Q?Hps31nJLKzMUROJP8XJFNN3+pq9fAWhRBe9cR1aEpi2gOhgQsQeaoH2m/ynT?=
 =?us-ascii?Q?B6AV3MYxche7w7itCGXd7lN3XUqDieTf6BkbZ+0Q12ZCaNk1cQSeu/575D/S?=
 =?us-ascii?Q?BltPmVasI19iD81g199mVW5vqpb5KtNjI7siW/CMoI6CoWKGaBo4PkBwTKLE?=
 =?us-ascii?Q?JrLODEarqp65seOp4uL2WTdHu/MBO7sh+/44Ue23pBHnSkeoQ2yQvembTAb8?=
 =?us-ascii?Q?RpYV5Kh1gXEPSG21bJEGg8wHV8nllBEO0c8IwDlLHfW47pusl+w5H3RBALmN?=
 =?us-ascii?Q?rykJa8O846hXjf7uh4VoFMG+BQMlQPm4yESHYVG79Gw3sj+zXZUV91Lp+Jzs?=
 =?us-ascii?Q?qIBISrFLSqztJh2qSuKMrkWVrV3YEBZnzktC5sqv/Lf5OJJ7bjMX0Nu4tsU7?=
 =?us-ascii?Q?MFkacFfuh+P+Op3/EAWtskEweFU2nX+WzVXcyhGqWGSlN3f56844mZATLjfP?=
 =?us-ascii?Q?1qkvpb+nJ3+lBXqdSztOtcHXTSs2aigmF8eJMepvjwLmmdaJay1jP3hzimkH?=
 =?us-ascii?Q?yXKw7aMJOXkQRe0yNgolmaKE8iM09TFfGviYSgnpigPtPVK7tGIonPSpge22?=
 =?us-ascii?Q?YDPwOwHos+2bcqrPcVbLmkZfbnVSL6AdLhgiaDFT1EqVsNNLDSxXeKfFeaVj?=
 =?us-ascii?Q?Pm+7qBHIWfDpNPkwqiqVg80qg8RfAsqciaJFNEDJlkmDhLA6x+AHBaHTiLUA?=
 =?us-ascii?Q?ydKpQPpyFDoYL2OBbfHC7vOa8u7WYrLZmHsYfI/iBfoHNcSNEhweFm8Wo+ky?=
 =?us-ascii?Q?b42azPyEzhaLGoukXzY66RFec30cPjr25m+OiHZ/Vt9PKyyqtXAKs53XTWc6?=
 =?us-ascii?Q?S/OxcGY0lcH9IdAYDNotsCye/WWwb5c2m2UdQJzxfBaSToHaBchHfVmwiVYN?=
 =?us-ascii?Q?J9MZExRmEbrcWnib0GVHCDt/3QPzD0rhnz8e0KE5bLh6rvCBEv2YxhMTE+EZ?=
 =?us-ascii?Q?lAAmX3vBxNk5dJ7OjiPGKH+X8FLplXMTNLJngyIvcrtg1OjpPNGLtwUGwCvy?=
 =?us-ascii?Q?CICCxyepGTxu0t7wfLUC4LWCQxW20/H2VBD3sqUt?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 379769f4-b8fc-47ee-ac64-08db37965ee6
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2023 18:31:58.1186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WIn7KQB1yrwM+Zu6HGQCkiAUsKI7dkEJnpcFqTO0vpMVPt6YT2BTZ9E9ylcPsx3W7weX4yU5wwCJYLrRcpcONg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5225
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Commit 3fde13f817e2 ("f2fs: compress: support compress level")
forgot to do basic compress level check, let's add it.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/f2fs/inode.c | 106 +++++++++++++++++++++++++++++++++++-------------
 1 file changed, 77 insertions(+), 29 deletions(-)

diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
index bb5b365a195d..c2460f51bf80 100644
--- a/fs/f2fs/inode.c
+++ b/fs/f2fs/inode.c
@@ -10,6 +10,8 @@
 #include <linux/buffer_head.h>
 #include <linux/writeback.h>
 #include <linux/sched/mm.h>
+#include <linux/lz4.h>
+#include <linux/zstd.h>
 
 #include "f2fs.h"
 #include "node.h"
@@ -202,6 +204,79 @@ void f2fs_inode_chksum_set(struct f2fs_sb_info *sbi, struct page *page)
 	ri->i_inode_checksum = cpu_to_le32(f2fs_inode_chksum(sbi, page));
 }
 
+static bool sanity_check_compress_inode(struct inode *inode,
+			struct f2fs_inode *ri)
+{
+	struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
+	unsigned char compress_level;
+
+	if (ri->i_compress_algorithm >= COMPRESS_MAX) {
+		f2fs_warn(sbi,
+			"%s: inode (ino=%lx) has unsupported compress algorithm: %u, run fsck to fix",
+			__func__, inode->i_ino, ri->i_compress_algorithm);
+		goto err;
+	}
+	if (le64_to_cpu(ri->i_compr_blocks) >
+			SECTOR_TO_BLOCK(inode->i_blocks)) {
+		f2fs_warn(sbi,
+			"%s: inode (ino=%lx) has inconsistent i_compr_blocks:%llu, i_blocks:%llu, run fsck to fix",
+			__func__, inode->i_ino, le64_to_cpu(ri->i_compr_blocks),
+			SECTOR_TO_BLOCK(inode->i_blocks));
+		goto err;
+	}
+	if (ri->i_log_cluster_size < MIN_COMPRESS_LOG_SIZE ||
+		ri->i_log_cluster_size > MAX_COMPRESS_LOG_SIZE) {
+		f2fs_warn(sbi,
+			"%s: inode (ino=%lx) has unsupported log cluster size: %u, run fsck to fix",
+			__func__, inode->i_ino, ri->i_log_cluster_size);
+		goto err;
+	}
+
+	compress_level = le16_to_cpu(ri->i_compress_flag) >>
+				COMPRESS_LEVEL_OFFSET;
+	switch (ri->i_compress_algorithm) {
+	case COMPRESS_LZO:
+#ifdef CONFIG_F2FS_FS_LZO
+		if (compress_level)
+			goto err_level;
+#endif
+		break;
+	case COMPRESS_LZORLE:
+#ifdef CONFIG_F2FS_FS_LZORLE
+		if (compress_level)
+			goto err_level;
+#endif
+		break;
+	case COMPRESS_LZ4:
+#ifdef CONFIG_F2FS_FS_LZ4
+#ifdef CONFIG_F2FS_FS_LZ4HC
+		if ((compress_level && compress_level < LZ4HC_MIN_CLEVEL) ||
+				compress_level > LZ4HC_MAX_CLEVEL)
+#else
+		if (compress_level)
+#endif
+			goto err_level;
+#endif
+		break;
+	case COMPRESS_ZSTD:
+#ifdef CONFIG_F2FS_FS_ZSTD
+		if (!compress_level || compress_level > zstd_max_clevel())
+			goto err_level;
+#endif
+		break;
+	default:
+		goto err_level;
+	}
+
+	return true;
+err_level:
+	f2fs_warn(sbi, "%s: inode (ino=%lx) has unsupported compress level: %u, run fsck to fix",
+		  __func__, inode->i_ino, compress_level);
+err:
+	set_sbi_flag(sbi, SBI_NEED_FSCK);
+	return false;
+}
+
 static bool sanity_check_inode(struct inode *inode, struct page *node_page)
 {
 	struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
@@ -286,35 +361,8 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page)
 	if (f2fs_has_extra_attr(inode) && f2fs_sb_has_compression(sbi) &&
 			fi->i_flags & F2FS_COMPR_FL &&
 			F2FS_FITS_IN_INODE(ri, fi->i_extra_isize,
-						i_log_cluster_size)) {
-		if (ri->i_compress_algorithm >= COMPRESS_MAX) {
-			set_sbi_flag(sbi, SBI_NEED_FSCK);
-			f2fs_warn(sbi, "%s: inode (ino=%lx) has unsupported "
-				"compress algorithm: %u, run fsck to fix",
-				  __func__, inode->i_ino,
-				  ri->i_compress_algorithm);
-			return false;
-		}
-		if (le64_to_cpu(ri->i_compr_blocks) >
-				SECTOR_TO_BLOCK(inode->i_blocks)) {
-			set_sbi_flag(sbi, SBI_NEED_FSCK);
-			f2fs_warn(sbi, "%s: inode (ino=%lx) has inconsistent "
-				"i_compr_blocks:%llu, i_blocks:%llu, run fsck to fix",
-				  __func__, inode->i_ino,
-				  le64_to_cpu(ri->i_compr_blocks),
-				  SECTOR_TO_BLOCK(inode->i_blocks));
-			return false;
-		}
-		if (ri->i_log_cluster_size < MIN_COMPRESS_LOG_SIZE ||
-			ri->i_log_cluster_size > MAX_COMPRESS_LOG_SIZE) {
-			set_sbi_flag(sbi, SBI_NEED_FSCK);
-			f2fs_warn(sbi, "%s: inode (ino=%lx) has unsupported "
-				"log cluster size: %u, run fsck to fix",
-				  __func__, inode->i_ino,
-				  ri->i_log_cluster_size);
-			return false;
-		}
-	}
+						i_log_cluster_size))
+		return sanity_check_compress_inode(inode, ri);
 
 	return true;
 }
-- 
2.35.1