Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1213432rwl; Fri, 7 Apr 2023 11:44:43 -0700 (PDT) X-Google-Smtp-Source: AKy350bn67/buU779yrlz3SEXhJ6nLZKkxevhqYZo4gw99cTIIdJky8VWOEbNumG+OFezDvGPOsR X-Received: by 2002:a17:907:9609:b0:8bf:e95c:467b with SMTP id gb9-20020a170907960900b008bfe95c467bmr459650ejc.63.1680893083004; Fri, 07 Apr 2023 11:44:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680893082; cv=none; d=google.com; s=arc-20160816; b=PoiogX71evo/U0ZYgzJNCZkf3YvOlue0CvE7S6rtFTo+u77eQDZifnLz5G7LEMjPq5 OXj0JsBWJIJOA5NlB6NEDfP6Eu6x8CLVqygQnNl6cESDRnYnkbIzRRdaol6uOiaVpczf tp4JBRq7FsiKZ2vQypD7MC7wQo+JCpej6uElpyk0UM3xsUFuSNkBZI1/wlLfEihAQIGc C8eSzMNm8HwgLdoPE4/gBBYUhFRzf2vv7T+hcctDPzG6evSWY2bTHcGS1lFQSpt9OzGH BBXdjeh31zU3k4/xXVE273cWUUX8L011pGlFFRvcTBdPPYUi/SFNJMr3Sz8YOWJSIJ2E 23Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=3oRwt6N4ADa78EEH+o6Pc1K4R7YlHGK3pUj1aovOcq4=; b=E4EAPREGw6WVu6XDrORpvIxNQoZacGiqv+rTr88aBz11CL1clY3xJhVTCW3obe1uut cEJVuKl634fRHMsaVkYUUl6rWNLfc8cnycaiB9o3SlwIzhptFkOLRpKDat8SuwnXx17Y eiMBkXYePvCVnxkKlWqSrumMPtRWkVzsYg1dv/6LD7T2Vq1aweN5Ru6kImZKn1EVPLOY r2rHqApBKLftAifbc68egNCDdMMToftW6tvBe57bQqtduL0qJqKyBpVVR61Iul501/RD JWcqo6SAdJvFhbQCHkOEzHytTBaOiwOo/0SgkCegg4rxIHh9rhlQffUjaFYaTQ/2oC0V JMcg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sb2-20020a170906edc200b008dd83608278si3786339ejb.933.2023.04.07.11.44.18; Fri, 07 Apr 2023 11:44:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229848AbjDGSlp (ORCPT + 99 others); Fri, 7 Apr 2023 14:41:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbjDGSlo (ORCPT ); Fri, 7 Apr 2023 14:41:44 -0400 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E04E0A27B; Fri, 7 Apr 2023 11:41:43 -0700 (PDT) Received: by mail-pl1-f175.google.com with SMTP id q2so4553093pll.7; Fri, 07 Apr 2023 11:41:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680892903; x=1683484903; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3oRwt6N4ADa78EEH+o6Pc1K4R7YlHGK3pUj1aovOcq4=; b=BYlLjGct7FTDQdPy7SYv8wL32dfvMWGrWukpge0DOHBK7o4Es5RbFKEUTTHWK1uIxw 0ZBDghJA97ZyCiTgoXmG302oyuR87ALdt2KW2rCUB5xle/Ijfjn7bb2WFExyWH8WOiL6 kUJGDlhb5MAMJ9luI9EN5BssivioSwzFkc5w4OpJGeP5GIniPaYlMfMYceA+KvlhtW1S sN5vsQdrnh8yBBPRXryL68wfa8IHLg4SKi89MF4dfZ60cko8Mvwwq1onn6CEsYwH0WuI W6CWR9ibxbeKqwRbpPdYYKW45dYg44/IFYkp/jBRGeGTVV5KMMbwT1L29CyDcEsgTHM1 cPzw== X-Gm-Message-State: AAQBX9djcmeYiU/57zv5SZOYddRVEzfbnDf3tXuFPwXIJmzPYNndE5JG UWfa7aeZHRR1+s90GOAh2kI= X-Received: by 2002:a05:6a20:4f27:b0:dd:ee39:5e90 with SMTP id gi39-20020a056a204f2700b000ddee395e90mr2655675pzb.23.1680892903272; Fri, 07 Apr 2023 11:41:43 -0700 (PDT) Received: from ?IPV6:2620:15c:211:201:f2c:4ac2:6000:5900? ([2620:15c:211:201:f2c:4ac2:6000:5900]) by smtp.gmail.com with ESMTPSA id u16-20020aa78490000000b00628e9871c24sm3342377pfn.183.2023.04.07.11.41.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 11:41:42 -0700 (PDT) Message-ID: Date: Fri, 7 Apr 2023 11:41:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 0/3] blk-cgroup: some cleanup Content-Language: en-US To: Chengming Zhou , axboe@kernel.dk, tj@kernel.org Cc: paolo.valente@linaro.org, josef@toxicpanda.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230406145050.49914-1-zhouchengming@bytedance.com> From: Bart Van Assche In-Reply-To: <20230406145050.49914-1-zhouchengming@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/6/23 07:50, Chengming Zhou wrote: > These are some cleanup patches of blk-cgroup. Thanks for review. With these patches applied, my kernel test VM crashes during boot. The following crash disappears if I revert these patches: BUG: KASAN: null-ptr-deref in bio_associate_blkg_from_css+0x83/0x240 Read of size 8 at addr 0000000000000518 by task blkid/5885 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.0-debian-1.16.0-5 04/01/2014 Call Trace: dump_stack_lvl+0x4a/0x80 print_report+0x21e/0x260 kasan_report+0xc2/0xf0 __asan_load8+0x69/0x90 bio_associate_blkg_from_css+0x83/0x240 bfq_bio_bfqg+0xce/0x120 [bfq] bfq_bic_update_cgroup+0x2f/0x3c0 [bfq] bfq_init_rq+0x1e8/0xb10 [bfq] bfq_insert_request.isra.0+0xa3/0x420 [bfq] bfq_insert_requests+0xca/0xf0 [bfq] blk_mq_dispatch_rq_list+0x4c0/0xb00 __blk_mq_sched_dispatch_requests+0x15e/0x200 blk_mq_sched_dispatch_requests+0x8b/0xc0 __blk_mq_run_hw_queue+0x3ff/0x500 __blk_mq_delay_run_hw_queue+0x23a/0x300 blk_mq_run_hw_queue+0x14e/0x350 blk_mq_sched_insert_request+0x181/0x1f0 blk_execute_rq+0xf4/0x300 scsi_execute_cmd+0x23e/0x350 sr_do_ioctl+0x173/0x3d0 [sr_mod] sr_packet+0x60/0x90 [sr_mod] cdrom_get_track_info.constprop.0+0x125/0x170 [cdrom] cdrom_get_last_written+0x1d4/0x2d0 [cdrom] mmc_ioctl_cdrom_last_written+0x85/0x120 [cdrom] mmc_ioctl+0x10b/0x1d0 [cdrom] cdrom_ioctl+0xa66/0x1270 [cdrom] sr_block_ioctl+0xee/0x130 [sr_mod] blkdev_ioctl+0x1bb/0x3f0 __x64_sys_ioctl+0xc7/0xe0 do_syscall_64+0x34/0x80 entry_SYSCALL_64_after_hwframe+0x46/0xb0 Bart.