Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1214967rwl; Fri, 7 Apr 2023 11:46:26 -0700 (PDT) X-Google-Smtp-Source: AKy350ZdmFWGbXQIdodbELPUFtbTfIsRLwn0jSIQyXWcxd1ez5VOQ4fXxDCmXAwUKWS1PBwdW9oU X-Received: by 2002:a05:6402:1043:b0:4fe:9689:96bb with SMTP id e3-20020a056402104300b004fe968996bbmr3173769edu.35.1680893186479; Fri, 07 Apr 2023 11:46:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680893186; cv=none; d=google.com; s=arc-20160816; b=iU41rte3fReGYSX9i3H5OFVAiHUr6cmz0fO2HqbVQ4SKMj8oIwzyPdvLI8ghJ6DW05 Ih8pCd6Dd1NZCe6k8JuyMr24g+u2nB9UjZtSw9N3GKHB9TQgoXRl2fzN4XzJ/WsPLT0u i/3M5vX22zTHvxNRiurpQyMarBVshS8dpU7Q2pQKKdGg6Rjwte+jSSuCk+CmAoPaBWBW 4r1EeiQYyDbTHCHah0cfuI6tFFJWToJKnMz33rY4b/xMPpAMNAcU8bNcOPaG81tc1fs/ teAJKzRvfZElzs/PwLwv0/xUXoIlXYRG3waOQIMXcY97Tc0jeQnZ/+JcfYzeR6tjhr3l tw/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Kzuwp9uE5sEsN7zJHJeiz67QAe8Oc4s0UD0YCNSdM5U=; b=VU5fcR74akoUUwG4okrUzW2Z3luN3FkgbrVVU1oQAWo1dUN0bp8SKLU2Shu+Fe7O/z /SlPA2kSVf9FMiCO1mgPW/pGHejVutpFcsX54ChjfgMthwW/9ceRN1USA/bChYz4kRLN P2b7Q4/OrcmEgpac2YOn9JxG9jwj7W2cSwK/Is8C8sPz/aiAfXQuULR8GmshJpSWyvOj 3Ljb1Puc6u96VM/0OQ/8CU7x61c0de5Pd82lwl3DoRrztvzwzkCZCFieXqxvp9JvAm8f lO3TkUG5YJlL3AGxXFM/81WZZudwdlz9emM6jcPKTWOjh94KH+B5XYButgn6D4nfv/+4 84gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=O3+MoV6c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x9-20020aa7d389000000b004fd1ee1380fsi101606edq.612.2023.04.07.11.46.01; Fri, 07 Apr 2023 11:46:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=O3+MoV6c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230206AbjDGSo6 (ORCPT + 99 others); Fri, 7 Apr 2023 14:44:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbjDGSo4 (ORCPT ); Fri, 7 Apr 2023 14:44:56 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50725B742 for ; Fri, 7 Apr 2023 11:44:55 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-2465d8792fcso27690a91.0 for ; Fri, 07 Apr 2023 11:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; t=1680893095; x=1683485095; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Kzuwp9uE5sEsN7zJHJeiz67QAe8Oc4s0UD0YCNSdM5U=; b=O3+MoV6cDmmkPk7W8AJ/froinsO6LnGDj+Z5hsCYMGsWXJkNFNjt/nsjhnZg8+4tI0 QIrEe1yOg43xQeckg1TGUnwXZa1/PnaY1t00UhDiWa2jXuLWvjMXFEgXly1N1Yt7aE6V jf8xC6fLILmQ374PFSo9Kn02mz10UvYv67tQrJMg+nXNykneGweIkXs6t3v7qLeY3kjX ILL22YyeQZft7KFN/VKBwR+h326O/A3Pr5c3Fjb0XJVRtQXMKvlvS5/2PBKuhFNg/RsT wi1sm10f2dlsbhbFwvZYnDisSUWfifJO1EY/WMx7nLmjkthQbgK1MmDA6byqNJB7BhcA YZVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680893095; x=1683485095; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kzuwp9uE5sEsN7zJHJeiz67QAe8Oc4s0UD0YCNSdM5U=; b=dmGOxG2aHI2jn67lsiIQl6iQ4znERUrFaYOwZxq9T5Sb9YFFG5tXWfDSRRk9cZ8qUG KwMQtlaGGaSix2hizwCPUnoBYRxCoeHxE0IVerqTDiacr1/N3KY3ktbiWKWy9DgIRNKN QSsboXXDSEA5WsQ2s97zwHSv+nYYdNQDak4K6xSpiaLNBfS4lzngEZAOfS3duHq9Ku+R ZsgH0buDcIHjlRLrilDSSKKWblAma+vOrbhlokYq5AgMXBIIMlM1G8JsC/drrltfkFaw xu4AOhtYyfnTEdl/kAFIBNiRVQVhZi/cui463qsHjgP6IBN3W2bPRLVgBFnNVD+BFn7/ +k1Q== X-Gm-Message-State: AAQBX9cVMLUu3SrWx0tXOUH0w8qP7Nfm6ksmGlyetb8+sA2jSsqA++EE N4As2o0DkgHxxLma0MN1rYj6tQ== X-Received: by 2002:a05:6a00:414a:b0:627:fe88:a2e with SMTP id bv10-20020a056a00414a00b00627fe880a2emr3687157pfb.0.1680893094614; Fri, 07 Apr 2023 11:44:54 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id r20-20020a62e414000000b0058d92d6e4ddsm3381979pfh.5.2023.04.07.11.44.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 11:44:54 -0700 (PDT) Message-ID: <1416b648-188f-873a-08b3-c8e8494ab1a7@kernel.dk> Date: Fri, 7 Apr 2023 12:44:52 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 0/3] blk-cgroup: some cleanup Content-Language: en-US To: Bart Van Assche , Chengming Zhou , tj@kernel.org Cc: paolo.valente@linaro.org, josef@toxicpanda.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230406145050.49914-1-zhouchengming@bytedance.com> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/7/23 12:41 PM, Bart Van Assche wrote: > On 4/6/23 07:50, Chengming Zhou wrote: >> These are some cleanup patches of blk-cgroup. Thanks for review. > > With these patches applied, my kernel test VM crashes during boot. The following crash disappears if I revert these patches: > > BUG: KASAN: null-ptr-deref in bio_associate_blkg_from_css+0x83/0x240 Would be useful in the report to know where that is, as it doesn't include the code output. -- Jens Axboe