Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <caca6879210940428e0aa2a1496907ab@AcuMS.aculab.com>
 <CAHk-=whd4w2wu13O9b5VRKE1b3MoUk89Q_WzhELyqXGAKmfqmQ@mail.gmail.com> <dd933c50df674dd69f6e630a53cfee77@AcuMS.aculab.com>
In-Reply-To: <dd933c50df674dd69f6e630a53cfee77@AcuMS.aculab.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Fri, 7 Apr 2023 12:26:26 -0700
Message-ID: <CAHk-=whA+n+9_AzzPaoxMDgh9YHvif+LC0ZhFuUg-qED=oynHQ@mail.gmail.com>
Subject: Re: revert bab65e48cb064 PCI/MSI Sanitize MSI-X checks
To:     David Laight <David.Laight@aculab.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Christoph Hellwig <hch@infradead.org>
Content-Type: multipart/mixed; boundary="0000000000005514f705f8c401d3"
Precedence: bulk

--0000000000005514f705f8c401d3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 7, 2023 at 5:25=E2=80=AFAM David Laight <David.Laight@aculab.co=
m> wrote:
>
> I think it depends on why the driver is asking for more
> interrupts than the hardware supports.
> Potentially the driver could do:
>         for (i =3D 0; i < 8; i++)
>                 msix_tbl[i].entry =3D 2 * i;
> if the hardware supports 8 interrupts perhaps it
> should return 4?

Hmm.

Something like this might get that case right too. Again - entirely
untested, but looks superficially sane to me.

It just returns how many of the msix_entry[] entries can be used (or
negative for error). So then the (only) caller can just say "is that
still enough for what we required". Seems reasonable, and would get
that non-contiguous case right, I think.

Thomas?

I'm going to drop this and assume I'll get a pull from you with what
you consider the proper fix, but since I was looking at this anyway, I
decided I might as well send out this RFC patch.

                Linus

--0000000000005514f705f8c401d3
Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff"
Content-Disposition: attachment; filename="patch.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_lg6xtwmq0>
X-Attachment-Id: f_lg6xtwmq0

IGRyaXZlcnMvcGNpL21zaS9tc2kuYyB8IDMwICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0t
LQogMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQoKZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvcGNpL21zaS9tc2kuYyBiL2RyaXZlcnMvcGNpL21zaS9tc2kuYwpp
bmRleCAxZjcxNjYyNGNhNTYuLmQxNTFiZGU4YjhlMCAxMDA2NDQKLS0tIGEvZHJpdmVycy9wY2kv
bXNpL21zaS5jCisrKyBiL2RyaXZlcnMvcGNpL21zaS9tc2kuYwpAQCAtNzUwLDMyICs3NTAsMzMg
QEAgc3RhdGljIGludCBtc2l4X2NhcGFiaWxpdHlfaW5pdChzdHJ1Y3QgcGNpX2RldiAqZGV2LCBz
dHJ1Y3QgbXNpeF9lbnRyeSAqZW50cmllcywKIAlyZXR1cm4gcmV0OwogfQogCi1zdGF0aWMgYm9v
bCBwY2lfbXNpeF92YWxpZGF0ZV9lbnRyaWVzKHN0cnVjdCBwY2lfZGV2ICpkZXYsIHN0cnVjdCBt
c2l4X2VudHJ5ICplbnRyaWVzLAotCQkJCSAgICAgIGludCBudmVjLCBpbnQgaHdzaXplKQorc3Rh
dGljIGludCBwY2lfbXNpeF92YWxpZGF0ZV9lbnRyaWVzKHN0cnVjdCBwY2lfZGV2ICpkZXYsIHN0
cnVjdCBtc2l4X2VudHJ5ICplbnRyaWVzLAorCQkJCSAgICAgaW50IG52ZWMsIGludCBod3NpemUp
CiB7CiAJYm9vbCBub2dhcDsKLQlpbnQgaSwgajsKKwlpbnQgbWF4dmVjOwogCiAJaWYgKCFlbnRy
aWVzKQotCQlyZXR1cm4gdHJ1ZTsKKwkJcmV0dXJuIG52ZWM7CiAKIAlub2dhcCA9IHBjaV9tc2lf
ZG9tYWluX3N1cHBvcnRzKGRldiwgTVNJX0ZMQUdfTVNJWF9DT05USUdVT1VTLCBERU5ZX0xFR0FD
WSk7CiAKLQlmb3IgKGkgPSAwOyBpIDwgbnZlYzsgaSsrKSB7CisJbWF4dmVjID0gLUVJTlZBTDsK
Kwlmb3IgKGludCBpID0gMDsgaSA8IG52ZWM7IGkrKykgewogCQkvKiBFbnRyeSB3aXRoaW4gaGFy
ZHdhcmUgbGltaXQ/ICovCi0JCWlmIChlbnRyaWVzW2ldLmVudHJ5ID49IGh3c2l6ZSkKLQkJCXJl
dHVybiBmYWxzZTsKKwkJaWYgKGVudHJpZXNbaV0uZW50cnkgPCBod3NpemUpCisJCQltYXh2ZWMg
PSBpKzE7CiAKIAkJLyogQ2hlY2sgZm9yIGR1cGxpY2F0ZSBlbnRyaWVzICovCi0JCWZvciAoaiA9
IGkgKyAxOyBqIDwgbnZlYzsgaisrKSB7CisJCWZvciAoaW50IGogPSBpICsgMTsgaiA8IG52ZWM7
IGorKykgewogCQkJaWYgKGVudHJpZXNbaV0uZW50cnkgPT0gZW50cmllc1tqXS5lbnRyeSkKLQkJ
CQlyZXR1cm4gZmFsc2U7CisJCQkJcmV0dXJuIC1FSU5WQUw7CiAJCX0KIAkJLyogQ2hlY2sgZm9y
IHVuc3VwcG9ydGVkIGdhcHMgKi8KIAkJaWYgKG5vZ2FwICYmIGVudHJpZXNbaV0uZW50cnkgIT0g
aSkKLQkJCXJldHVybiBmYWxzZTsKKwkJCXJldHVybiAtRUlOVkFMOwogCX0KLQlyZXR1cm4gdHJ1
ZTsKKwlyZXR1cm4gbWF4dmVjOwogfQogCiBpbnQgX19wY2lfZW5hYmxlX21zaXhfcmFuZ2Uoc3Ry
dWN0IHBjaV9kZXYgKmRldiwgc3RydWN0IG1zaXhfZW50cnkgKmVudHJpZXMsIGludCBtaW52ZWMs
CkBAIC04MDUsOCArODA2LDExIEBAIGludCBfX3BjaV9lbmFibGVfbXNpeF9yYW5nZShzdHJ1Y3Qg
cGNpX2RldiAqZGV2LCBzdHJ1Y3QgbXNpeF9lbnRyeSAqZW50cmllcywgaW50CiAJaWYgKGh3c2l6
ZSA8IDApCiAJCXJldHVybiBod3NpemU7CiAKLQlpZiAoIXBjaV9tc2l4X3ZhbGlkYXRlX2VudHJp
ZXMoZGV2LCBlbnRyaWVzLCBudmVjLCBod3NpemUpKQotCQlyZXR1cm4gLUVJTlZBTDsKKwludmVj
ID0gcGNpX21zaXhfdmFsaWRhdGVfZW50cmllcyhkZXYsIGVudHJpZXMsIG52ZWMsIGh3c2l6ZSk7
CisJaWYgKG52ZWMgPCAwKQorCQlyZXR1cm4gbnZlYzsKKwlpZiAobnZlYyA8IG1pbnZlYykKKwkJ
cmV0dXJuIC1FTk9TUEM7CiAKIAlpZiAoaHdzaXplIDwgbnZlYykgewogCQkvKiBLZWVwIHRoZSBJ
UlEgdmlydHVhbCBoYWNrZXJ5IHdvcmtpbmcgKi8K
--0000000000005514f705f8c401d3--