Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <248ec330-b4c3-aa7b-61eb-69ce8d333b69@gmail.com>
Date:   Fri, 7 Apr 2023 23:02:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: [BUG] staging: rtl8192e: W_DISABLE# does not work after stop/start
Content-Language: en-US
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <39dc735c-fd6d-e405-856c-788a52704d63@gmail.com>
In-Reply-To: <39dc735c-fd6d-e405-856c-788a52704d63@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

When loading the driver for rtl8192e, the W_DISABLE# switch is working 
as intended. But when the WLAN is turned off in software and then turned 
on again the W_DISABLE# does not work anymore.

Reason for this is that in the function _rtl92e_dm_check_rf_ctrl_gpio()
checking this every two seconds is an conditional return.

	if (priv->bfirst_after_down) {
		priv->bfirst_after_down = true; // PH: useless line
		return;
	}

	tmp1byte = rtl92e_readb(dev, GPI); // PH: GPI for W_DISABLE#

bfirst_after_down is set true when switching the WLAN off in software. 
But it is not set to false again when WLAN is turned on again.

Thanks for your support.

Bye Philipp