Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <58305f4d-fbcb-44cc-053c-d30f4ca082e7@quicinc.com>
Date:   Fri, 7 Apr 2023 15:35:49 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH 0/2] rpmsg: glink: Wait for intent after intent request
Content-Language: en-US
To:     Bjorn Andersson <quic_bjorande@quicinc.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>
CC:     <linux-arm-msm@vger.kernel.org>,
        <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230327144617.3134175-1-quic_bjorande@quicinc.com>
From:   Chris Lew <quic_clew@quicinc.com>
In-Reply-To: <20230327144617.3134175-1-quic_bjorande@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 3/27/2023 7:46 AM, Bjorn Andersson wrote:
> When written it was assumed that upon requesting an intent, the intent
> would arrive followed by an intent request acknowledgement. But this is
> not always the case, in which case the current implementation would
> request yet another intent and when that is acknowledged find the first
> received intent - if the remote didn't run out of memory and failed the
> second request...
> 
> Bjorn Andersson (2):
>    rpmsg: glink: Transition intent request signaling to wait queue
>    rpmsg: glink: Wait for intent, not just request ack
> 
>   drivers/rpmsg/qcom_glink_native.c | 37 ++++++++++++++++++++++---------
>   1 file changed, 26 insertions(+), 11 deletions(-)
> 

Reviewed-by: Chris Lew <quic_clew@quicinc.com>