Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bcf9a62b87e4d46cabfe7d751882527b10b6b401.camel@redhat.com>
Subject: Re: [Nouveau] [PATCH] drm/nouveau/fb: add missing sysmen flush
 callbacks
From:   Lyude Paul <lyude@redhat.com>
To:     Karol Herbst <kherbst@redhat.com>, linux-kernel@vger.kernel.org
Cc:     nouveau@lists.freedesktop.org, Ben Skeggs <bskeggs@redhat.com>,
        dri-devel@lists.freedesktop.org
Date:   Fri, 07 Apr 2023 19:15:15 -0400
In-Reply-To: <20230405110455.1368428-1-kherbst@redhat.com>
References: <20230405110455.1368428-1-kherbst@redhat.com>
Organization: Red Hat Inc.
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

Reviewed-by: Lyude Paul <lyude@redhat.com>

On Wed, 2023-04-05 at 13:04 +0200, Karol Herbst wrote:
> Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/203
> Fixes: 5728d064190e1 ("drm/nouveau/fb: handle sysmem flush page from comm=
on code")
> Signed-off-by: Karol Herbst <kherbst@redhat.com>
> ---
>  drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c | 1 +
>  drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c | 1 +
>  drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c | 1 +
>  drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c | 1 +
>  4 files changed, 4 insertions(+)
>=20
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c b/drivers/gpu=
/drm/nouveau/nvkm/subdev/fb/gf108.c
> index 76678dd60f93f..c4c6f67af7ccc 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c
> @@ -31,6 +31,7 @@ gf108_fb =3D {
>  	.init =3D gf100_fb_init,
>  	.init_page =3D gf100_fb_init_page,
>  	.intr =3D gf100_fb_intr,
> +	.sysmem.flush_page_init =3D gf100_fb_sysmem_flush_page_init,
>  	.ram_new =3D gf108_ram_new,
>  	.default_bigpage =3D 17,
>  };
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c b/drivers/gpu=
/drm/nouveau/nvkm/subdev/fb/gk104.c
> index f73442ccb424b..433fa966ba231 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c
> @@ -77,6 +77,7 @@ gk104_fb =3D {
>  	.init =3D gf100_fb_init,
>  	.init_page =3D gf100_fb_init_page,
>  	.intr =3D gf100_fb_intr,
> +	.sysmem.flush_page_init =3D gf100_fb_sysmem_flush_page_init,
>  	.ram_new =3D gk104_ram_new,
>  	.default_bigpage =3D 17,
>  	.clkgate_pack =3D gk104_fb_clkgate_pack,
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c b/drivers/gpu=
/drm/nouveau/nvkm/subdev/fb/gk110.c
> index 45d6cdffafeed..4dc283dedf8b5 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c
> @@ -59,6 +59,7 @@ gk110_fb =3D {
>  	.init =3D gf100_fb_init,
>  	.init_page =3D gf100_fb_init_page,
>  	.intr =3D gf100_fb_intr,
> +	.sysmem.flush_page_init =3D gf100_fb_sysmem_flush_page_init,
>  	.ram_new =3D gk104_ram_new,
>  	.default_bigpage =3D 17,
>  	.clkgate_pack =3D gk110_fb_clkgate_pack,
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c b/drivers/gpu=
/drm/nouveau/nvkm/subdev/fb/gm107.c
> index de52462a92bf0..90bfff616d35b 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c
> @@ -31,6 +31,7 @@ gm107_fb =3D {
>  	.init =3D gf100_fb_init,
>  	.init_page =3D gf100_fb_init_page,
>  	.intr =3D gf100_fb_intr,
> +	.sysmem.flush_page_init =3D gf100_fb_sysmem_flush_page_init,
>  	.ram_new =3D gm107_ram_new,
>  	.default_bigpage =3D 17,
>  };

--=20
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat