Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Apr 2023 23:16:57 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH 1/2] maple_tree: Add a test case to check maple_alloc
Message-ID: <20230408031657.66fglyhaqds3unya@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org
References: <20230407040718.99064-1-zhangpeng.00@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230407040718.99064-1-zhangpeng.00@bytedance.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?l1I+VEMN2M4VagzoStP5aPwZO+Mdw5GzU6v85lW5JF6566C8r/Moy2ywti/6?=
 =?us-ascii?Q?Hq4w1dtEU5Vbwy6T8w9dVRhaWvoqYbP17oILZ49rVKipiw7jIFPJeIE682uc?=
 =?us-ascii?Q?WeH/lDFxO8J8wvGtdN4CdB71LDTOPI06sezZjnY6foeDJcjd58AFxq19U1OU?=
 =?us-ascii?Q?3+Ad3lVZefom5WG2Ssvjg62QZghyh6ck95MTe9K/Y0SSw6SleJJKKhM6kQIT?=
 =?us-ascii?Q?xS1tmrGG37VoKC7MPendr7YLjACciog8etJJAmRrUL2CzHzdFTaMM4+tDl2w?=
 =?us-ascii?Q?pas/ykqqNWiCs05lin45rxnh65mdpydlPKfSd17x+GyE79HTP2rreJnhgtt7?=
 =?us-ascii?Q?8j55gh8ZXMFzl4mwXzbriGKB62mmUISJgV9nWn/oVRv6+DEWwIaV09Lq8n/y?=
 =?us-ascii?Q?KLQ2yn0gD4WxIsUxTu9UviNNO6q3X7DNXO5l+Zhp4Pii4K/1LpV9bpjYQjns?=
 =?us-ascii?Q?40mLBdqd2Y/HptUULaMgoJTlz14etiL4Lgz4+lF3PHyVWes6ItvAo3Gk2sgO?=
 =?us-ascii?Q?aTNmYMuIUA2LmbydrxfxJ19u7kP591TsG1NqccU6JqJJ/SsVobervwPVNRg3?=
 =?us-ascii?Q?FSS3U9HITLs78EMBwvkJOeCU5vyL5Ru/cAguLbhVjZS0X1U/zifrR4fbOVz6?=
 =?us-ascii?Q?3gjVhW9Tp464OMRrLYgZZLZ+SZU7nZnt1uAg8ALeJt+XZrReaDI82JdJgFrM?=
 =?us-ascii?Q?tpXUPDsovTIVV0C/Pz5WPW/z0Q0iNH35b+DkcVg4HaHP6hwtESXTiX2gWcgz?=
 =?us-ascii?Q?gJ/PAE8pjJ64BMz/8cu0dW8qxISRHZZYeFiosjv/5mmaZ5ibSpvGM+HDfYU7?=
 =?us-ascii?Q?iDyOsDXC4WDmR5AKoLp80rvMz6kgC+KTQrAoUeBe5Juroeq9Y1l9ZZiZigJz?=
 =?us-ascii?Q?2Hiyjos2/0+E/HfEgalJfiQZpF6emB5DPqyMsNvTX+Wv2VUfSXqbASckxckV?=
 =?us-ascii?Q?iYg1cwCjSbh/H8w518bwh1yC8RsKwj+ekKGJK86r0FCZRGLiI7snpeT0kCxA?=
 =?us-ascii?Q?9lBFVxbZEAA5AZbARn21kEFkgU3eIqCr/PZHLV8JTEcifdYTJX/dNen+LqCR?=
 =?us-ascii?Q?nhvY1QQsSjKwMLctflfL6JVjt6qQJjva6pMiCsButwpv6r7iQxpRcae6vfFU?=
 =?us-ascii?Q?SDfZcy0qSkZWpUsGqj6bDa/mWOpoRNp3KMwj7l0tL97Xc9OLv+1SNe0V6Bd0?=
 =?us-ascii?Q?dl9/HDjB96XocI28DDCjLZuIHvWimfmAVzp/ueeUmwTJAaO0re84Z30nP3V8?=
 =?us-ascii?Q?uuN8hVWfwCPGEODEGP3Asb1ujxftPzrk1Hcp8cRBlPsJZW2RmqxPXvEtC4M7?=
 =?us-ascii?Q?/r0fPsSnem8UvzE8qcKHESI2lqDTahAwqpgEdujWMZwCXexmslrTvpHvlBwf?=
 =?us-ascii?Q?k+zgNX9i1CtlvZG2VSr4OvwoTV5dpBcQc5z5/Hy5v7cosl063/EUpr4Ateu0?=
 =?us-ascii?Q?ZwEErDdCWMCBrRg/UiQu2o4Wjd/EePkU5tHhcnoohq8QYImlUUBrkosks4np?=
 =?us-ascii?Q?Wsl3ILcj8TFgI5onYwewUABKpkTKcDPC17N1Szyw7f4YjveRF3Fr8S6gQQtR?=
 =?us-ascii?Q?zKJwz7dZ1IcuYD72DTKCWBF/qYCnu/m/WnQmskUS?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?aqUGXLPNiECh0CS1eyWJMNAKF30/4zkOs239hBgXuYGuwKXkPOl3wmLibGDE?=
 =?us-ascii?Q?I0GshmjVC5++8amws3TY4/i6ec/uENVZKmFZdoAoH03rH3OHB9rbeNZZWHxw?=
 =?us-ascii?Q?41+DUGnl63vTm4EU13apOYxqDvkVXYYxOBoE3gh/KGjJZ6zpXCrdnNN9eBc/?=
 =?us-ascii?Q?k2W2vOyx87Ej4K/vCt3wFORjhrlIY9iSutLgVCTy4aTmmXp9kesl2PdyVJkm?=
 =?us-ascii?Q?/FsHT72MihKyJrjz1/MPNSmLxbcuYMJoJvxAVNuzMfgFzEn+wLpd0oPDRKMw?=
 =?us-ascii?Q?9v85kvmYox+Do0vmA/heXYYGrK4yaBWLSx1uHOtDo3ILG4i2VHYffMEipaq7?=
 =?us-ascii?Q?JrgzMGkl+61WtrFfXe0cVXBAzWOKgcYCukz5ZfmOHrSU8wN/oFFmnVSPP85L?=
 =?us-ascii?Q?pn5iva4wkY7WHlB0QzbLfO1wbEArkG+CRmHvPUFYXTzxHGI4qeIlItnYfbEj?=
 =?us-ascii?Q?2Pf6V1VfMJCkLyqTLfRzHlV1zxT5NOr4kSwBRpr5cL/GwGzDOGJo/QDo02Te?=
 =?us-ascii?Q?F5uckGTz01HDW9iGjHjYepi6tJp4I1S8TDcwO5NGw/3NjYbFGO+At0Nm5WCR?=
 =?us-ascii?Q?MpX++nBaps2dknrCTmHqaA2CCMA9PACxB/ZEKDGGjqiwUiUIdRBAcDLX4m/i?=
 =?us-ascii?Q?j/8FaKQxOWgypVxPYOqU1xRdhFl/M0TsESL85rMJT790H3Zm9ie3ztPND0nw?=
 =?us-ascii?Q?28UODjx5nLHtinblY5E7jCgyHCUa3lW5/xiuuxn1G/tCx1SCdD2LC1K9xG36?=
 =?us-ascii?Q?mVhcPOg3pQn88sZfSe6vS1G0+A/+99A5W9qSUTSonM5hEzTs5z7VGsiayw+g?=
 =?us-ascii?Q?H8Al92HExmgrYA3rZ7i+YFccxbmFxTjZFHvzfMcoJAbzoGLJMZBDhdYKxkAI?=
 =?us-ascii?Q?qNv//Sq/6jzBMpFAlW6aNEBB6CD5sjnFtDnxF2zOwQmbyP+foXP28rOTenP1?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1769751-2f4c-4126-0d88-08db37dfb841
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2023 03:17:01.3069
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yIPvSiH2/BXkPsfonnyBGrq/QY2htAYu62Z2+HXQ/HZqjeCEUsswOmvOdV9K9PVJe7xrABm3LQuUdLXqHGmqkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6764
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-07_16,2023-04-06_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 phishscore=0
 suspectscore=0 malwarescore=0 mlxlogscore=853 bulkscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2304080027
X-Proofpoint-GUID: K1Kj6AtT50ZPL5llnyUf0o_H44UcgYpF
X-Proofpoint-ORIG-GUID: K1Kj6AtT50ZPL5llnyUf0o_H44UcgYpF
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Peng Zhang <zhangpeng.00@bytedance.com> [230407 00:09]:
> Add a test case to check whether the number of maple_alloc structures is
> actually equal to mas->alloc->total.

Please have a look at check_new_node() as there are tests there already
and see if it covers what you are trying to test.

> 
> Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
> ---
>  tools/testing/radix-tree/maple.c | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
> index 958ee9bdb316..26389e0dcfff 100644
> --- a/tools/testing/radix-tree/maple.c
> +++ b/tools/testing/radix-tree/maple.c
> @@ -55,6 +55,28 @@ struct rcu_reader_struct {
>  	struct rcu_test_struct2 *test;
>  };
>  
> +static int get_alloc_node_count(struct ma_state *mas)
> +{
> +	int count = 1;
> +	struct maple_alloc *node = mas->alloc;
> +
> +	if (!node || ((unsigned long)node & 0x1))
> +		return 0;
> +	while (node->node_count) {
> +		count += node->node_count;
> +		node = node->slot[0];
> +	}
> +	return count;
> +}
> +
> +static void check_mas_alloc_node_count(struct ma_state *mas)
> +{
> +	mas_node_count_gfp(mas, MAPLE_ALLOC_SLOTS + 1, GFP_KERNEL);
> +	mas_node_count_gfp(mas, MAPLE_ALLOC_SLOTS + 3, GFP_KERNEL);
> +	MT_BUG_ON(mas->tree, get_alloc_node_count(mas) != mas->alloc->total);
> +	mas_destroy(mas);
> +}
> +
>  /*
>   * check_new_node() - Check the creation of new nodes and error path
>   * verification.
> @@ -69,6 +91,8 @@ static noinline void check_new_node(struct maple_tree *mt)
>  
>  	MA_STATE(mas, mt, 0, 0);
>  
> +	check_mas_alloc_node_count(&mas);
> +
>  	/* Try allocating 3 nodes */
>  	mtree_lock(mt);
>  	mt_set_non_kernel(0);
> -- 
> 2.20.1
>