Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 7 Apr 2023 23:22:09 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org
Subject: Re: [PATCH 1/2] maple_tree: Add a test case to check maple_alloc
Message-ID: <20230408032209.iiwr4s7htndudw3h@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        maple-tree@lists.infradead.org
References: <20230407040718.99064-1-zhangpeng.00@bytedance.com>
 <20230408031657.66fglyhaqds3unya@revolver>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230408031657.66fglyhaqds3unya@revolver>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z+pcm2IR+SWG/G+NIdI/2SebxHZpNZGjiKsOIlnDfB10fX9ffcDVG63ABIBb?=
 =?us-ascii?Q?kFK1yv9FPw1rdjzKhT+X8ke6iawsJBvxeAslf//JyUtAfGAGK6hnPJPsVcRs?=
 =?us-ascii?Q?/RXVnAKusMTS2zfjgN19Q0zp3MY0wHAkafKl/ffszaEFZUdl4TlPoalqoFO4?=
 =?us-ascii?Q?Vx2+JIEsYhvi9C2uRxWjgDh9KS1Qn3ZhQEFvbPnutX4CO37UOVY1/k1b0n2Q?=
 =?us-ascii?Q?RkokxJB/e78ID+MI0MeAMQM7sECT40fzihyQwu3J0YXzIylq6y/i4BK4sEQG?=
 =?us-ascii?Q?S/ecB3uuyA6x1yTruU1lndiPEa1i/D8pvS+KCXqE8E8k6H59G/xKXlz1drTe?=
 =?us-ascii?Q?ZJqh5qenFupL9XgCkQL9Tk+TkPl6N3bj+BzLND9xCQqXHQXs9zw/4XnjYjdd?=
 =?us-ascii?Q?UEJSKL9WG0GvIO31AGVXkI25PFpWn/uN5lcvnDdNCj2nlI/lBWHkuLx4bIRR?=
 =?us-ascii?Q?PdogPkfz5L9JvGgIENLifDk3OM8WinL3DMulALfSi3Yjhte+YT2CLSLwAajx?=
 =?us-ascii?Q?of8UdmlOzPfjCiK8V+dGCciaEJIuS1n1Ll+mgDLsYUnFie8PElop6D7IafKV?=
 =?us-ascii?Q?p7qPae1RSNV+9T5sB6xFHnlp3TO+zjiTXJo8gLjqGkM2dDjMesPHS4rWTMnI?=
 =?us-ascii?Q?RkdEeDPO9etE8My3ggqgqORGBhGLdzGAVQs+UXm+DLCXmXJSisnDRZtAm5Pw?=
 =?us-ascii?Q?KbSr+5XL/HMh7aFOvNoIMzC5L8lTWw+XgFfAviVcNeQLwMo32VGoJiGky6Rz?=
 =?us-ascii?Q?igX4a1t6cYB/whRbr2am/a6iYqKK4NZz2FI47VIMUfQo0Q9nX0mmBxC7qRbL?=
 =?us-ascii?Q?8x2lIpbGRuREYodzOSpaNMFdmZCcw0Ja1PwETwLOfYib7QOyfF6AgRCbU/io?=
 =?us-ascii?Q?EIrs+j4ICbFBxOtKMAlDgp9qNfm7W40EsMR5gOlHzs8Hsljz8sBP2lk7svBm?=
 =?us-ascii?Q?81yNaC+RAWfFB5vFLlYYD7ENmHJmzRFLpdUIRJG30iLq+Oq5VzwjO1AMA+UA?=
 =?us-ascii?Q?iKW0cndEZlh0bvXwcVHlsx6Un860mLxu89Sg6DgtXxgaK+fLJhQt06iHMfqu?=
 =?us-ascii?Q?+ZGPIqTZNeAWb+OXYiQh1bYMq2TlmJTduRxV3BDrv/8E0Yv1eo10vUpxb18S?=
 =?us-ascii?Q?ZDRk/3pxFaunXHOSwXFtfKFnqCPzuTXGWHvHvCtwIYG70KZEz05kMkCy4T6y?=
 =?us-ascii?Q?iUfTx6QZeJoRnDhJhAJVuW35f9GGEiyRfA/NgZj4RFqJGFgX60AGSY3HizXd?=
 =?us-ascii?Q?UHh+6qde00K4l9DWSdamds7p+F3/AXL9mSWEJagdPTh8Ox6qr+FBZCdaXILS?=
 =?us-ascii?Q?XU4Yr/kXHxSU2dbSwMu5zqFsdc+awy3X3oINIlrWSzt9lLVv0bIWEOOsFc7U?=
 =?us-ascii?Q?Git3ma4//1bWnSFNYqW2bWLFKNsdWNFn+PaAYyPV/YrTqth/WgxD/eAPAJAV?=
 =?us-ascii?Q?hbDUCkyoWHEXJ1Nl3+8DzqO3Fgm5/KU0XNQGkJHAorVabzqmX+8/1qDiBmB2?=
 =?us-ascii?Q?22DtaGj6GoVhc+HidQAnK2YbP1QH43zeoNIZIPUeW+mqD+2SB6+eDePzTjAK?=
 =?us-ascii?Q?+NpCqvhnCymKC9jvOuEyO8LBGWkfI2O4ZfjkoH6U?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?E0fW551i36I/pp4Z5WRD8Vhw0tnRZkXrQyVzmA5uGsarUUhv0rmH4x4TTyYq?=
 =?us-ascii?Q?M3ZVVSvXsMIw5Qv3zkuax+SgqJHArorcbC+91TI6AWmVlPNCJZLYVozKCDs4?=
 =?us-ascii?Q?sxt2tyV7EC0/rX4PJCyqF2j+2YsyeO72IhXDY7Xx/VdKAKGECjsnSqE3igAJ?=
 =?us-ascii?Q?Kl1/UyqYbJsrr3RjZXVFVWttcUlxw/hQgV1mmFqVZ5azwf+CdFgQv1af/1TK?=
 =?us-ascii?Q?T3fZxuLOwcQMj6fF5oJEQu8Dci5IO0MeEop5NYxlG95j+HZXNS2o64YHsi8G?=
 =?us-ascii?Q?6Fk9gxIViToSMoXD+wIQy7NSvF1YOKw9VzYgDVs+yJ5WzoQJEl+2J395GmYo?=
 =?us-ascii?Q?32BlpS6ppszoF0olfsyqFJVEKTCeEn0pzXFJruBhrCkAxyDXgbn6liZH0YFV?=
 =?us-ascii?Q?B5Qhe7bcTWxpRsxpCKsNJgav6Q/9OvAM/Jsb/SIMa7b/cG1uMXoFqVM3jrPd?=
 =?us-ascii?Q?I13SB3L+4utEzT0EyXx0Nk9hNBAK3C9kMrW/kSkDMudsuaCwacf507WEi1d2?=
 =?us-ascii?Q?xsAClR8XdVzx/k77NCj9nxah2B/UXaRmp5VCXMtv/TvbgtLpcFDSz9iv1Mqk?=
 =?us-ascii?Q?lUEdOhH6o2Ptke671J7p5Cj5npL4Kolcuq00Bz/+AtDs0udFe8u1Qrey4h24?=
 =?us-ascii?Q?b5x9BuKcOUAx96BEkyaqBrCkGRpPWTp8jXb1i+4HRAII8sW7Vx+Jyih2AXyq?=
 =?us-ascii?Q?Uc2P86j1NyNEqJiGqssoXBuPBSpoq1pgADEBeIgDMSANVwL+HQtENfwfzT3q?=
 =?us-ascii?Q?k/1NQZXuzmL/dFulWZm19wUEkZab5bCgxSD5Y15BgYMPp13gs/ah5M9j59AK?=
 =?us-ascii?Q?ENit1uCHQz6cw5p8XHMMr/5Mo2mYWKrzU2Kney0IVeExHsmCXqPwPT8UNCPR?=
 =?us-ascii?Q?0arabqJOlQbVSArwo65mv5IY3iyiKcg4qGlqrpzGdEFKsqh/sLg31/I4PGAM?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cd99180-d7dd-47f3-ddc7-08db37e071d5
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2023 03:22:12.6318
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZJqnLY9Oid01p8hsqyr5J8lEGRWdABPjAd89Y7GVyngpBHh/PwxjG8sbBzL+87GS41aJ2Yxhq8q0ozrsHi0Crw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR10MB7093
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-07_16,2023-04-06_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 phishscore=0
 mlxlogscore=999 malwarescore=0 adultscore=0 spamscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000
 definitions=main-2304080028
X-Proofpoint-ORIG-GUID: kn7zY1CJIREkOTjCqK13p-PDFIq18kdX
X-Proofpoint-GUID: kn7zY1CJIREkOTjCqK13p-PDFIq18kdX
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,
        SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Liam R. Howlett <Liam.Howlett@Oracle.com> [230407 23:17]:
> * Peng Zhang <zhangpeng.00@bytedance.com> [230407 00:09]:
> > Add a test case to check whether the number of maple_alloc structures is
> > actually equal to mas->alloc->total.
> 
> Please have a look at check_new_node() as there are tests there already
> and see if it covers what you are trying to test.

Sorry, sent this too fast.  I'll have a look after the holiday here.

> 
> > 
> > Signed-off-by: Peng Zhang <zhangpeng.00@bytedance.com>
> > ---
> >  tools/testing/radix-tree/maple.c | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> > 
> > diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c
> > index 958ee9bdb316..26389e0dcfff 100644
> > --- a/tools/testing/radix-tree/maple.c
> > +++ b/tools/testing/radix-tree/maple.c
> > @@ -55,6 +55,28 @@ struct rcu_reader_struct {
> >  	struct rcu_test_struct2 *test;
> >  };
> >  
> > +static int get_alloc_node_count(struct ma_state *mas)
> > +{
> > +	int count = 1;
> > +	struct maple_alloc *node = mas->alloc;
> > +
> > +	if (!node || ((unsigned long)node & 0x1))
> > +		return 0;
> > +	while (node->node_count) {
> > +		count += node->node_count;
> > +		node = node->slot[0];
> > +	}
> > +	return count;
> > +}
> > +
> > +static void check_mas_alloc_node_count(struct ma_state *mas)
> > +{
> > +	mas_node_count_gfp(mas, MAPLE_ALLOC_SLOTS + 1, GFP_KERNEL);
> > +	mas_node_count_gfp(mas, MAPLE_ALLOC_SLOTS + 3, GFP_KERNEL);
> > +	MT_BUG_ON(mas->tree, get_alloc_node_count(mas) != mas->alloc->total);
> > +	mas_destroy(mas);
> > +}
> > +
> >  /*
> >   * check_new_node() - Check the creation of new nodes and error path
> >   * verification.
> > @@ -69,6 +91,8 @@ static noinline void check_new_node(struct maple_tree *mt)
> >  
> >  	MA_STATE(mas, mt, 0, 0);
> >  
> > +	check_mas_alloc_node_count(&mas);
> > +
> >  	/* Try allocating 3 nodes */
> >  	mtree_lock(mt);
> >  	mt_set_non_kernel(0);
> > -- 
> > 2.20.1
> >