Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1659689rwl; Fri, 7 Apr 2023 22:27:41 -0700 (PDT) X-Google-Smtp-Source: AKy350bL9lHgABLUhsCFOMUQlMvigkpLU+3FTmh9iSt6OsNpZQAOuHkB7NY/eafvEZBEQdfwZnO4 X-Received: by 2002:a17:903:4308:b0:1a5:2760:74ef with SMTP id jz8-20020a170903430800b001a5276074efmr1029349plb.25.1680931661496; Fri, 07 Apr 2023 22:27:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680931661; cv=none; d=google.com; s=arc-20160816; b=WwHwOtIBmJlh6fPiAZcy7o07V5BsQaKeImPBTw+OTsmfm6mJacZlLqqDMMMhMfep+D ynAGpH1E4v8GJXYBco1u1ZTTSRUek2LCg8pV3s1hQFg+y7nJXDOdo0xI9T11MRnmgU/c jxzhKKu0OoI3rzNSLm2hAcEyXPkfgIt4fiWjMC1O+qC0VZEckpR2Dd4tu6lNWpDFK4SB PE165wqap6s6i5a8a5bVUnDaWGIjWJjPx+j9hixrLPienSa1Wp000dgLiFGKIgtxboTP blI/WpkrmHy2llHD2rccQUjSOfD8Ux02L9Kp9Uap+SMg1PmLviW+kpNuV3cFXScGR4ff +Vpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=P/sS00fjJDUBO440kEeGbA/gT2KY1fx925NbBcjh3SE=; b=aM7Qws2swiZjLb1G6uMCq/bYZLnarzQ5Pp5jJWRqrIzuaIOuH6Xk9gHfrxghf0PcSF Jq7ivU7t/1PIasWL7A8fwRc3oydodspnVQvZGaNKOmr5VgOhNBs2efi2Wb5rLTLptJpj Uhirtnr2O4I81QPZMh4Hp4jK3SczE8Kn0TSvjmefNaVPGKw6XlDvgdGUhGOkK/2c4ZV/ mB4y9sNxXe/T2zQc/Z6V2S8t3V6XNAekb/DT9mXdpfIuRYSBjALEX0VvZr4Q7/9q1Wap CMefnWke42qI/CpWPVIVG+wua/v/f+f9z58lcsCRr7nCBII7v0u2Ov1LSoIacPOrl18d YBfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U2PGqOaQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z11-20020a170902708b00b001a4ee96c00bsi5327086plk.357.2023.04.07.22.27.30; Fri, 07 Apr 2023 22:27:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U2PGqOaQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbjDHFI1 (ORCPT + 99 others); Sat, 8 Apr 2023 01:08:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbjDHFI0 (ORCPT ); Sat, 8 Apr 2023 01:08:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5617CA07 for ; Fri, 7 Apr 2023 22:08:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4E5A7619AC for ; Sat, 8 Apr 2023 05:08:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 431C4C433EF; Sat, 8 Apr 2023 05:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680930504; bh=hMEeQgX30xw65Z5q9Hxes4XMGuwknIAjnyQ9W3+zVWM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U2PGqOaQbO1XUtwDYVoSbhKHtUOTWSjRf4A2QByeA7z5/tGRzCszUGk9rxoDykIsM nNS85pMy+Jg46RcOQ8DtaDTYvLHCTctUwRKA06vh74/yRMTTefd57ywExWzNQm0Qnf YeUXZ2N1qyXyAtZ1Ls1coVWe807ir7hyP1p9DL6PzpuGwNRfq0e48PcAIwcSDaRIgx ysqM5r4OEfjSw81tR76t8BAohub0lY6pIC6agqwwAmWUVXNmwKgD5JK6CGrQSCXmlz rIoSygwyZ+Ala4HGHlu0keV4Xx9mA2asTK80xUFg1rXIJF3PWGqD4QGqd0KYo56Epa gWUg3C167/PHg== Date: Fri, 7 Apr 2023 22:08:22 -0700 From: Josh Poimboeuf To: Qi Zheng Cc: peterz@infradead.org, keescook@chromium.org, dave.hansen@linux.intel.com, bp@alien8.de, mingo@redhat.com, tglx@linutronix.de, rostedt@goodmis.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] x86: make __get_wchan() use arch_stack_walk() Message-ID: <20230408050822.ezdbhc6j7zuvutrm@treble> References: <20230330081552.54178-1-zhengqi.arch@bytedance.com> <20230330081552.54178-3-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230330081552.54178-3-zhengqi.arch@bytedance.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 30, 2023 at 04:15:52PM +0800, Qi Zheng wrote: > Make __get_wchan() use arch_stack_walk() directly to > avoid open-coding of unwind logic. > > Signed-off-by: Qi Zheng Can we just have a shared version of __get_wchan() for all CONFIG_ARCH_STACKWALK arches? -- Josh