Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9d6dc1b-cc1d-d823-8777-3a8d6d2328f7@ti.com>
Date:   Sat, 8 Apr 2023 16:57:51 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH RFC v2 2/2] irqchip: irq-ti-sci-inta: Add direct mapped
 interrupts
Content-Language: en-US
To:     Marc Zyngier <maz@kernel.org>
CC:     Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20230327-irq-affinity-upstream-v2-0-1474e518f1cb@ti.com>
 <20230327-irq-affinity-upstream-v2-2-1474e518f1cb@ti.com>
 <87ile664i1.wl-maz@kernel.org>
From:   "Raghavendra, Vignesh" <vigneshr@ti.com>
In-Reply-To: <87ile664i1.wl-maz@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 4/8/2023 4:10 PM, Marc Zyngier wrote:
>> +static unsigned int ti_sci_inta_direct_events_am62x[] = {
>> +	/* CPSW etherenti DMA events */
>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4627),
>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4635),
>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4643),
>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4651),
>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4659),
>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4667),
>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4675),
>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 4683),
>> +	TO_HWIRQ(DEV_DMASS0_PKTDMA_0, 5651),
>> +};
>> +
>> +static struct ti_sci_inta_soc_data soc_data_am62x = {
>> +	.events_list = ti_sci_inta_direct_events_am62x,
>> +	.events_list_size = ARRAY_SIZE(ti_sci_inta_direct_events_am62x),
>> +};
> I don't think these tables belong in a driver, and they are bound to
> grow without any obvious limits. 

Fair point.

> You have firmware tables that can express these things. Surely they can be put to a good use.

By firmware tables you mean device tree?

Regards
Vignesh