Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 8 Apr 2023 23:03:44 +0900
From:   Masami Hiramatsu (Google) <mhiramat@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        linux-kernel@vger.kernel.org,
        Masami Hiramatsu <mhiramat@kernel.org>,
        "Jose E . Marchesi" <jose.marchesi@oracle.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Sami Tolvanen <samitolvanen@google.com>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v3] tracepoint: Fix CFI failures with tp_sub_func
Message-Id: <20230408230344.06f9c6c95d4659b2f5363ba0@kernel.org>
In-Reply-To: <20230404162232.1b2f4c2f@gandalf.local.home>
References: <20230324123142.7463-1-mathieu.desnoyers@efficios.com>
        <75dbeff6-fd0c-aec1-5821-919088eda6c4@efficios.com>
        <ZCwDAnRHjNr9ZftR@FVFF77S0Q05N>
        <20230404162232.1b2f4c2f@gandalf.local.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 4 Apr 2023 16:22:41 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 4 Apr 2023 11:59:26 +0100
> Mark Rutland <mark.rutland@arm.com> wrote:
> 
> > Sorry to ping, but are you planning to pick this up, and/or did you want this
> > resent with the Testing-by typo fixed?
> > 
> > I couldn't spot it in the tracing tree, and I'm not sure if it's still on your
> > TODO list for review or has just been missed.
> 
> Actually, we may be going back to your original patches, as having a stub
> function for every trace event will allow us to attach fprobes to them. And
> we actually have a need to do that (connecting to tracepoints to get more
> info than the trace event gives).
> 
> Masami is currently working on this.

I think we need another stub function similar to the original patch, because
the __tracestub_* functions are usually not called back. Even if I enabled
the static key to enable the stub callback, if user sets another callback
handler to the tracepoint (e.g. enable trace event on it), the __tracestub_*
function is not called anymore.

Thus I think we just pick this version and add another patch to introduce
__probestub_* functions in macro, and fprobe on it. This new stub function is
something like the original one so that it doesn't break CFI. And it will be
registered to tracepoint when the new fprobe based dynamic event is enabled.


Thank you,

-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>