Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 8 Apr 2023 16:33:12 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Sai Krishna <saikrishnag@marvell.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, sgoutham@marvell.com,
        gakula@marvell.com, richardcochran@gmail.com, lcherian@marvell.com,
        jerinj@marvell.com, hkelam@marvell.com, sbhatta@marvell.com
Subject: Re: [net PATCH v2 1/7] octeontx2-af: Secure APR table update with
 the lock
Message-ID: <ZDF7KFavZuM2SoGO@corigine.com>
References: <20230407122344.4059-1-saikrishnag@marvell.com>
 <20230407122344.4059-2-saikrishnag@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230407122344.4059-2-saikrishnag@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kYYUGBO9DHp68G3c1ZHs5qNHbsUZyKeRCOx91Gxwvptbv33PW7koHXOAsdv8?=
 =?us-ascii?Q?qxOWd27QF55ckb4DdPuEqNM8uyfwptAkmVh/VGQXbPLPyyqHRRp7bwbQkifU?=
 =?us-ascii?Q?5hajEIUOf9nHWuwWu7TuiIDOVGfNMPgwe6guivS5WJmkUR5jxiduDOiAP0oL?=
 =?us-ascii?Q?/6F0NiORzxgKTRHwcpulRWfWOMytLdroKXvbK4WM/zhnFQZTKze+Chw4TctZ?=
 =?us-ascii?Q?VYU1ugytEJV9fD3d/dJfhj+bm5muSvA62S1cUOB4MkYKLX8BdNn2RjbQ4kZC?=
 =?us-ascii?Q?a1lNe2pOqcd5grKFDnVwyJP/Wz+Cqqltjeit4NRViD9U5mOf2viqv3fv+nE8?=
 =?us-ascii?Q?NPJyPVIj/D0DFXO3sRsWVBAeuGBXZW4n9RV6ybpc0usuaaptFMsY13OhG67J?=
 =?us-ascii?Q?mBp5RU212jJzuls2A39a3hG1LwcdejmfRvCIye3J5KXZThB2tgwbb7orooz+?=
 =?us-ascii?Q?DeDS2HThEHJCB5e2ftvH17prWFmxQBiACA+EhEGccs+ziA+hqa4A4Kd0jQ9v?=
 =?us-ascii?Q?ljeemQPG9N4bIjHDWs7scEDVWA62r+iy2jDEjuSwUkWUI8OScEl9ZkzFO9cL?=
 =?us-ascii?Q?acMUmY+z+X0TtJwNti9a8Ej6GPAwTrm8WgujAa5qrMbEdTtWgG3+2PwE2HZJ?=
 =?us-ascii?Q?6q00fZVIVRwNSX5cvHTbbLINuBn8K6dgO8wlrpgrkAU6JDCxEumX8RbNeUw7?=
 =?us-ascii?Q?9S1tQLA+V5vS3cTs6rvWJTRP8JjGEdhOL0t7HGsHI4YBT5kSsXix5nqt9wTE?=
 =?us-ascii?Q?7ZY/gZ4SodL/pN6xtvSFm46PB483smKxh6Kc3564Q3KMqdZiG93b6v0yBEgQ?=
 =?us-ascii?Q?URN4tPy4STn4eufqL/XILuGKqFaeWes0f3sDl5GZpLLBTegQ3uV6+aUt3Ayz?=
 =?us-ascii?Q?nYciTayMJqSRjgB/I21aRYZE5xxXVv8ViZiBLlm11KYQVLwN0qvqkMsun7Dz?=
 =?us-ascii?Q?XHhAZ89J3HMRNADBOHaizBPo4rlQaywq7J+ao2KSz2mf4z/Ta75VMNKDBhPa?=
 =?us-ascii?Q?3N2gmd88SLR81jt79aTV6hWxQXSXmjCInvsx3/zBPk4RMCiIU8FnFue9ojrV?=
 =?us-ascii?Q?+VbH/r4DVI8GOCrYooFkfHH+p0Wf9t1NzIc2p9imgkfiKTlvPVspx7CNBn7r?=
 =?us-ascii?Q?dlIdkpwq8QJrCFY/b83yPh+OsxQDFKz2LA/ekveHASF/jwhMfxGuL8+LI5lk?=
 =?us-ascii?Q?PtTWr5ocSkYpNFNgRxQl5+ZOjZeRcsIPHbi3Z5/VR3ywfhrlH7Q5e7ousq1B?=
 =?us-ascii?Q?/bvoAAwE8BllHc/3yycysLA6pwGrRTIqapSNeJ8qi5ZyXHkPM2xQNWBmhufr?=
 =?us-ascii?Q?4b9yyt62r9VAYpFyX4oP0cgbyrHiLhZhTlXoJDK1xiV+0rllqD3MSNxYebIO?=
 =?us-ascii?Q?uwwfHopNZXmdvHlLNIcMasdg2uw6uTyY8lYVUp38suFvOTmrjixtfJf+Hry6?=
 =?us-ascii?Q?BEJR953lsUPh1OC1TdS7wq6KH+OLzR3bwEm4rs2tRnhbQ7/ipBMn67O3L/yQ?=
 =?us-ascii?Q?TJPyQzcw04WjrLh6Jf5HN1lyLuRkGwIXO9Q+RIfksXIUs2CqcD+4tnBW0K+g?=
 =?us-ascii?Q?m/zM8l92myTyOOYcwVmn8HTdnk1gd56eguT/x3ZIJRLUTtuQt53byFmqRGXg?=
 =?us-ascii?Q?oUaE8HUcsWS5FpB2VKNjDRA0Ygj9pNTYtcxfnjRUJpQP8QY/bJXDPXnCAbFd?=
 =?us-ascii?Q?3KPB7w=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f696b953-b280-4547-fa1a-08db383e339f
X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4834.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2023 14:33:20.9724
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M9MC1fcidUzswDUgWENcVdIhuTeMCQJUdFh5us3Yngudvej0uT470iGrA6KwHHTCz6xt8pnj5bZtobfrpWBwBRr9OtqOWrHD84kD81An/7A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR13MB4867
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 07, 2023 at 05:53:38PM +0530, Sai Krishna wrote:
> From: Geetha sowjanya <gakula@marvell.com>
> 
> APR table contains the lmtst base address of PF/VFs.
> These entries are updated by the PF/VF during the
> device probe. Due to race condition while updating the
> entries are getting corrupted. Hence secure the APR
> table update with the lock.

Hi Sai, Geetha,

I think it would be useful to describe what races with
rvu_mbox_handler_lmtst_tbl_setup().

...