Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 8 Apr 2023 16:42:30 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Sai Krishna <saikrishnag@marvell.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, sgoutham@marvell.com,
        gakula@marvell.com, richardcochran@gmail.com, lcherian@marvell.com,
        jerinj@marvell.com, hkelam@marvell.com, sbhatta@marvell.com
Subject: Re: [net PATCH v2 3/7] octeontx2-af: Add validation for lmac type
Message-ID: <ZDF9VsgHl41cL4wE@corigine.com>
References: <20230407122344.4059-1-saikrishnag@marvell.com>
 <20230407122344.4059-4-saikrishnag@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230407122344.4059-4-saikrishnag@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VQtkQHlVJlm9fyuSldr5K5HuCmHHvGgH0YxJVJhJ4PSggPLYPGXXcMpQ6miR?=
 =?us-ascii?Q?7zAStlwyw4ZjmZg6AsvsJrI03dKc/cq+ZFZoTO6Zlo56elWj9hrxBj2w6kqv?=
 =?us-ascii?Q?6XACKjdnTChoBU8FV31N5OQ66VyhIVVy8w3MATjM+A9oLs6btTnJHz/DEDeD?=
 =?us-ascii?Q?YCRfHpqCShSX1VcS9w0/sQq/7RhRzyJNRDKmuvYqKJBMZBFstdq5tVWTajsn?=
 =?us-ascii?Q?4qo24OCedEFdBtVzgQR0gV4PTvvVDVEpTG74Vmlms7Cjgt5+kT2aDHV3WoaQ?=
 =?us-ascii?Q?BPb8TGfvTOm5vPoMwMV6ezc16PYutv4A0GNZp6q0Pfq1ckM22SGwd1yZxi81?=
 =?us-ascii?Q?4fIwEXue5ye2EQJt34mNskdQxrz1znY2YSav83d6Eopug2CulTnXJi6H0lZa?=
 =?us-ascii?Q?GO2wqKAPwY3+6+noghhmIukLRQDKdwbYvqaUJudDOx3IKZOCuSHxcgSKor+I?=
 =?us-ascii?Q?k9u9pKgj8XudNhVOpccurVSCXAxTg+i1R5k9OX7VnE+GFZ82s0vyI19st2HX?=
 =?us-ascii?Q?5uWXO+NYqNTImNwy2zmjzaLPpZJYTeopEEJpweitGVtT59eWq3AWvnkVFx/u?=
 =?us-ascii?Q?gFlD9/8QqvEtFXJZS/BiikBsZwsw9/W/EIm8K9VF7ciuqL0wqMy6Dv2XRWcH?=
 =?us-ascii?Q?91AqPMzpZhgZdBxoM9A2AgqvWQASqSFkuyxWJvkEhiFGrp/nr+iMcATUOfoL?=
 =?us-ascii?Q?bH+/DOLn3aTgRpdgSR/VjH28/f3bJPNLLWtsEKWttzBnFPzDuVFeb8z3XSWs?=
 =?us-ascii?Q?7cJjfCNmk8N5HIUh15ElCKhvMqDwNrqxRbeZqKvaGsiu6DQFe862KCY26kK8?=
 =?us-ascii?Q?vIJSkFabJ3ydq7vPocaE1WMypJYClovNkMvXqW+Wo7a9BQrmRgow1QVwLV3e?=
 =?us-ascii?Q?xIM39JDbVWPStSOU4rZCY4Z2qr05vAb+FuRta7J3xHQ5FcV3tYk9TZXYAg/I?=
 =?us-ascii?Q?4u+isGj7d1UW63Pd1BQ+Ms4j6vvHgO+U4jy6aT3UPVnRJuzWf+Dcy5TnyIas?=
 =?us-ascii?Q?VPpKezjcYrORRxsQ6wenFm8actmh/WD+s3ngGEGNeVyXtkpoiqD6W8mV0Lvr?=
 =?us-ascii?Q?DrsY5PAoUNv96Xb1GXhzeEkVpIJEEbDbNLuKE/IZi7d6wAcDzAj9/v4Ccj9F?=
 =?us-ascii?Q?nIf+bl8IURkHDvzFFjD8A5qt1FZd3eYH61oasEfDd/OJwfBNvG9iWTbfAtUd?=
 =?us-ascii?Q?Q1L+MAM1QFSO/4WSxopt5Yb1AZA6dullybLBCDebmq27A/renlTY6e6rieXw?=
 =?us-ascii?Q?3VpugmJzrBQOzlL2qo/I0iw4HpCdUwuKMsIDJ0iHX2TrgcTpGAn7sx42dlrM?=
 =?us-ascii?Q?QpbIM62tuxKrSlI+6xhDOT4f15pFiDwib2Q2zekiSdza3zhrP96k2raDr8ib?=
 =?us-ascii?Q?O1/JJkRqvQ+lcLZuDrfBs6MtAFhPJSwz6EYPHeFRj+sjCl6jVyL0d9zB58ds?=
 =?us-ascii?Q?f0pgvYGjCtiBJQLw8hz+LPA9r+TFBrvvLdflSUf2ca9dmCDF0k1lRGdVs4ic?=
 =?us-ascii?Q?Z0OSDaSBm3ekzPsLMqMFoQ4dtoxMrbwzs8EGX5dulC3dyu+0sdi+q4K1Elbf?=
 =?us-ascii?Q?EVbg5vpOwdaq9oqrTvyMUzSHbBN7IUxJI6ufHGBh59F0GqzHPrLp73mfqpeK?=
 =?us-ascii?Q?jue2ZzBrJzT+wcANb+H0c9o4rAXVnJsDzRmuaH81s6vhpBVGqyO67Pl2dcMO?=
 =?us-ascii?Q?vl1YZQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eae1e2a5-d47d-4ee8-35f8-08db383f80c0
X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4834.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2023 14:42:40.0665
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lUlqLW9rqjuVwmqC9+0iM9q/76UuKpIJb2jJOOtdT3WvQ0nUkCRYvkYJadmZzzsnOWrdXzXwZNekf67/TyoFccR00LJydTW1TAbm0oV/Shw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR13MB3962
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 07, 2023 at 05:53:40PM +0530, Sai Krishna wrote:
> From: Hariprasad Kelam <hkelam@marvell.com>
> 
> Upon physical link change, firmware reports to the kernel about the
> change along with the details like speed, lmac_type_id, etc.
> Kernel derives lmac_type based on lmac_type_id received from firmware.
> 
> In a few scenarios, firmware returns an invalid lmac_type_id, which
> is resulting in below kernel panic. This patch adds the missing
> validation of the lmac_type_id field.
> 
> Internal error: Oops: 96000005 [#1] PREEMPT SMP
> [   35.321595] Modules linked in:
> [   35.328982] CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted
> 5.4.210-g2e3169d8e1bc-dirty #17
> [   35.337014] Hardware name: Marvell CN103XX board (DT)
> [   35.344297] Workqueue: events work_for_cpu_fn
> [   35.352730] pstate: 40400089 (nZcv daIf +PAN -UAO)
> [   35.360267] pc : strncpy+0x10/0x30
> [   35.366595] lr : cgx_link_change_handler+0x90/0x180
> 
> Fixes: 61071a871ea6 ("octeontx2-af: Forward CGX link notifications to PFs")
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> Signed-off-by: Sai Krishna <saikrishnag@marvell.com>
> 
>  drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

Reviewed-by: Simon Horman <simon.horman@corigine.com>