Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 8 Apr 2023 16:43:53 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Sai Krishna <saikrishnag@marvell.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, sgoutham@marvell.com,
        gakula@marvell.com, richardcochran@gmail.com, lcherian@marvell.com,
        jerinj@marvell.com, hkelam@marvell.com, sbhatta@marvell.com,
        Suman Ghosh <sumang@marvell.com>
Subject: Re: [net PATCH v2 4/7] octeontx2-af: Update correct mask to filter
 IPv4 fragments
Message-ID: <ZDF9qY31VKfcigSx@corigine.com>
References: <20230407122344.4059-1-saikrishnag@marvell.com>
 <20230407122344.4059-5-saikrishnag@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230407122344.4059-5-saikrishnag@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vx4B/brMtL4CSZhtq7emYk6pQ4zAYgEWF/UQDesJUGB5DOM8XEZzt4rO4fED?=
 =?us-ascii?Q?zSg2CheKEjrWhsL5EDt8fPlbbAotOLI4LGyCZ21QUYsNLMszIKndGY88Uq2k?=
 =?us-ascii?Q?on1GWdRkAWI3RDcN2qfWQ/I2HW8JCmKSCiAFS847U2mEkv9iaCagyskifIn7?=
 =?us-ascii?Q?JeOYznlhmMIxGR2jw3McO+0GiDk/ccK6Yliaz9YOrHzCWG9bL5Y6C9qirRe2?=
 =?us-ascii?Q?eTTjAy4FoxA1F0x4CZGX2nztP7I1/9OCB+EcbC2ViwArYGY4OL+izOhv9zOY?=
 =?us-ascii?Q?l5el6ebDTUsRH9pFx6vqPvIp1MbTq9O6lKZ4ZuCurGNGPeCBB1V6kdAxr+fp?=
 =?us-ascii?Q?LpacUVEDSRZUZ2DAOVZIZNqHSkx+IxbF3jV7zyG6WljdX5PoWklbh4UnbxmF?=
 =?us-ascii?Q?piC+JNm3xuorYGOK3YmxmxeNFDh3QZdGhMG0JYSuoLUx/NdPojWkJEz71hRm?=
 =?us-ascii?Q?g4DH9zaYIkUHmv0yZDSgqKD5yWzqVFMleNweIyiOvHUuEbad2CYdYtXT2tkI?=
 =?us-ascii?Q?yLW5lj559J2WJotYAc0yBmXxvQB5MXqQ//qJkgz623vi8GBMxDR8Oj7k+0OE?=
 =?us-ascii?Q?xCbzEOYFZygmHcz5zaa4pxJvbt9Qz9NuBbgpqYF3Q1gcJe+Q59SNFPagkFug?=
 =?us-ascii?Q?NDMcjvK8YckrJaPRorpdSgwAiaNhGG46QesnIpAXnTSugfBhfSrHPvvP8y4I?=
 =?us-ascii?Q?Fzhi3pbcsgFhXbsGfi0aY/PQSkTDq7Hoy/F0iDKVglt3+XVZ4JYNZkLZdGYA?=
 =?us-ascii?Q?6GEdyNLYHv5pPukq8TvfEutnvbQF3Do2Js2ZLodJfyGZrq8rYHxpt2M5V49b?=
 =?us-ascii?Q?jNtGk/Ao04JliQFAh62o/iaofRdAciOs5+cwhZlGvrYqniX3AnsrZ9Je5h7Z?=
 =?us-ascii?Q?RYG/8SvITqleWXELI4+Vre+KZqtCgdX1XTP/bZXVIyMlDBYCuxNUow5eO3q6?=
 =?us-ascii?Q?/qRSprgj5k2nHyNUSKOzTAiqsYYhgKByL1vCVkgmT3Degi6awauYHYk4iDzg?=
 =?us-ascii?Q?FN8pFwoCX/uEIBuprjAemE8AfCGYtL/TMaxUyx2bQKgBDAsxvK+XgOUS7HLe?=
 =?us-ascii?Q?YaMYQ1dKJqvlOu5bPGXwbleH7T/MvMyy9P/GOj2mYFOnem5/Azvlr0JVWVsa?=
 =?us-ascii?Q?H/fqA2tLxr8xS/TmBl1YxfWBbHI4P+66ZQvDAWhVACuXtP+SnzgqFRrt7NyB?=
 =?us-ascii?Q?yujvqSiZOX4zHZg4iu6zz3pLwoLxM8NFRsKSf97KZDKqYZeb7+PXFVsAQbrV?=
 =?us-ascii?Q?McyIfvzaY70y310io4CX/VvKjAQlGzvVTY1teb4enSZcELMPFrKn+l5S5oHA?=
 =?us-ascii?Q?ZQP+f6uXR88qvZhEWDGOX6ITOK2bHb4iN8IudMWXuWMQMXjPPivNmi09cmCD?=
 =?us-ascii?Q?pF9oTekJVOHswWf+fGqoUrIWIjmc9arCvY6sZWyl8s9K2E6XRG/LU79Xj+ky?=
 =?us-ascii?Q?azz8Lw6bRnUaMccvp58YRPbjYZ7NTFsYlMibsXIDyZzucWtjvGxJrERMfYNK?=
 =?us-ascii?Q?1wqcT++/+KCzpP9ODk9tExevsph4MXElRLl2zKJYqnxvDghs6K+DTR97Teoy?=
 =?us-ascii?Q?/Y7VmFL2MzqdknaxKNtc0cG1EpcUe9othsTmyqKxxJLGN5YvdwDEGNOzS7u4?=
 =?us-ascii?Q?Op1XahQFWe6gbbvxwbnptNq3vqmda1sCsH82v5aauuWyhqCLNibQ442+88bf?=
 =?us-ascii?Q?QjXh2Q=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc54eca7-c366-4d83-9a44-08db383fb249
X-MS-Exchange-CrossTenant-AuthSource: BY3PR13MB4834.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2023 14:44:03.1922
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: myT80Su9COvlEMSNjOJbcRMACRVTidXwOD28xfOfGjV4J9OAwDOzT8tSVYjjjcq01e9vDgKl4Btgvj+5PvhnsxS9Gv1uHD6l2tE26EFTduM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR13MB6289
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 07, 2023 at 05:53:41PM +0530, Sai Krishna wrote:
> From: Suman Ghosh <sumang@marvell.com>
> 
> During the initial design, the IPv4 ip_flag mask was set to 0xff.
> Which results to filter only fragmets with (fragment_offset == 0).
> As part of the fix, updated the mask to 0x20 to filter all the
> fragmented packets irrespective of the fragment_offset value.
> 
> Fixes: c672e3727989 ("octeontx2-pf: Add support to filter packet based on IP fragment")
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> Signed-off-by: Sai Krishna <saikrishnag@marvell.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>