Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 8 Apr 2023 17:21:19 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Sai Krishna <saikrishnag@marvell.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, sgoutham@marvell.com,
        gakula@marvell.com, richardcochran@gmail.com, lcherian@marvell.com,
        jerinj@marvell.com, hkelam@marvell.com, sbhatta@marvell.com,
        Ratheesh Kannoth <rkannoth@marvell.com>
Subject: Re: [net PATCH v2 5/7] octeontx2-af: Fix issues with NPC field hash
 extract
Message-ID: <ZDGGbyXDjrnoJRcd@corigine.com>
References: <20230407122344.4059-1-saikrishnag@marvell.com>
 <20230407122344.4059-6-saikrishnag@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230407122344.4059-6-saikrishnag@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hgbzEyChY4QTPeDoX2im9R5sL/yvFc1yGJqHrPSQfqivoRvAOsbpSWVYfOe8?=
 =?us-ascii?Q?trQuRWBHdqQqGUx9/7IXdbTYhI64T/5oMKL9G8pPf7u6fnwsSAcuqEFvHiTs?=
 =?us-ascii?Q?ekyTgQG/YWwtsftJgORgS+qVTlJRWUu8/yeFnhA4lbIZFLdCBiXl9SoaCgfR?=
 =?us-ascii?Q?ryx95W8GUIMbG1LWAqUhR/fWWHYMZhAV/L7y4P1bwlUD+L2MqpXqWtX13DAe?=
 =?us-ascii?Q?1xDIzZ1AEcetRnF2DYTijY9BYbbWgjgTvsnGBG56cVLUgoLU2A3E+Q5BPEaT?=
 =?us-ascii?Q?3gRLUOzIKieWIJBj0ak62eTKvC5f+f2ivgZJhV2soD4xHda6dpEmR2YRaLJL?=
 =?us-ascii?Q?IXouc1SlEEgkfzEY+iGCXQ3y7LPaWhDkuSF8WJbQzwb6nEJnVLKhyg+Buex2?=
 =?us-ascii?Q?Q/wt4GgbcmtQLULmeuQrf5/AqZ4ZPDfv9rCW39z2Sg0kQttp+CVbT8rF1/Df?=
 =?us-ascii?Q?nYka7NLhqLlR1ZwsHaiSyj5pCRMUAHUubbfPKHEyi5gyNFbBSXqm/MMIS1DI?=
 =?us-ascii?Q?03zHBkIUA8NQAAHDN+BNCmGv6iqL9Wvq0+micl5muXShcp6rvPjlD8/ElKyJ?=
 =?us-ascii?Q?wTOwzfuyzuhmIBsrBNaI6NKaW0ZSwKrRDKjJZbQggCLqhhEmhGnMZVrya8Hh?=
 =?us-ascii?Q?tqYxGXjhcYXcNgo1dTRQ+mh70NlB9AyQX10uMRs1dD6dCN+6nazLUhAWl8So?=
 =?us-ascii?Q?VEpaTktCmnZFLxPoNVUuezGRSo9OcQxv5/RDmR1375JVAwuByHNwk9YxBEBf?=
 =?us-ascii?Q?3+6Elq6GsH7metsbI6kBBAn6A+IrcuMYwKb6lMvMEDiB9rgQrV0kurXAiVOB?=
 =?us-ascii?Q?jv96Yq0iFwwKaq/xQW1ZPvEBJGD1+aVy7eI4HYUqjpQDJWMhnuSCJq/Essk0?=
 =?us-ascii?Q?NqCvxRKch8LuMr0H0+wvwozvfKnOh/8ccOCvlWKyqB0HbA0xbNHMq1LjR6s6?=
 =?us-ascii?Q?j7w55AeS8SFLwdwVN2VGE0umAtxyMA68DNGVRxgNohAT3lx266eHycmyr7M1?=
 =?us-ascii?Q?DDi/vbvWe6fNDIg1+ucnDzxpPmvVlDs9onfTZRF+xXEwjkOfWeBwF+n5FKLq?=
 =?us-ascii?Q?0XNb2KkX+xNyfbKYeXyh1cVmdJtWH2Md12TSzu8SRoEzWcWVY58w7e5UKX98?=
 =?us-ascii?Q?SFmv1cPVu1EI0b0zuFLoAkzYY8kP+jLHrVMXgjgHRnbOVT0JCa2tSfS/yv6I?=
 =?us-ascii?Q?up2zPNC8ukVkd9WtZ80evVOYDnAlFy1+WduS+qcVIk1l0QT1aLlmuDUA1HJU?=
 =?us-ascii?Q?hXXGECWrwq5XuTHXnfOS+F6tvnKhhpGUXzOJ+ZPgw03XJRsJ+DD8yx3n8rxy?=
 =?us-ascii?Q?IFXCA6oY5XBKtNHOlkYKMPLqNL0PfW6Q7e1PwzTDMRljXvwZvzrzuAC3MePO?=
 =?us-ascii?Q?EaG42abDWBXEMYYymICxgawf51W84wDrH4TTVl1SMxkcZIzEDl+iEj1wHjST?=
 =?us-ascii?Q?csPNT7MuRobIWTjO6fYurK3S9K4rn7hGJ6rhWWWOjF0rh9VlVTky63IzqkBU?=
 =?us-ascii?Q?IqWSR0M9Vmyu32Q/nUnzdsOJdxNz94t7kUft1vfkms31qajWRoGcvG7YZfnf?=
 =?us-ascii?Q?hu4pAS5RHE/05Q43DAKTkDpRMIKNuWYlH4k2cSQtmnrl84E9fHjneM6Qk1r1?=
 =?us-ascii?Q?nhE1XVqfYJOyz7LBt8b6CJofvuWNDWpFptkl4+EN36ZwalD86Y8AS7qn4L4i?=
 =?us-ascii?Q?V66Lrw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23053fa5-6613-4968-da63-08db3844ec88
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2023 15:21:28.3368
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jpxFGEFoP8YGKqPRenMEHmGvXTg3MI/6whKfha6C4r9ne0ZIUPBBqkmmoP/YE2Gt1oh57VJL/CbukksUvhUOZbYynjJ9GSBhFTo+NhQ64Ns=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3806
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 07, 2023 at 05:53:42PM +0530, Sai Krishna wrote:
> From: Ratheesh Kannoth <rkannoth@marvell.com>
> 
> 1. As per previous implementation, mask and control parameter to
> generate the field hash value was not passed to the caller program.
> Updated the secret key mbox to share that information as well,
> as a part of the fix.
> 2. Earlier implementation did not consider hash reduction of both
> source and destination IPv6 addresses. Only source IPv6 address
> was considered. This fix solves that and provides option to hash
> reduce both source and destination IPv6 addresses.
> 3. Fix endianness issue during hash reduction while storing the IPv6
>  source/destination address as hash keys.
> 4. Configure hardware parser based on hash extract feature enable flag
>        for IPv6.

Hi Sai and Ratheesh,

there is a lot going on here.
Could you consider breaking this up into more than one patch?