Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 8 Apr 2023 17:32:51 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     m.chetan.kumar@intel.com, linuxwwan@intel.com,
        loic.poulain@linaro.org, ryazanov.s.a@gmail.com,
        johannes@sipsolutions.net, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        error27@gmail.com, kernel-janitors@vger.kernel.org,
        vegard.nossum@oracle.com
Subject: Re: [PATCH net] net: wwan: iosm: Fix error handling path in
 ipc_pcie_probe()
Message-ID: <ZDGJI8Q6lWCJdEMR@corigine.com>
References: <20230408065607.1633970-1-harshit.m.mogalapalli@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230408065607.1633970-1-harshit.m.mogalapalli@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?N7YkBL/03Oi8r9X1GLtPMO4DpvrlW4cbjCu9zxOfZZBCqp0zTLduKntD5Tbj?=
 =?us-ascii?Q?2iCvD9yRLPxEiuifQb8fkKVSIbCoZ4+pshDzXmzXFhyV8/VPmj2hui5D6WQV?=
 =?us-ascii?Q?DU56wkg6e0+Y2JMDQfPGDjySI3Lw7DQrZwJv2uajsxsTiAcUeRYulectFYqc?=
 =?us-ascii?Q?ezmsg/k1Olv08AZptqqP3fCwZvoK1GM+oVLbjnbgvDg3jvBxg5j6T62Gz0fY?=
 =?us-ascii?Q?bk4w3OqmgKeaQi0assr7GWGYZcqbGHN1PkDHJy2R69+H+Ga5+J3xZMHkrkCT?=
 =?us-ascii?Q?Ib8mKZKdbbP9TWP40RJJqGpTu8CJy+48CRrTCENL+T75D9p9AQg6ADfFvX8a?=
 =?us-ascii?Q?JshLla6DIMvK2eOX1EZ6jgm2TRfdsbSptyIKSuyg91rkgrB82afWmDpBW18K?=
 =?us-ascii?Q?4UDc30IK2wix+LXPOzzh61v0mCtG8PT8tkm44VQSEp904Je2QtUHx2fdGlyM?=
 =?us-ascii?Q?Oqj4abjkwomQ0pDl+8E1cqT3IMG1sUUGo4DXA0CVD18y5KkwrBIduq5dTKli?=
 =?us-ascii?Q?F7gQZs01dIKoxJyNmDCbhEjBDZPhtmyIWemdOMQEzI1EK6VE5YznaXsbZQLV?=
 =?us-ascii?Q?PBX7luDXMtm8L7baQHKfdmcU79yss0K41kjJoFhW4SanuNE8WEPsWY2jc4xS?=
 =?us-ascii?Q?UDx0Oz6rpRzksoxyqvS0BhjMPQa+ldPQztyqkkimut12J43orYLTM0yC2kxQ?=
 =?us-ascii?Q?rBthBZkcvGeZdZ/P2dBb2VzuwDIo4M/Py7NYGnn05WJBBMNDM7j3n9IfqXHg?=
 =?us-ascii?Q?F8KIYYcu0A9ZEnFm9iydL0qf7vMZBmgMhipJ8loOd/2JiDAJeDN6p8hmKnT9?=
 =?us-ascii?Q?o08bKCu/FZbSaLfFg2R+12dLkIH8JB6x+szkQ8ADmTA9wtTy+1Y9KK3tMZHv?=
 =?us-ascii?Q?54A6rAvjIL8De5PL5DF1dKjZN/e7zIMOwXjYY9G8KWSnoOShrtpEBW9woB/R?=
 =?us-ascii?Q?RrlvcfoyVkOearfd1/M8t4Zv4Gj0ARnGHvMbeIk1oVVfF1lIa5QlAqi3mWU+?=
 =?us-ascii?Q?yAO70TSjTSn2BEoo3fl2WGg3OxzUfo/GEczz6z7hCh57ZcVCtQd+OCurWlNi?=
 =?us-ascii?Q?5lWoePjhBPcCkgEEyiK/jWmf938GLYpP5vTU6dATLI5fflMfaZ8NVxUsjIN9?=
 =?us-ascii?Q?ZdNyiCDEV0iZqBCHEOtDKPDOqWb+9mYJWRd1rf0cKduhpI+sgDl/7daGcB45?=
 =?us-ascii?Q?FDcHHJRayQsIszJmZ1H09QzbvxOz/a4r3Ob8Tv8AE4+ra68Yd4YYUiAAdNMu?=
 =?us-ascii?Q?LXwOdNXqr9wVHZJ4Cxby1c3XbOMKoYbqy74Y2qSyq3zbklXIRol5Q6JXvpdu?=
 =?us-ascii?Q?H0iVudlz67n4HAXOCAsxf4wtzN/CxExI9auYGumRoYLV9mksBNUe77/hqz08?=
 =?us-ascii?Q?6FQjeZYI2hGbBPN7kpjMGGGicjg+peVU/j3q0ZzF6fcXXhLb30MFjm4AI96y?=
 =?us-ascii?Q?sUyfztKq3HjviLEMT5BNLl7bTRcvdL60rnu8T04XeWEIbskVy7Y5SGxmxMVw?=
 =?us-ascii?Q?9fyKbNQRlU2WO3fJ/znJxqyKPRNEQPPYHLfqtZEbAht4MG8rrV5Hm+M5mxTm?=
 =?us-ascii?Q?sNW6oUCqxskDNA5WdUYWQa9thBdJWeIxc4S8sHqoJ0gUjx4qyhGhaBwnQuz1?=
 =?us-ascii?Q?pO0GV0Cp0A71SikNXXt3wkxY/RZiCJymbNXszCU+mcH9LfUMMZbMiuVo4Map?=
 =?us-ascii?Q?Wn9ukQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49681a8c-4688-48bd-3523-08db38468830
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2023 15:32:58.9088
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7HnkH5mZ22HWb9XY5ab4s0lLyMc+bNmXgObbXjpmPmn4MxdihoVmNeKTeByHdiUhcC3sJBgxg2d23dGpLhp91nQaL9rZJynShqH2j1HzJrE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5422
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 07, 2023 at 11:56:07PM -0700, Harshit Mogalapalli wrote:
> Smatch reports:
> 	drivers/net/wwan/iosm/iosm_ipc_pcie.c:298 ipc_pcie_probe()
> 	warn: missing unwind goto?
> 
> When dma_set_mask fails it directly returns without disabling pci
> device and freeing ipc_pcie. Fix this my calling a correct goto label
> 
> As dma_set_mask returns either 0 or -EIO, we can use a goto label, as
> it finally returns -EIO.
> 
> Renamed the goto label as name of the label before this patch is not
> relevant after this patch.

nit: I agree that it's nice to name the labels after what they unwind,
rather than where they are called from. But now both schemes
are used in this function.
> 
> Fixes: 035e3befc191 ("net: wwan: iosm: fix driver not working with INTEL_IOMMU disabled")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> This is based on static analysis, only compile tested.

I agree with your analysis.

Reviewed-by: Simon Horman <simon.horman@corigine.com>