Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 8 Apr 2023 18:22:31 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kuba@kernel.org, davem@davemloft.net,
        willemdebruijn.kernel@gmail.com, andrew@lunn.ch,
        sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com,
        jerinj@marvell.com, sbhatta@marvell.com, naveenm@marvell.com,
        edumazet@google.com, pabeni@redhat.com, jhs@mojatatu.com,
        xiyou.wangcong@gmail.com, jiri@resnulli.us, maxtram95@gmail.com
Subject: Re: [net-next Patch v6 1/6] sch_htb: Allow HTB priority parameter in
 offload mode
Message-ID: <ZDGUx586cnbyPa4M@corigine.com>
References: <20230406102103.19910-1-hkelam@marvell.com>
 <20230406102103.19910-2-hkelam@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230406102103.19910-2-hkelam@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ajXRuyB/Q4Ff1k3iV1jy8qpPYHZrqrYPD3+sJjO40nvA1A5xp4xntibmZ5Hg?=
 =?us-ascii?Q?JifDPyhVLZHtxCAuxXJRFeTpcMcIYJ4I2cUd+uobBPhD7WiCc9gbhqG64jfM?=
 =?us-ascii?Q?LDKKvCgxKTXJyfNswNQbHNSCuGibT4J/CSlcWfb/h0xhMVWQzMFEk0GUfzoS?=
 =?us-ascii?Q?3hYrAGzmLVfJP7OnGBC2D+Al5wepwddbOeFfDbF9LU/YPonlrdZ9mzV0gD0Y?=
 =?us-ascii?Q?GFhsdIYLt/o7rfYNzKT9bWrjpj7QX6aqDJA0d8+eqRetd8KKgF9j/AdlQISH?=
 =?us-ascii?Q?fjYg+GVwNoY4UhqU7BwDzKIc2VkyCEQNHNlaQ+L1ppfAk8S0D0EYFCRmDpvk?=
 =?us-ascii?Q?LUiIFsjdjsPd/wHSzc0nzBblUnJfWd19lGpddiLV4VKo+5aJI0znXvWk3QA0?=
 =?us-ascii?Q?8cyD64Fy+FstSJ0d+iyOzVByKeXzoRXDORyEzXVMaUqrmxjJUWgIUFhUj1S3?=
 =?us-ascii?Q?VbjDIhPh0dpUQWPRaGdXe7q8qAR3FP6qTgsram7XwPo7RZpg4rFCXshvtxMZ?=
 =?us-ascii?Q?w/pgxAZBgHpS4GkyhAjHMf5bfQSdGwtaXL8ICNVJEOz8v7hxtoxS9KEbmODs?=
 =?us-ascii?Q?xHQ1lSSMKAjz0pW7xXbEc1sLphzkUcWwa2wqPvEA5SrWKaaJ1mQWQhm1pEPn?=
 =?us-ascii?Q?3X5VRDG6wFGfzygSyKJqLSveIIno7LpFWj5SjaknqLflOlAjk/nA/ZUxfJoT?=
 =?us-ascii?Q?2MurlTjV5CSG99fkxIbriKri2sctAfFuv6ftIsmdqItmMwcLBfwpwfb0TXLx?=
 =?us-ascii?Q?R4vkTk4NFwKLZu/NLRCFkrxiMCnSbkT/whp9/+oZfV82febcF7whjKYj9WXf?=
 =?us-ascii?Q?6OPZtxNLjpKBYZ8/XtSS4oE/flkPmeAGkp9cEfkcIV1ILDL67ZooO3mm6Jv8?=
 =?us-ascii?Q?SM3I0NAhyQOJvgmi2Q9UP/cz7UyHf1xLCwRHHQZQykaIVL5wkSfYF/Z9oV75?=
 =?us-ascii?Q?SsErrpTKBkil3VdvRqZYogGL1Ib206ONHW8mhXV4CjOhYylKwmxG/RvhL2Sx?=
 =?us-ascii?Q?hCz51MK9Pz/WXQBLGfkeMOm0PcN29WPfv9Kg2vmorH/hrZIv8GbPW3j45WLW?=
 =?us-ascii?Q?43LIGvDZCfANowNqE3FLHPO1jDC1oWDLmsnaZAGuwbeHdzsUdH1v5J8spoVV?=
 =?us-ascii?Q?zLPX0yWFmVNTZ5RfNyNe2cpl/g1T4latVWMFfTyBZcwpvbuxHVHJQHDvF8w7?=
 =?us-ascii?Q?cgxrcsgCzrkwV7sTmhw9kDv1QbYzDnaQkbg9+rkfGPrv4oSiT3Zvbm2bbZhG?=
 =?us-ascii?Q?rCtn2PhuxfAYLXmVEzSCvxGmBy/V2LUZseWoYzSEEPn5/p8ipLvFotXXtIaX?=
 =?us-ascii?Q?2H5CNwcXcBV/oK/ulggOuE5fqPon0UM/jXnmNdtvD9fGkQ9qk8C4L6h861a1?=
 =?us-ascii?Q?ppF/52DD6sHglvS6dmCvLhV7yT4PSTjmNnNnlh1w83OpPg+BIyfXV7Itcp93?=
 =?us-ascii?Q?oYgrtdvbnRcJ4k5Mxgh7CIoiCLSK1IswNZU36FwLPoCENPaSGqOE8hZHAiZX?=
 =?us-ascii?Q?BEIXklSlIvSpsAsmQ6iDWRRC5EUDCpF4cGS1BtJYElBVdmP7jW9IB6yZt6hn?=
 =?us-ascii?Q?StH0+ls7pGBOAaPYC6x54ZfaTyHC/7upbZGNI9EDmcNWp3yIXmXLqhkNlPU5?=
 =?us-ascii?Q?eWJNZiFb0HG2nrI3rkcrjks9/KpXTcqq3Cr9Ytxy+6aa/anH895clEyUJu1R?=
 =?us-ascii?Q?EDCbOQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d2427a8-b6e6-43c1-f090-08db384d7839
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2023 16:22:38.6243
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aQJT/gnVMcwE4pDifc3T8dc/EZLEhS3pgJXQxjSdtIje8ZtU5tVvjSLIQJhK6BH1gYioXzngh8XofaJnphb0tBFC5w/7GidG3rvkhWzjXIk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR13MB4014
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 06, 2023 at 03:50:58PM +0530, Hariprasad Kelam wrote:
> From: Naveen Mamindlapalli <naveenm@marvell.com>
> 
> The current implementation of HTB offload returns the EINVAL error
> for unsupported parameters like prio and quantum. This patch removes
> the error returning checks for 'prio' parameter and populates its
> value to tc_htb_qopt_offload structure such that driver can use the
> same.
> 
> Add prio parameter check in mlx5 driver, as mlx5 devices are not capable
> of supporting the prio parameter when htb offload is used. Report error
> if prio parameter is set to a non-default value.
> 
> Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
> Co-developed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>