Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp2892605rwl; Sun, 9 Apr 2023 03:53:12 -0700 (PDT) X-Google-Smtp-Source: AKy350YjanbtkXl7ogWKZHcbsG0WsX/CGR+wMxKqPjB4v3KlS/ymT2XuhsKva9qyy5GZ55DaqQKR X-Received: by 2002:a17:903:2302:b0:1a1:d774:a3d7 with SMTP id d2-20020a170903230200b001a1d774a3d7mr16374222plh.25.1681037592491; Sun, 09 Apr 2023 03:53:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681037592; cv=none; d=google.com; s=arc-20160816; b=OgZU/wCzZjik6MO6hJvy7XUWTrTleX5V0CZlIhzsH909MwxD+SPa/hJgUEGMr7EZZj bg1vaBLhu574XRi7HFIXSXPt4k++wZkI/KzfkyPFJlT3s5LG31MpkJDt2ohpGl8SMkZ7 9tBJ0YqcyfStR775tSmW2zD3+LYWDMOvC3JXfkpUUd1DTBK7iBKkWrYTAaEdKTJRP9DE RaA6JUmKk6umW9cVZu27hpHQLRY8lOOFw/2qBD9RRT2J71mutd90C29Y2a5CeRXNsRTc bgH9K/T6IHJb7oPG/XGuio/LoB0TU18Ku59hZ+HMAEJwzRNA02tiAgNLrPOOazU0OIg+ NXYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=RBhBqVVrwz5fm1k6Ujjqr4Fn8AFpLrNIYbBy6hw7GT0=; b=DY13ljPj4UuNLjgnJzUF4+mb1jsfzoU6ZaK/Vu3+fr8s3m9NWxU74+2xcViL3ldtOY TNvmNjfGI+JeVuBwPYnhNxcpyA4X/nnhlFRN8H3kpQkIQc8kxskElAL7y5gZsEUmKtpq VcPeGMXfKPUd4EwwXtC86yMka64UIeJkQMyDBkPiV3uMBAefPJKv93jQ0tL7J0uC6cag LdrBvJFFfR90d3kDqDp5TC80682KOwgSSLMSdXdP34fCxaiUicwbxZLNUxYK6x94OlAv buMhvREw2J1iITZ+V1PFTbDIavSjzryi/WeDzAJu7xok0q1lENTjd+7BEY2XmiomdzjA OVqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a4-20020a170902b58400b001a6387faaa6si688139pls.422.2023.04.09.03.52.50; Sun, 09 Apr 2023 03:53:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229502AbjDIKwa (ORCPT + 99 others); Sun, 9 Apr 2023 06:52:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjDIKw3 (ORCPT ); Sun, 9 Apr 2023 06:52:29 -0400 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DB5549DE for ; Sun, 9 Apr 2023 03:52:27 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R251e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VfcswfY_1681037541; Received: from 30.13.186.222(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VfcswfY_1681037541) by smtp.aliyun-inc.com; Sun, 09 Apr 2023 18:52:24 +0800 Message-ID: <013084a3-8a80-9825-66b9-e4bd6674169e@linux.alibaba.com> Date: Sun, 9 Apr 2023 18:52:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/7] erofs: initialize packed inode after root inode is assigned To: Jingbo Xu , xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org References: <20230407141710.113882-1-jefflexu@linux.alibaba.com> <20230407141710.113882-3-jefflexu@linux.alibaba.com> From: Gao Xiang In-Reply-To: <20230407141710.113882-3-jefflexu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.9 required=5.0 tests=ENV_AND_HDR_SPF_MATCH, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/4/7 22:17, Jingbo Xu wrote: > As commit 8f7acdae2cd4 ("staging: erofs: kill all failure handling in > fill_super()"), move the initialization of packed inode after root > inode is assigned, so that the iput() in .put_super() is adequate as > the failure handling. > > Otherwise, iput() is also needed in .kill_sb(), in case of the mounting > fails halfway. > Fixes: b15b2e307c3a ("erofs: support on-disk compressed fragments data") > Signed-off-by: Jingbo Xu Reviewed-by: Gao Xiang Thanks, Gao Xiang