Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cfcd6736-f822-fdda-a84d-4f4bb91cd653@gmail.com>
Date:   Sun, 9 Apr 2023 16:25:02 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.1
Subject: Re: [PATCH] regulator: sm5703: Fix missing n_voltages for fixed
 regulators
Content-Language: en-US
To:     Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org
References: <20230409025529.241699-1-axel.lin@ingics.com>
From:   Markuss Broks <markuss.broks@gmail.com>
In-Reply-To: <20230409025529.241699-1-axel.lin@ingics.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Looks good.

Reviewed-by: Markuss Broks <markuss.broks@gmail.com>

On 4/9/23 05:55, Axel Lin wrote:
> Set n_voltages = 1 for fixed regulators.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>   drivers/regulator/sm5703-regulator.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/regulator/sm5703-regulator.c b/drivers/regulator/sm5703-regulator.c
> index 38e66df378a5..702461cf075e 100644
> --- a/drivers/regulator/sm5703-regulator.c
> +++ b/drivers/regulator/sm5703-regulator.c
> @@ -42,6 +42,7 @@ static const int sm5703_buck_voltagemap[] = {
>   		.type = REGULATOR_VOLTAGE,				\
>   		.id = SM5703_USBLDO ## _id,				\
>   		.ops = &sm5703_regulator_ops_fixed,			\
> +		.n_voltages = 1,					\
>   		.fixed_uV = SM5703_USBLDO_MICROVOLT,			\
>   		.enable_reg = SM5703_REG_USBLDO12,			\
>   		.enable_mask = SM5703_REG_EN_USBLDO ##_id,		\
> @@ -56,6 +57,7 @@ static const int sm5703_buck_voltagemap[] = {
>   		.type = REGULATOR_VOLTAGE,				\
>   		.id = SM5703_VBUS,					\
>   		.ops = &sm5703_regulator_ops_fixed,			\
> +		.n_voltages = 1,					\
>   		.fixed_uV = SM5703_VBUS_MICROVOLT,			\
>   		.enable_reg = SM5703_REG_CNTL,				\
>   		.enable_mask = SM5703_OPERATION_MODE_MASK,		\