Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com>
Date:   Sun, 9 Apr 2023 21:00:24 +0200
From:   Salvatore Bonaccorso <carnil@debian.org>
To:     Xu Yilun <yilun.xu@intel.com>, Sangsup Lee <k1rh4.lee@gmail.com>
Cc:     k1rh4.lee@gmail.com, Wu Hao <hao.wu@intel.com>,
        Tom Rix <trix@redhat.com>, Moritz Fischer <mdf@kernel.org>,
        linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: dfl-afu-region: Add overflow checks for region
 size and offset
Message-ID: <ZDMLSOoMt5Ims6xT@eldamar.lan>
References: <20230206054326.89323-1-k1rh4.lee@gmail.com>
 <Y+X+kZResf0a/aES@yilunxu-OptiPlex-7050>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+X+kZResf0a/aES@yilunxu-OptiPlex-7050>
Precedence: bulk

Hi,

On Fri, Feb 10, 2023 at 04:21:37PM +0800, Xu Yilun wrote:
> On 2023-02-05 at 21:43:26 -0800, k1rh4.lee@gmail.com wrote:
> > From: Sangsup Lee <k1rh4.lee@gmail.com>
> > 
> > The size + offset is able to be integer overflow value and it lead to mis-allocate region.
> 
> But I didn't see the memory allocation.
> 
> > 
> > Signed-off-by: Sangsup Lee <k1rh4.lee@gmail.com>
> > ---
> >  drivers/fpga/dfl-afu-region.c | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/fpga/dfl-afu-region.c b/drivers/fpga/dfl-afu-region.c
> > index 2e7b41629406..82b530111601 100644
> > --- a/drivers/fpga/dfl-afu-region.c
> > +++ b/drivers/fpga/dfl-afu-region.c
> > @@ -151,12 +151,17 @@ int afu_mmio_region_get_by_offset(struct dfl_feature_platform_data *pdata,
> >  	struct dfl_afu_mmio_region *region;
> >  	struct dfl_afu *afu;
> >  	int ret = 0;
> > +	u64 region_size = 0;
> 
> Reverse Xmax tree please.
> 
> >  
> >  	mutex_lock(&pdata->lock);
> > +	if (check_add_overflow(offset, size, &region_size)) {
> 
> I'm not sure if the check is necessary.
> 
> The offset comes from: offset = vma->vm_pgoff << PAGE_SHIFT
> The size comes from: size = vma->vm_end - vma->vm_start
> Is it possible the upper mm layer passes invalid vma?
> 
> Thanks,
> Yilun

Did you saw the comments on your patch by Yilun? Did it felt trough
the cracks?

Regards,
Salvatore